mbox series

[v7,0/3] BBDEV turbo_sw PMD compilation fix

Message ID 1560966518-75547-1-git-send-email-nicolas.chautru@intel.com (mailing list archive)
Headers
Series BBDEV turbo_sw PMD compilation fix |

Message

Chautru, Nicolas June 19, 2019, 5:48 p.m. UTC
  Update v7: Remove architecture specific reference to RTE_CPUFLAG_SSE4_2 reported on travis-ci
Update v6: Cosmetic change to commit message to include previous Acked-by. 
Update v5: Cosmetic change to remove trailing space and to commit message. Rebased to latest. 
Update v4: Missed one file for meson build path and minor change to prevent warning for some configurations due to unused symbols. 
Update v3: Cosmetic changes in documentation commit to be more 4G/AVX2 specific. 
Update v2: Splitting into 3 patches as recommended (ignore previous v2 which had a typo)

Based on discussion with maintainer, pushing first a patch to help maintenance of the baseband_turbo_sw which had been lacking.
The documentation is clarified to point to steps on building the SDK libraries which are now publicly available.
(Cosmetic changes to the webpage containing these SDK  will happen in parallel based on feedback from maintainer).
A compile flag is added to be able to build the turbo_sw PMD when the SDK libraries for AVX2 are installed or not. 
In both cases this can be compiled with gcc RTE_TARGET. 
Missing meson build support is also added. 

Note that additional BBDEV changes pushed in previous v1
https://patches.dpdk.org/project/dpdk/list/?series=4657
will be added in a separate v2 patchset which will depend on this very patchset.


Nicolas Chautru (3):
  baseband/turbo_sw: option to build turbosw PMD without SDK
  docs/guides: updating turbo_sw building steps
  baseband/turbo_sw: meson build support for PMD driver

 config/common_base                               |  3 +-
 doc/guides/bbdevs/turbo_sw.rst                   | 81 +++++++++++++-----------
 drivers/baseband/meson.build                     |  2 +-
 drivers/baseband/turbo_sw/Makefile               | 13 ++--
 drivers/baseband/turbo_sw/bbdev_turbo_software.c | 51 ++++++++++++++-
 drivers/baseband/turbo_sw/meson.build            | 30 +++++++++
 meson_options.txt                                |  2 +
 mk/rte.app.mk                                    |  3 +
 8 files changed, 138 insertions(+), 47 deletions(-)
 create mode 100644 drivers/baseband/turbo_sw/meson.build
  

Comments

Ferruh Yigit June 20, 2019, 5:33 p.m. UTC | #1
On 6/19/2019 6:48 PM, Nicolas Chautru wrote:
> Update v7: Remove architecture specific reference to RTE_CPUFLAG_SSE4_2 reported on travis-ci
> Update v6: Cosmetic change to commit message to include previous Acked-by. 
> Update v5: Cosmetic change to remove trailing space and to commit message. Rebased to latest. 
> Update v4: Missed one file for meson build path and minor change to prevent warning for some configurations due to unused symbols. 
> Update v3: Cosmetic changes in documentation commit to be more 4G/AVX2 specific. 
> Update v2: Splitting into 3 patches as recommended (ignore previous v2 which had a typo)
> 
> Based on discussion with maintainer, pushing first a patch to help maintenance of the baseband_turbo_sw which had been lacking.
> The documentation is clarified to point to steps on building the SDK libraries which are now publicly available.
> (Cosmetic changes to the webpage containing these SDK  will happen in parallel based on feedback from maintainer).
> A compile flag is added to be able to build the turbo_sw PMD when the SDK libraries for AVX2 are installed or not. 
> In both cases this can be compiled with gcc RTE_TARGET. 
> Missing meson build support is also added. 
> 
> Note that additional BBDEV changes pushed in previous v1
> https://patches.dpdk.org/project/dpdk/list/?series=4657
> will be added in a separate v2 patchset which will depend on this very patchset.
> 
> 
> Nicolas Chautru (3):
>   baseband/turbo_sw: option to build turbosw PMD without SDK
>   docs/guides: updating turbo_sw building steps
>   baseband/turbo_sw: meson build support for PMD driver
> 

For series,
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Akhil Goyal June 25, 2019, 12:41 p.m. UTC | #2
> 
> On 6/19/2019 6:48 PM, Nicolas Chautru wrote:
> > Update v7: Remove architecture specific reference to RTE_CPUFLAG_SSE4_2
> reported on travis-ci
> > Update v6: Cosmetic change to commit message to include previous Acked-by.
> > Update v5: Cosmetic change to remove trailing space and to commit message.
> Rebased to latest.
> > Update v4: Missed one file for meson build path and minor change to prevent
> warning for some configurations due to unused symbols.
> > Update v3: Cosmetic changes in documentation commit to be more 4G/AVX2
> specific.
> > Update v2: Splitting into 3 patches as recommended (ignore previous v2 which
> had a typo)
> >
> > Based on discussion with maintainer, pushing first a patch to help maintenance
> of the baseband_turbo_sw which had been lacking.
> > The documentation is clarified to point to steps on building the SDK libraries
> which are now publicly available.
> > (Cosmetic changes to the webpage containing these SDK  will happen in
> parallel based on feedback from maintainer).
> > A compile flag is added to be able to build the turbo_sw PMD when the SDK
> libraries for AVX2 are installed or not.
> > In both cases this can be compiled with gcc RTE_TARGET.
> > Missing meson build support is also added.
> >
> > Note that additional BBDEV changes pushed in previous v1
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.
> dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D4657&amp;data=02%7C0
> 1%7Cakhil.goyal%40nxp.com%7Cedc9d3ef619248e7b86b08d6f5a56bdd%7C686
> ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636966488159758077&amp;s
> data=KEjtdAELhz61dVb3V7SQ8WPoEw5eC59VD9UYOVgiif0%3D&amp;reserved=
> 0
> > will be added in a separate v2 patchset which will depend on this very patchset.
> >
> >
> > Nicolas Chautru (3):
> >   baseband/turbo_sw: option to build turbosw PMD without SDK
> >   docs/guides: updating turbo_sw building steps
> >   baseband/turbo_sw: meson build support for PMD driver
> >
> 
> For series,
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series Applied to dpdk-next-crypto

Thanks.