mbox series

[v3,0/4] et/virtio: Fix packet segmentation bug

Message ID 20190605100039.18029-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series et/virtio: Fix packet segmentation bug |

Message

Maxime Coquelin June 5, 2019, 10 a.m. UTC 
  This series fixes a bug reported by Yaroslav, where segmented
packets miss some segments and head segment's data_len was set
to a wrong value.

Last patch is not a fix, but it removes some useless checks
in Rx paths.

v3:
- Fix properly haed segment's data_len (David)
v2:
- Fix head segment's data_len (Yaroslav)

Maxime Coquelin (4):
  net/virtio: fix segmented packet issue in in-order Rx path
  net/virtio: fix segmented packet issue in mergeable Rx path
  net/virtio: fix segment data len in mergeable packed Rx path
  net/virtio: remove useless pointers checks

 drivers/net/virtio/virtio_rxtx.c | 27 ++++++---------------------
 1 file changed, 6 insertions(+), 21 deletions(-)

Comments

Tiwei Bie June 5, 2019, 1:25 p.m. UTC | #1 
On Wed, Jun 05, 2019 at 12:00:35PM +0200, Maxime Coquelin wrote:
> This series fixes a bug reported by Yaroslav, where segmented
> packets miss some segments and head segment's data_len was set
> to a wrong value.
> 
> Last patch is not a fix, but it removes some useless checks
> in Rx paths.
> 
> v3:
> - Fix properly haed segment's data_len (David)
> v2:
> - Fix head segment's data_len (Yaroslav)
> 
> Maxime Coquelin (4):
>   net/virtio: fix segmented packet issue in in-order Rx path
>   net/virtio: fix segmented packet issue in mergeable Rx path
>   net/virtio: fix segment data len in mergeable packed Rx path
>   net/virtio: remove useless pointers checks
> 
>  drivers/net/virtio/virtio_rxtx.c | 27 ++++++---------------------
>  1 file changed, 6 insertions(+), 21 deletions(-)

For the series,
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks!
Maxime Coquelin June 6, 2019, 9:31 a.m. UTC | #2 
On 6/5/19 12:00 PM, Maxime Coquelin wrote:
> This series fixes a bug reported by Yaroslav, where segmented
> packets miss some segments and head segment's data_len was set
> to a wrong value.
> 
> Last patch is not a fix, but it removes some useless checks
> in Rx paths.
> 
> v3:
> - Fix properly haed segment's data_len (David)
> v2:
> - Fix head segment's data_len (Yaroslav)
> 
> Maxime Coquelin (4):
>    net/virtio: fix segmented packet issue in in-order Rx path
>    net/virtio: fix segmented packet issue in mergeable Rx path
>    net/virtio: fix segment data len in mergeable packed Rx path
>    net/virtio: remove useless pointers checks
> 
>   drivers/net/virtio/virtio_rxtx.c | 27 ++++++---------------------
>   1 file changed, 6 insertions(+), 21 deletions(-)
> 

Series applied to dpdk-next-virtio/master with typos in commit messages
fixed.

Thanks,
Maxime