[0/9] add QAT support for digest encrypted
mbox series

Message ID 20190603145048.2596-1-damianx.nowak@intel.com
Headers show
Series
  • add QAT support for digest encrypted
Related show

Message

Damian Nowak June 3, 2019, 2:50 p.m. UTC
From: Damian Nowak <damianx.nowak@intel.com>

This patchset adds digest appended and encrypted
auth-cipher operations support for QAT, with
dedicated feature flag and a set of tests
for KASUMI and SNOW3G in-place, out-of-place
and SGL using operations.

Damian Nowak (9):
  crypto/qat: check buffer size for oop auth-cipher
  test/crypto: add snow3g test cases for oop operation
  test/crypto: add kasumi test cases for oop operation
  test/crypto: add sgl test cases for ip and oop
  cryptodev: document usage of digest-appended operations
  cryptodev: add digest encrypted feature flag
  crypto/qat: add digest encrypted feature flag
  test/crypto: add digest encrypted feature flag check
  test/crypto: return correct value if feature not supported

 app/test/test_cryptodev.c                     | 668 ++++++++++++++++++++++----
 app/test/test_cryptodev_kasumi_test_vectors.h |  98 +++-
 app/test/test_cryptodev_snow3g_test_vectors.h | 167 ++++++-
 drivers/crypto/qat/qat_sym.c                  |  30 +-
 drivers/crypto/qat/qat_sym_pmd.c              |   3 +-
 lib/librte_cryptodev/rte_crypto_sym.h         |  43 ++
 lib/librte_cryptodev/rte_cryptodev.c          |   2 +
 lib/librte_cryptodev/rte_cryptodev.h          |   2 +
 8 files changed, 895 insertions(+), 118 deletions(-)

Comments

Trahe, Fiona June 4, 2019, 1:16 p.m. UTC | #1
Hi Damian,

> -----Original Message-----
> From: Nowak, DamianX
> Sent: Monday, June 3, 2019 3:51 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Nowak,
> DamianX <damianx.nowak@intel.com>
> Subject: [PATCH 0/9] add QAT support for digest encrypted
> 
> From: Damian Nowak <damianx.nowak@intel.com>
> 
> This patchset adds digest appended and encrypted
> auth-cipher operations support for QAT, with
> dedicated feature flag and a set of tests
> for KASUMI and SNOW3G in-place, out-of-place
> and SGL using operations. 
[Fiona] As this patchset is not just QAT changes, but includes an API clarification and extension
it should be renamed something like 
cryptodev: support encrypted-digest use-cases
and patches should be ordered:
 - API patches
 - QAT driver patches
 - Test code patches
 - Documentation patches - release note patch should be added

> Damian Nowak (9):
>   crypto/qat: check buffer size for oop auth-cipher
>   test/crypto: add snow3g test cases for oop operation
>   test/crypto: add kasumi test cases for oop operation
>   test/crypto: add sgl test cases for ip and oop
>   cryptodev: document usage of digest-appended operations
>   cryptodev: add digest encrypted feature flag
>   crypto/qat: add digest encrypted feature flag
>   test/crypto: add digest encrypted feature flag check
>   test/crypto: return correct value if feature not supported
> 
>  app/test/test_cryptodev.c                     | 668 ++++++++++++++++++++++----
>  app/test/test_cryptodev_kasumi_test_vectors.h |  98 +++-
>  app/test/test_cryptodev_snow3g_test_vectors.h | 167 ++++++-
>  drivers/crypto/qat/qat_sym.c                  |  30 +-
>  drivers/crypto/qat/qat_sym_pmd.c              |   3 +-
>  lib/librte_cryptodev/rte_crypto_sym.h         |  43 ++
>  lib/librte_cryptodev/rte_cryptodev.c          |   2 +
>  lib/librte_cryptodev/rte_cryptodev.h          |   2 +
>  8 files changed, 895 insertions(+), 118 deletions(-)
> 
> --
> 2.7.4