[v5,0/5] make lcore_config internal
mbox series

Message ID 1559317022-28779-1-git-send-email-david.marchand@redhat.com
Headers show
Series
  • make lcore_config internal
Related show

Message

David Marchand May 31, 2019, 3:36 p.m. UTC
This set of patches makes the lcore_config structure less visible
as part of the ABI.  This version does not break the ABI (yet)
follow on patch moves lcore_config into eal_private.h

Changelog since v4:
The only change is in patch 2: marked new apis as experimental.

Changelog since v3:
I took the liberty of taking over Stephen series.
I rebased and did some adjustments following [1] cleanups.
As stated before, we will still need a deprecation notice when hiding
lcore_config but this series does not break API nor ABI.

Changelog since v2:
 - new patch to use unsigned int in lcore.h first
 - incorporate feedback from David
 - don't include last patch to make it private
        (to avoid accidental early merge)

1: http://patchwork.dpdk.org/patch/53621/

Comments

Thomas Monjalon June 3, 2019, 10:32 a.m. UTC | #1
31/05/2019 17:36, David Marchand:
> This set of patches makes the lcore_config structure less visible
> as part of the ABI.  This version does not break the ABI (yet)
> follow on patch moves lcore_config into eal_private.h
> 
> Changelog since v4:
> The only change is in patch 2: marked new apis as experimental.
> 
> Changelog since v3:
> I took the liberty of taking over Stephen series.
> I rebased and did some adjustments following [1] cleanups.
> As stated before, we will still need a deprecation notice when hiding
> lcore_config but this series does not break API nor ABI.
> 
> Changelog since v2:
>  - new patch to use unsigned int in lcore.h first
>  - incorporate feedback from David
>  - don't include last patch to make it private
>         (to avoid accidental early merge)

Applied, thanks
Stephen Hemminger June 3, 2019, 8:15 p.m. UTC | #2
On Mon, 03 Jun 2019 12:32:02 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 31/05/2019 17:36, David Marchand:
> > This set of patches makes the lcore_config structure less visible
> > as part of the ABI.  This version does not break the ABI (yet)
> > follow on patch moves lcore_config into eal_private.h
> > 
> > Changelog since v4:
> > The only change is in patch 2: marked new apis as experimental.
> > 
> > Changelog since v3:
> > I took the liberty of taking over Stephen series.
> > I rebased and did some adjustments following [1] cleanups.
> > As stated before, we will still need a deprecation notice when hiding
> > lcore_config but this series does not break API nor ABI.
> > 
> > Changelog since v2:
> >  - new patch to use unsigned int in lcore.h first
> >  - incorporate feedback from David
> >  - don't include last patch to make it private
> >         (to avoid accidental early merge)  
> 
> Applied, thanks
> 
> 

Thanks. Now to get to eal_config