From patchwork Tue May 28 11:18:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moti Haimovsky X-Patchwork-Id: 53732 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 998303576; Tue, 28 May 2019 13:18:47 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48]) by dpdk.org (Postfix) with ESMTP id 4B58C137D for ; Tue, 28 May 2019 13:18:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yW/xo/jw4bnxaY9TcCU+TSY2QR+14pBSzPOa1sAGg+o=; b=PQKosXphAtLxV9o99Q8gQu0NLcQkFulFb8rkRFrH00oWlEqnh2s5rIt8zFx70RgmwZfXe27o4oT3bn0/E0XuQPL7BsMh68fdmQeOWJC37JYo/UZtId9gj/kZG0RH0AxENcqKjU6RdxHaCGPkNS3w3vtmcsVMFb3QXNZC9OnjlKc= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.95.151) by AM0PR05MB5633.eurprd05.prod.outlook.com (20.178.115.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.20; Tue, 28 May 2019 11:18:45 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::c40a:d6fe:1246:7278]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::c40a:d6fe:1246:7278%4]) with mapi id 15.20.1922.021; Tue, 28 May 2019 11:18:45 +0000 From: Moti Haimovsky To: Shahaf Shuler CC: "dev@dpdk.org" , Moti Haimovsky Thread-Topic: [PATCH 0/2] net/mlx5: remove TCF support from PMD Thread-Index: AQHVFUccdp/ka8ys502E3CFEH0WhBQ== Date: Tue, 28 May 2019 11:18:44 +0000 Message-ID: <1559042301-73445-1-git-send-email-motih@mellanox.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0318.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::18) To AM0PR05MB4435.eurprd05.prod.outlook.com (2603:10a6:208:61::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.8.3.1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dde7c4db-5646-41bd-553c-08d6e35e3f3a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR05MB5633; x-ms-traffictypediagnostic: AM0PR05MB5633: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 00514A2FE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(39860400002)(136003)(199004)(189003)(8676002)(186003)(8936002)(37006003)(26005)(81166006)(81156014)(107886003)(5660300002)(3846002)(6116002)(54906003)(4743002)(50226002)(4326008)(36756003)(305945005)(6436002)(478600001)(53936002)(86362001)(14454004)(6862004)(25786009)(6512007)(6486002)(486006)(316002)(2616005)(476003)(2906002)(71200400001)(256004)(14444005)(4720700003)(6636002)(386003)(52116002)(68736007)(102836004)(99286004)(6506007)(66476007)(73956011)(66946007)(7736002)(66556008)(64756008)(66446008)(66066001)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5633; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: v8W10EzYEZFxd9av1DPM0LgixONAwc0hGiDSNQbYebTEeNM8msefPV7JACCZA1L7miGoRdl9cvsyQNDEdaMJ+tDqsxEYzKcDCtHcIi5m6SJ4LJis2Ucj9zgDa5knSUM/fRb/sdWCSsd3SLzstk8EOT9XQoZdDfbwMcdYIWuuLpcOHPp05U/ZhyLnSNS1AC8ly70huoseRHDA5L6kv95td3zKBBWLjO/WnVCCLWqjwipRc0hfSU3ulTBQDf3iC9gkb9Z2R9DunDj1IJ3POl+Ayacyc/+uYpK+6FGwdi3mKsrbnd9B7o6wraLcxInsFjKULZ+DY0YnoRqBt9Qh/hnraM/xyDPm616QJ5bGv+ZFlnQ0CrpqGF6RbV9uJCI78U3hS432A92pSMiAlQo0+IEk5RErzBjESoKvsOpDvxFrtJI= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dde7c4db-5646-41bd-553c-08d6e35e3f3a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2019 11:18:44.9810 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: motih@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5633 Subject: [dpdk-dev] [PATCH 0/2] net/mlx5: remove TCF support from PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Today, it is possible to offload an interface flow rules to the hardware using DPDK flow commands. With mlx5 it is also possible to offload a limited set of flow rules to the mlxsw (or E-switch) using the same DPDK flow commands. A 'transfer' attribute was added to the flow rule creation command in order to distinguish between configuring port flows and E-switch flows. The commands destined for the E-switch are transposed to TC-flower rules and are send, as Netlink messages, to the mlx5 driver, or more precisely to the netdev which represent the mlxsw port. With the addition to the PMD of E-switch configuration via DR (direct verbs rules) it is now possible to configure the E-switch using these commands instead of using TC-Flower messages. Doing so will allow us to remove the TCF support and the dependency of libmnl from the PMD. The purpose of this RFC is to propose configuring the E-switch flow filtering using DR, to remove the TCF support from the PMD and to remove the dependency of the PMD in libmnl. As for today VLAN insertion or removal is not supported in DR, this support will be added in separate commits. Moti Haimovsky (2): net/mlx5: fix testpmd crash on null-flow drv opts net/mlx5: remove TCF support from PMD doc/build-sdk-meson.txt | 2 +- doc/guides/nics/mlx5.rst | 19 - doc/guides/platform/bluefield.rst | 4 - drivers/net/mlx5/Makefile | 303 -- drivers/net/mlx5/meson.build | 123 +- drivers/net/mlx5/mlx5.c | 32 - drivers/net/mlx5/mlx5.h | 3 - drivers/net/mlx5/mlx5_flow.c | 43 +- drivers/net/mlx5/mlx5_flow.h | 25 - drivers/net/mlx5/mlx5_flow_tcf.c | 6382 ------------------------------------- mk/rte.app.mk | 2 +- 11 files changed, 24 insertions(+), 6914 deletions(-) delete mode 100644 drivers/net/mlx5/mlx5_flow_tcf.c