[v2,0/5] fix 32-bit meson builds
mbox series

Message ID 20190528110748.10772-1-bruce.richardson@intel.com
Headers show
Series
  • fix 32-bit meson builds
Related show

Message

Bruce Richardson May 28, 2019, 11:07 a.m. UTC
This set fixes some issues seen on the automated CI system with building
on 32-bit Linux distro's using meson and ninja. The fixes are to disable
unsupported parts of the build, and switch the 32-bit builds to always
having large file support, so that make and meson are consistent in that
regard.

V2: add two additional patches to fix clang builds. This allows the
    test-meson-builds.sh script to run successfully on 32-bit Ubuntu
    16.04 systems.

Bruce Richardson (5):
  net/nfp: disable nfp for 32-bit meson builds
  build: enable large file support on 32-bit
  build: remove unnecessary large file support defines
  eal: mark unused function in 32-bit builds
  build: add libatomic dependency for 32-bit clang compile

 drivers/common/dpaax/dpaax_iova_table.c | 4 ++--
 drivers/event/octeontx/meson.build      | 5 +++++
 drivers/event/opdl/meson.build          | 5 +++++
 drivers/net/nfp/meson.build             | 2 +-
 examples/vhost_crypto/meson.build       | 1 -
 examples/vhost_scsi/meson.build         | 1 -
 lib/librte_eal/linux/eal/eal_memalloc.c | 1 -
 lib/librte_eal/linux/eal/eal_memory.c   | 2 +-
 lib/librte_rcu/meson.build              | 5 +++++
 lib/librte_vhost/Makefile               | 2 +-
 mk/arch/arm/rte.vars.mk                 | 2 +-
 mk/arch/i686/rte.vars.mk                | 2 +-
 12 files changed, 22 insertions(+), 10 deletions(-)

Comments

Thomas Monjalon June 3, 2019, 10 p.m. UTC | #1
28/05/2019 13:07, Bruce Richardson:
> This set fixes some issues seen on the automated CI system with building
> on 32-bit Linux distro's using meson and ninja. The fixes are to disable
> unsupported parts of the build, and switch the 32-bit builds to always
> having large file support, so that make and meson are consistent in that
> regard.
> 
> V2: add two additional patches to fix clang builds. This allows the
>     test-meson-builds.sh script to run successfully on 32-bit Ubuntu
>     16.04 systems.
> 
> Bruce Richardson (5):
>   net/nfp: disable nfp for 32-bit meson builds
>   build: enable large file support on 32-bit
>   build: remove unnecessary large file support defines
>   eal: mark unused function in 32-bit builds
>   build: add libatomic dependency for 32-bit clang compile

Applied, thanks
Kevin Traynor Oct. 2, 2019, 3:11 p.m. UTC | #2
On 28/05/2019 12:07, Bruce Richardson wrote:
> This set fixes some issues seen on the automated CI system with building
> on 32-bit Linux distro's using meson and ninja. The fixes are to disable
> unsupported parts of the build, and switch the 32-bit builds to always
> having large file support, so that make and meson are consistent in that
> regard.
> 
> V2: add two additional patches to fix clang builds. This allows the
>     test-meson-builds.sh script to run successfully on 32-bit Ubuntu
>     16.04 systems.
> 
> Bruce Richardson (5):
>   net/nfp: disable nfp for 32-bit meson builds
>   build: enable large file support on 32-bit
>   build: remove unnecessary large file support defines
>   eal: mark unused function in 32-bit builds
>   build: add libatomic dependency for 32-bit clang compile
> 

Hi Bruce, Intel validation team reported failures with some 32-bit
builds with meson on 18.11.3-rc1. I've tested with these patches and it
fixes the problems.

I also took d23e141ffa52 ("build: set RTE_ARCH_64 based on pointer
size"), to avoid rebasing the other patches to check 'void *' size
multiple times.

Any objection to applying for 18.11 branch?

Kevin.

>  drivers/common/dpaax/dpaax_iova_table.c | 4 ++--
>  drivers/event/octeontx/meson.build      | 5 +++++
>  drivers/event/opdl/meson.build          | 5 +++++
>  drivers/net/nfp/meson.build             | 2 +-
>  examples/vhost_crypto/meson.build       | 1 -
>  examples/vhost_scsi/meson.build         | 1 -
>  lib/librte_eal/linux/eal/eal_memalloc.c | 1 -
>  lib/librte_eal/linux/eal/eal_memory.c   | 2 +-
>  lib/librte_rcu/meson.build              | 5 +++++
>  lib/librte_vhost/Makefile               | 2 +-
>  mk/arch/arm/rte.vars.mk                 | 2 +-
>  mk/arch/i686/rte.vars.mk                | 2 +-
>  12 files changed, 22 insertions(+), 10 deletions(-)
>
Bruce Richardson Oct. 3, 2019, 8:28 a.m. UTC | #3
On Wed, Oct 02, 2019 at 04:11:56PM +0100, Kevin Traynor wrote:
> On 28/05/2019 12:07, Bruce Richardson wrote:
> > This set fixes some issues seen on the automated CI system with building
> > on 32-bit Linux distro's using meson and ninja. The fixes are to disable
> > unsupported parts of the build, and switch the 32-bit builds to always
> > having large file support, so that make and meson are consistent in that
> > regard.
> > 
> > V2: add two additional patches to fix clang builds. This allows the
> >     test-meson-builds.sh script to run successfully on 32-bit Ubuntu
> >     16.04 systems.
> > 
> > Bruce Richardson (5):
> >   net/nfp: disable nfp for 32-bit meson builds
> >   build: enable large file support on 32-bit
> >   build: remove unnecessary large file support defines
> >   eal: mark unused function in 32-bit builds
> >   build: add libatomic dependency for 32-bit clang compile
> > 
> 
> Hi Bruce, Intel validation team reported failures with some 32-bit
> builds with meson on 18.11.3-rc1. I've tested with these patches and it
> fixes the problems.
> 
> I also took d23e141ffa52 ("build: set RTE_ARCH_64 based on pointer
> size"), to avoid rebasing the other patches to check 'void *' size
> multiple times.
> 
> Any objection to applying for 18.11 branch?
> 
> Kevin.
> 
Nope, no objections.

Thanks.