mbox series

[v4,0/5] make lcore_config internal

Message ID 1558619942-9723-1-git-send-email-david.marchand@redhat.com (mailing list archive)
Headers
Series make lcore_config internal |

Message

David Marchand May 23, 2019, 1:58 p.m. UTC 
  This set of patches makes the lcore_config structure less visible
as part of the ABI.  This version does not break the ABI (yet)
follow on patch moves lcore_config into eal_private.h

Changelog since v3:
I took the liberty of taking over Stephen series.
I rebased and did some adjustments following [1] cleanups.
As stated before, we will still need a deprecation notice when hiding
lcore_config but this series does not break API nor ABI.

Changelog since v2:
 - new patch to use unsigned int in lcore.h first
 - incorporate feedback from David
 - don't include last patch to make it private
        (to avoid accidental early merge)

1: http://patchwork.dpdk.org/patch/53621/

Comments

Stephen Hemminger May 23, 2019, 3:14 p.m. UTC | #1 
On Thu, 23 May 2019 15:58:56 +0200
David Marchand <david.marchand@redhat.com> wrote:

> This set of patches makes the lcore_config structure less visible
> as part of the ABI.  This version does not break the ABI (yet)
> follow on patch moves lcore_config into eal_private.h
> 
> Changelog since v3:
> I took the liberty of taking over Stephen series.
> I rebased and did some adjustments following [1] cleanups.
> As stated before, we will still need a deprecation notice when hiding
> lcore_config but this series does not break API nor ABI.
> 
> Changelog since v2:
>  - new patch to use unsigned int in lcore.h first
>  - incorporate feedback from David
>  - don't include last patch to make it private
>         (to avoid accidental early merge)
> 
> 1: http://patchwork.dpdk.org/patch/53621/
> 

Thanks for doing this.

We still need the documentation update to indicate deprecation.