From patchwork Thu May 16 11:42:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sunil Kumar Kori X-Patchwork-Id: 53474 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F001C5F33; Thu, 16 May 2019 13:42:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id B3A5A5F2C for ; Thu, 16 May 2019 13:42:18 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4GBUJPV005571 for ; Thu, 16 May 2019 04:42:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0818; bh=/PLHXIKeqAvWwgefCzFTCWEusOOhyGf4NnGLYSPRdEY=; b=HSEq1MFq91zmObHMBkSNo4B7dHgoj89Eym70e3PZ/z48FmRIqNgmK2khxKE9hejlzVjF HLaKjFxjU9xkFuxiiYdxztz4BcvhVdd5MdwUy/UuaJuXxVeLA5qaxUbz8txk4pwHyCFl ogZG9eEUnKCLzU3mhhtw9yflP1jEb5SCGZcV6LvavyGkaXAWFCjVNkfTQcfnSzZO9BH8 yas7vSuWkc0k/ctY1rNW6cCabzRFJ8XFaGH7y+mJkv1csmzwtHdhonjMKr7JW2H1gN+E z/y4qunJBcoAums2XzxfK5CclmdK31SaSh0xegbyPek9+Gyftjn0jYABb7BprXEnd+wM Cg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2sgvc72u7f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 16 May 2019 04:42:17 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 16 May 2019 04:42:16 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 16 May 2019 04:42:16 -0700 Received: from dc7-eodlnx05.marvell.com (dc7-eodlnx05.marvell.com [10.28.113.55]) by maili.marvell.com (Postfix) with ESMTP id 0150E3F7041; Thu, 16 May 2019 04:42:15 -0700 (PDT) From: Sunil Kumar Kori To: CC: Date: Thu, 16 May 2019 17:12:10 +0530 Message-ID: <1558006933-32247-1-git-send-email-skori@marvell.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1558005895-30340-1-git-send-email-skori@marvell.com> References: <1558005895-30340-1-git-send-email-skori@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-16_09:, , signatures=0 Subject: [dpdk-dev] [PATCH v2 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" v2: Checkpath warning are removed Patchset contains below changes: ------------------------------------------------------------ 1. Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during fragmentation and reassemble operation implicitly. Because of this, application is forced to use checksum offload whether it is supported by platform or not. Also documentation does not provide any expected value of ol_flags in returned mbuf (reassembled or fragmented) so application will never come to know that which offloads are enabled. So transmission may gets failed for the platforms which does not support checksum offload. Also, IPv6 does not contain any checksum field in header so setting mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid. So removing mentioned flag from the library. 2. Enabling PKT_TX_IP_CKSUM into mbuf->ol_flags at fragmentation and reassembly application itself. Sunil Kumar Kori (3): lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags examples/ip_fragmentation: Enabling IP checksum offload in mbuf examples/ip_reassembly: Enabling IP checksum offload in mbuf examples/ip_fragmentation/main.c | 7 +++++-- examples/ip_reassembly/main.c | 6 ++++++ lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 - lib/librte_ip_frag/rte_ipv4_reassembly.c | 3 --- lib/librte_ip_frag/rte_ipv6_reassembly.c | 3 --- 5 files changed, 11 insertions(+), 9 deletions(-)