mbox series

[v4,0/3] hash: fix bugs in 'free key with position'

Message ID 20190509171907.14693-1-dharmik.thakkar@arm.com (mailing list archive)
Headers
Series hash: fix bugs in 'free key with position' |

Message

Dharmik Thakkar May 9, 2019, 5:19 p.m. UTC 
  This patch series solves 2 bugs reported on Bugzilla (bug-261) within
the function rte_hash_free_key_with_postion(). It also adds a test case
 to catch similar bugs in the future.

https://bugs.dpdk.org/show_bug.cgi?id=261
---
v4:
 * Fix compilation failure (Yipeng)
v3:
 * Split the patch and update commit logs (Thomas)
v2:
 * Add comments in test_hash.c (Yipeng)
 * Resolve checkpatch warning

Dharmik Thakkar (3):
  hash: fix position bug in 'free key with position'
  hash: fix total entries in free key with position
  test/hash: add test for 'free key with position'

 app/test/test_hash.c              | 94 +++++++++++++++++++++++++++++++
 lib/librte_hash/rte_cuckoo_hash.c | 15 +++--
 2 files changed, 104 insertions(+), 5 deletions(-)

Comments

Thomas Monjalon May 9, 2019, 7:24 p.m. UTC | #1 
09/05/2019 19:19, Dharmik Thakkar:
> This patch series solves 2 bugs reported on Bugzilla (bug-261) within
> the function rte_hash_free_key_with_postion(). It also adds a test case
>  to catch similar bugs in the future.
> 
> https://bugs.dpdk.org/show_bug.cgi?id=261

Yipeng, Sameh, should it enter in 19.05-rc4?
Are you sure it does not break things more?
If yes, please give your ack.
Wang, Yipeng1 May 9, 2019, 7:36 p.m. UTC | #2 
>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas@monjalon.net]
>Sent: Thursday, May 9, 2019 12:24 PM
>To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>
>Cc: dev@dpdk.org; Dharmik Thakkar <dharmik.thakkar@arm.com>; honnappa.nagarahalli@arm.com; zhongdahulinfan@163.com
>Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position'
>
>09/05/2019 19:19, Dharmik Thakkar:
>> This patch series solves 2 bugs reported on Bugzilla (bug-261) within
>> the function rte_hash_free_key_with_postion(). It also adds a test case
>>  to catch similar bugs in the future.
>>
>> https://bugs.dpdk.org/show_bug.cgi?id=261
>
>Yipeng, Sameh, should it enter in 19.05-rc4?
>Are you sure it does not break things more?
>If yes, please give your ack.
[Wang, Yipeng] 
Please go ahead Thomas, I reviewed the code and it will not break other things. The
changes are refrained inside an experimental API function.

I haven't done the meson build test though.
Thomas Monjalon May 9, 2019, 8:36 p.m. UTC | #3 
09/05/2019 21:36, Wang, Yipeng1:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >09/05/2019 19:19, Dharmik Thakkar:
> >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within
> >> the function rte_hash_free_key_with_postion(). It also adds a test case
> >>  to catch similar bugs in the future.
> >>
> >> https://bugs.dpdk.org/show_bug.cgi?id=261
> >
> >Yipeng, Sameh, should it enter in 19.05-rc4?
> >Are you sure it does not break things more?
> >If yes, please give your ack.
> [Wang, Yipeng] 
> Please go ahead Thomas, I reviewed the code and it will not break other things. The
> changes are refrained inside an experimental API function.
> 
> I haven't done the meson build test though.

Applied, thanks