Message ID | 20190504092939.25326-1-qi.z.zhang@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6406628FD; Sat, 4 May 2019 11:27:37 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DBCB41041 for <dev@dpdk.org>; Sat, 4 May 2019 11:27:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 02:27:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,429,1549958400"; d="scan'208";a="229226655" Received: from dpdk51.sh.intel.com ([10.67.110.245]) by orsmga001.jf.intel.com with ESMTP; 04 May 2019 02:27:32 -0700 From: Qi Zhang <qi.z.zhang@intel.com> To: beilei.xing@intel.com, wenzhuo.lu@intel.com, qiming.yang@intel.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com> Date: Sat, 4 May 2019 17:29:36 +0800 Message-Id: <20190504092939.25326-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
fix invalid Tx threshhold setup
|
|
Message
Qi Zhang
May 4, 2019, 9:29 a.m. UTC
When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an outdated DD status be checked as tx_next_dd, then segment fault happen due to free a NULL mbuf pointer. The issue usually happens with an aggresive tx_free_thresh, for example: ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd=1024 --txd=1024 --txfreet=1020 The patchset fix this issue on i40e, ixgbe and ice. Qi Zhang (3): net/i40e: fix invalid Tx threshold setup net/ice: fix invalid Tx threshold setup net/ixgbe: fix invalid Tx threshold setup drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++-- drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++--- drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++-- 3 files changed, 52 insertions(+), 7 deletions(-)
Comments
> -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 4, 2019 5:30 PM > To: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Ananyev, > Konstantin <konstantin.ananyev@intel.com> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: [PATCH 0/3] fix invalid Tx threshhold setup > > When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an > outdated DD status be checked as tx_next_dd, then segment fault happen > due to free a NULL mbuf pointer. > > The issue usually happens with an aggresive tx_free_thresh, for example: > > ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd=1024 --txd=1024 -- > txfreet=1020 > > The patchset fix this issue on i40e, ixgbe and ice. > > Qi Zhang (3): > net/i40e: fix invalid Tx threshold setup > net/ice: fix invalid Tx threshold setup > net/ixgbe: fix invalid Tx threshold setup > > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++-- > drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++--- > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++-- > 3 files changed, 52 insertions(+), 7 deletions(-) > > -- > 2.13.6 Acked-by: Beilei Xing <beilei.xing@intel.com>
> -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, May 15, 2019 2:36 PM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Ananyev, > Konstantin <konstantin.ananyev@intel.com> > Cc: dev@dpdk.org > Subject: RE: [PATCH 0/3] fix invalid Tx threshhold setup > > > > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Saturday, May 4, 2019 5:30 PM > > To: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo > > <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Ananyev, > > Konstantin <konstantin.ananyev@intel.com> > > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com> > > Subject: [PATCH 0/3] fix invalid Tx threshhold setup > > > > When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an > > outdated DD status be checked as tx_next_dd, then segment fault happen > > due to free a NULL mbuf pointer. > > > > The issue usually happens with an aggresive tx_free_thresh, for example: > > > > ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd=1024 --txd=1024 -- > > txfreet=1020 > > > > The patchset fix this issue on i40e, ixgbe and ice. > > > > Qi Zhang (3): > > net/i40e: fix invalid Tx threshold setup > > net/ice: fix invalid Tx threshold setup > > net/ixgbe: fix invalid Tx threshold setup > > > > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++-- > > drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++--- > > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++-- > > 3 files changed, 52 insertions(+), 7 deletions(-) > > > > -- > > 2.13.6 > > Acked-by: Beilei Xing <beilei.xing@intel.com> Applied to dpdk-next-net-intel. Thanks Qi