[00/11] Aquantia atlantic bugfixes
mbox series

Message ID cover.1556525874.git.igor.russkikh@aquantia.com
Headers show
Series
  • Aquantia atlantic bugfixes
Related show

Message

Igor Russkikh April 29, 2019, 8:20 a.m. UTC
This patchset contains various bugfixes found during verification
and integration testing.

Most notable is eeprom access cleanup, fix for broadcast filter,
flow control logic tracking, some code style cleanups.

Igor Russkikh (7):
  net/atlantic: enable broadcast traffic
  net/atlantic: extra line at eof
  net/atlantic: bad indentation
  net/atlantic: fix max eeprom size
  net/atlantic: validity check for eeprom dev address
  net/atlantic: typo on args check
  net/atlantic: extra err check

Pavel Belous (4):
  net/atlantic: eeprom get/set should consider offset
  net/atlantic: bad logic with offsets talking with firmware
  net/atlantic: flow control settings synchronization on rx
  net/atlantic: use capability bits to detect eeprom access

 drivers/net/atlantic/atl_ethdev.c             |  43 +++++--
 drivers/net/atlantic/atl_rxtx.c               |   1 -
 drivers/net/atlantic/atl_types.h              |   3 +-
 drivers/net/atlantic/hw_atl/hw_atl_b0.c       |   8 ++
 drivers/net/atlantic/hw_atl/hw_atl_b0.h       |   2 +
 drivers/net/atlantic/hw_atl/hw_atl_utils.c    |  17 +--
 drivers/net/atlantic/hw_atl/hw_atl_utils.h    |  11 +-
 .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c   | 111 ++++++++++++------
 8 files changed, 128 insertions(+), 68 deletions(-)

Comments

Kevin Traynor May 8, 2019, 4:05 p.m. UTC | #1
On 29/04/2019 09:20, Igor Russkikh wrote:
> This patchset contains various bugfixes found during verification
> and integration testing.
> 
> Most notable is eeprom access cleanup, fix for broadcast filter,
> flow control logic tracking, some code style cleanups.
> 
> Igor Russkikh (7):
>   net/atlantic: enable broadcast traffic
>   net/atlantic: extra line at eof
>   net/atlantic: bad indentation
>   net/atlantic: fix max eeprom size
>   net/atlantic: validity check for eeprom dev address
>   net/atlantic: typo on args check
>   net/atlantic: extra err check
> 
> Pavel Belous (4):
>   net/atlantic: eeprom get/set should consider offset
>   net/atlantic: bad logic with offsets talking with firmware
>   net/atlantic: flow control settings synchronization on rx
>   net/atlantic: use capability bits to detect eeprom access
> 
>  drivers/net/atlantic/atl_ethdev.c             |  43 +++++--
>  drivers/net/atlantic/atl_rxtx.c               |   1 -
>  drivers/net/atlantic/atl_types.h              |   3 +-
>  drivers/net/atlantic/hw_atl/hw_atl_b0.c       |   8 ++
>  drivers/net/atlantic/hw_atl/hw_atl_b0.h       |   2 +
>  drivers/net/atlantic/hw_atl/hw_atl_utils.c    |  17 +--
>  drivers/net/atlantic/hw_atl/hw_atl_utils.h    |  11 +-
>  .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c   | 111 ++++++++++++------
>  8 files changed, 128 insertions(+), 68 deletions(-)
> 

Hi - some of these that are fixes will apply on 18.11 stable branch with
a little of rebasing, some will not. It will be cleaner to take the
fixes as a series. Can you send backports for the series for the 18.11
branch, or let me know if they are not needed.

thanks,
Kevin.
Igor Russkikh May 13, 2019, 7:59 a.m. UTC | #2
> 
> Hi - some of these that are fixes will apply on 18.11 stable branch with
> a little of rebasing, some will not. It will be cleaner to take the
> fixes as a series. Can you send backports for the series for the 18.11
> branch, or let me know if they are not needed.

Hi Kevin, I'll backport these to 18.11 and resubmit it soon.

Thanks,
  Igor