[v5,0/3] add actions to modify header fields

Message ID cover.1555926274.git.dekelp@mellanox.com
Headers show
Series
  • add actions to modify header fields
Related show

Message

Dekel Peled April 22, 2019, 11:22 a.m.
Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2].
This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD.

Original work by Xiaoyu Min.

[1] http://patches.dpdk.org/patch/49310/
[2] http://mails.dpdk.org/archives/dev/2018-August/109672.html

---
v2: apply code review comments.
v3: apply additional code review comments.
    - Update documentation of new commands.
    - Use common general struct for all commands.
v4: apply checkpatch comments.
v5: apply additional code review comments.
    - Add 8, 16, 32 bit types to union.
    - Update struct name and documentation.
---

Dekel Peled (3):
  ethdev: add actions to modify TCP header fields
  app/testpmd: add actions to modify TCP header fields
  net/mlx5: update modify header using Direct Verbs

 app/test-pmd/cmdline_flow.c                 | 100 ++++++++++++
 doc/guides/prog_guide/rte_flow.rst          |  68 ++++++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  16 ++
 drivers/net/mlx5/mlx5_flow.h                |  10 +-
 drivers/net/mlx5/mlx5_flow_dv.c             | 239 ++++++++++++++++++++++++++++
 drivers/net/mlx5/mlx5_prm.h                 |  12 ++
 lib/librte_ethdev/rte_flow.c                |   4 +
 lib/librte_ethdev/rte_flow.h                |  61 +++++++
 8 files changed, 509 insertions(+), 1 deletion(-)

Comments

Dekel Peled June 2, 2019, 8:18 a.m. | #1
Hi, 

Please review/comment on v5 of this series so it can be accepted.
http://patches.dpdk.org/cover/52974/

Regards,
Dekel

> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Monday, April 22, 2019 2:23 PM
> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>;
> Shahaf Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com
> Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Dekel Peled
> <dekelp@mellanox.com>
> Subject: [PATCH v5 0/3] add actions to modify header fields
> 
> Patch [1] implemented set of header modification actions in MLX PMD,
> based on ethdev and testpmd updates included in [2].
> This series implements support of additional header modification actions, in
> ethdev, testpmd, and MLX5 PMD.
> 
> Original work by Xiaoyu Min.
> 
> [1] http://patches.dpdk.org/patch/49310/
> [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html
> 
> ---
> v2: apply code review comments.
> v3: apply additional code review comments.
>     - Update documentation of new commands.
>     - Use common general struct for all commands.
> v4: apply checkpatch comments.
> v5: apply additional code review comments.
>     - Add 8, 16, 32 bit types to union.
>     - Update struct name and documentation.
> ---
> 
> Dekel Peled (3):
>   ethdev: add actions to modify TCP header fields
>   app/testpmd: add actions to modify TCP header fields
>   net/mlx5: update modify header using Direct Verbs
> 
>  app/test-pmd/cmdline_flow.c                 | 100 ++++++++++++
>  doc/guides/prog_guide/rte_flow.rst          |  68 ++++++++
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  16 ++
>  drivers/net/mlx5/mlx5_flow.h                |  10 +-
>  drivers/net/mlx5/mlx5_flow_dv.c             | 239
> ++++++++++++++++++++++++++++
>  drivers/net/mlx5/mlx5_prm.h                 |  12 ++
>  lib/librte_ethdev/rte_flow.c                |   4 +
>  lib/librte_ethdev/rte_flow.h                |  61 +++++++
>  8 files changed, 509 insertions(+), 1 deletion(-)
> 
> --
> 1.8.3.1
Dekel Peled June 4, 2019, 5:13 a.m. | #2
Hi Adrien,

I understand that you might have some reservations about patch http://patches.dpdk.org/patch/52975/.
I'm preparing v6, with update documentation according to comments from Thomas.
In v5 I modified the struct rte_flow_integer_action, according to your comments in previous versions.
Please reply with any additional comments so I can push this series forward.

Regards,
Dekel

> -----Original Message-----
> From: Dekel Peled
> Sent: Sunday, June 2, 2019 11:18 AM
> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>;
> Shahaf Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>
> Subject: RE: [PATCH v5 0/3] add actions to modify header fields
> 
> Hi,
> 
> Please review/comment on v5 of this series so it can be accepted.
> http://patches.dpdk.org/cover/52974/
> 
> Regards,
> Dekel
> 
> > -----Original Message-----
> > From: Dekel Peled <dekelp@mellanox.com>
> > Sent: Monday, April 22, 2019 2:23 PM
> > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> > wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>;
> Shahaf
> > Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com
> > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Dekel Peled
> > <dekelp@mellanox.com>
> > Subject: [PATCH v5 0/3] add actions to modify header fields
> >
> > Patch [1] implemented set of header modification actions in MLX PMD,
> > based on ethdev and testpmd updates included in [2].
> > This series implements support of additional header modification
> > actions, in ethdev, testpmd, and MLX5 PMD.
> >
> > Original work by Xiaoyu Min.
> >
> > [1] http://patches.dpdk.org/patch/49310/
> > [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html
> >
> > ---
> > v2: apply code review comments.
> > v3: apply additional code review comments.
> >     - Update documentation of new commands.
> >     - Use common general struct for all commands.
> > v4: apply checkpatch comments.
> > v5: apply additional code review comments.
> >     - Add 8, 16, 32 bit types to union.
> >     - Update struct name and documentation.
> > ---
> >
> > Dekel Peled (3):
> >   ethdev: add actions to modify TCP header fields
> >   app/testpmd: add actions to modify TCP header fields
> >   net/mlx5: update modify header using Direct Verbs
> >
> >  app/test-pmd/cmdline_flow.c                 | 100 ++++++++++++
> >  doc/guides/prog_guide/rte_flow.rst          |  68 ++++++++
> >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  16 ++
> >  drivers/net/mlx5/mlx5_flow.h                |  10 +-
> >  drivers/net/mlx5/mlx5_flow_dv.c             | 239
> > ++++++++++++++++++++++++++++
> >  drivers/net/mlx5/mlx5_prm.h                 |  12 ++
> >  lib/librte_ethdev/rte_flow.c                |   4 +
> >  lib/librte_ethdev/rte_flow.h                |  61 +++++++
> >  8 files changed, 509 insertions(+), 1 deletion(-)
> >
> > --
> > 1.8.3.1
Dekel Peled June 4, 2019, 8:14 a.m. | #3
Hi Adrien (again ;-)

To clarify, I'm working on v6 but will not send it yet.
I'm waiting for your comments on v5, and will send v6 only after getting all comments.

Regards,
Dekel


> -----Original Message-----
> From: Dekel Peled
> Sent: Tuesday, June 4, 2019 8:13 AM
> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Thomas Monjalon
> <thomasm@mellanox.com>
> Subject: RE: [PATCH v5 0/3] add actions to modify header fields
> 
> Hi Adrien,
> 
> I understand that you might have some reservations about patch
> http://patches.dpdk.org/patch/52975/.
> I'm preparing v6, with update documentation according to comments from
> Thomas.
> In v5 I modified the struct rte_flow_integer_action, according to your
> comments in previous versions.
> Please reply with any additional comments so I can push this series forward.
> 
> Regards,
> Dekel
> 
> > -----Original Message-----
> > From: Dekel Peled
> > Sent: Sunday, June 2, 2019 11:18 AM
> > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> > wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>;
> Shahaf
> > Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com; Yigit,
> > Ferruh <ferruh.yigit@intel.com>
> > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>
> > Subject: RE: [PATCH v5 0/3] add actions to modify header fields
> >
> > Hi,
> >
> > Please review/comment on v5 of this series so it can be accepted.
> > http://patches.dpdk.org/cover/52974/
> >
> > Regards,
> > Dekel
> >
> > > -----Original Message-----
> > > From: Dekel Peled <dekelp@mellanox.com>
> > > Sent: Monday, April 22, 2019 2:23 PM
> > > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> > > wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> > > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>;
> > Shahaf
> > > Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com
> > > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Dekel Peled
> > > <dekelp@mellanox.com>
> > > Subject: [PATCH v5 0/3] add actions to modify header fields
> > >
> > > Patch [1] implemented set of header modification actions in MLX PMD,
> > > based on ethdev and testpmd updates included in [2].
> > > This series implements support of additional header modification
> > > actions, in ethdev, testpmd, and MLX5 PMD.
> > >
> > > Original work by Xiaoyu Min.
> > >
> > > [1] http://patches.dpdk.org/patch/49310/
> > > [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html
> > >
> > > ---
> > > v2: apply code review comments.
> > > v3: apply additional code review comments.
> > >     - Update documentation of new commands.
> > >     - Use common general struct for all commands.
> > > v4: apply checkpatch comments.
> > > v5: apply additional code review comments.
> > >     - Add 8, 16, 32 bit types to union.
> > >     - Update struct name and documentation.
> > > ---
> > >
> > > Dekel Peled (3):
> > >   ethdev: add actions to modify TCP header fields
> > >   app/testpmd: add actions to modify TCP header fields
> > >   net/mlx5: update modify header using Direct Verbs
> > >
> > >  app/test-pmd/cmdline_flow.c                 | 100 ++++++++++++
> > >  doc/guides/prog_guide/rte_flow.rst          |  68 ++++++++
> > >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  16 ++
> > >  drivers/net/mlx5/mlx5_flow.h                |  10 +-
> > >  drivers/net/mlx5/mlx5_flow_dv.c             | 239
> > > ++++++++++++++++++++++++++++
> > >  drivers/net/mlx5/mlx5_prm.h                 |  12 ++
> > >  lib/librte_ethdev/rte_flow.c                |   4 +
> > >  lib/librte_ethdev/rte_flow.h                |  61 +++++++
> > >  8 files changed, 509 insertions(+), 1 deletion(-)
> > >
> > > --
> > > 1.8.3.1