[v2,0/2] ice: fix wrong type and promisc mode
mbox series

Message ID 1555465672-288172-1-git-send-email-ying.a.wang@intel.com
Headers show
Series
  • ice: fix wrong type and promisc mode
Related show

Message

Ying Wang April 17, 2019, 1:47 a.m. UTC
Patch 1/2 modifies the variable type of "status" from "uint16_t" to "enum ice_status ".
Patch 2/2 adds a return value check to give user a correct prompt.

V2:
* For patch 1/2, change "int" to "enum ice_status"; fix some typo of the commit message
  and rename the patch title. For patch 2/2, make the commit log concise and clear.

Wang Ying A (2):
  net/ice: fix wrong type
  net/ice: fix promiscuous mode

 drivers/net/ice/ice_ethdev.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
			  
--
1.8.3.1

Comments

Yang, Qiming April 17, 2019, 3:09 a.m. UTC | #1
> -----Original Message-----
> From: Wang, Ying A
> Sent: Wednesday, April 17, 2019 9:48 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; ramirose@gmail.com; Wang, Ying A
> <ying.a.wang@intel.com>
> Subject: [PATCH v2 0/2] ice: fix wrong type and promisc mode
> 
> Patch 1/2 modifies the variable type of "status" from "uint16_t" to "enum
> ice_status ".
> Patch 2/2 adds a return value check to give user a correct prompt.
> 
> V2:
> * For patch 1/2, change "int" to "enum ice_status"; fix some typo of the
> commit message
>   and rename the patch title. For patch 2/2, make the commit log concise and
> clear.
> 
> Wang Ying A (2):
>   net/ice: fix wrong type
>   net/ice: fix promiscuous mode
> 
>  drivers/net/ice/ice_ethdev.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> --
> 1.8.3.1

Acked-by: Qiming Yang <qiming.yang@intel.com>
Zhang, Qi Z April 17, 2019, 3:46 a.m. UTC | #2
> -----Original Message-----
> From: Yang, Qiming
> Sent: Wednesday, April 17, 2019 11:10 AM
> To: Wang, Ying A <ying.a.wang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; ramirose@gmail.com
> Subject: RE: [PATCH v2 0/2] ice: fix wrong type and promisc mode
> 
> 
> 
> > -----Original Message-----
> > From: Wang, Ying A
> > Sent: Wednesday, April 17, 2019 9:48 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; ramirose@gmail.com; Wang, Ying A
> > <ying.a.wang@intel.com>
> > Subject: [PATCH v2 0/2] ice: fix wrong type and promisc mode
> >
> > Patch 1/2 modifies the variable type of "status" from "uint16_t" to
> > "enum ice_status ".
> > Patch 2/2 adds a return value check to give user a correct prompt.
> >
> > V2:
> > * For patch 1/2, change "int" to "enum ice_status"; fix some typo of
> > the commit message
> >   and rename the patch title. For patch 2/2, make the commit log
> > concise and clear.
> >
> > Wang Ying A (2):
> >   net/ice: fix wrong type
> >   net/ice: fix promiscuous mode
> >
> >  drivers/net/ice/ice_ethdev.c | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> >
> > --
> > 1.8.3.1
> 
> Acked-by: Qiming Yang <qiming.yang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi