[0/6] build: fix build for arm64
mbox series

Message ID 20190412232451.30197-1-yskoh@mellanox.com
Headers show
Series
  • build: fix build for arm64
Related show

Message

Yongseok Koh April 12, 2019, 11:24 p.m. UTC
This patchset depends on
"meson: add infra to support machine specific flags" [1]

[1] http://patches.dpdk.org/patch/52606/

Yongseok Koh (6):
  meson: disable octeontx for buggy compilers on arm64
  meson: change default cache line size for cortex-a72
  net/mlx: fix library search in meson build
  meson: add Mellanox BlueField cross-compile config
  build: add option for armv8 crypto extension
  mk: disable armv8 crypto extension for Mellanox BlueField

 config/arm/arm64_bluefield_linux_gcc          | 16 ++++++++++++++++
 config/arm/meson.build                        | 18 +++++++++++-------
 config/common_armv8a_linux                    |  1 +
 config/defconfig_arm64-bluefield-linuxapp-gcc |  6 ++++++
 drivers/crypto/armv8/Makefile                 |  4 ++++
 drivers/event/meson.build                     |  6 +++++-
 drivers/net/mlx4/meson.build                  | 19 +++++++++++--------
 drivers/net/mlx5/meson.build                  | 19 +++++++++++--------
 meson_options.txt                             |  2 ++
 mk/machine/armv8a/rte.vars.mk                 |  4 ++++
 10 files changed, 71 insertions(+), 24 deletions(-)
 create mode 100644 config/arm/arm64_bluefield_linux_gcc

Comments

Jerin Jacob Kollanukkaran April 13, 2019, 7:12 a.m. UTC | #1
Other than 1/1, I don't think, this patches series fixing any build for arm64.
It is adding features required for Mellanox BlueField support.
Please change subject to more appropriate name.


> -----Original Message-----
> From: Yongseok Koh <yskoh@mellanox.com>
> Sent: Saturday, April 13, 2019 4:55 AM
> To: bruce.richardson@intel.com; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; shahafs@mellanox.com
> Cc: dev@dpdk.org; thomas@monjalon.net; gavin.hu@arm.com;
> Honnappa.Nagarahalli@arm.com
> Subject: [EXT] [PATCH 0/6] build: fix build for arm64
> 
> External Email
> 
> ----------------------------------------------------------------------
> This patchset depends on
> "meson: add infra to support machine specific flags" [1]
> 
> [1] http://patches.dpdk.org/patch/52606/
> 
> Yongseok Koh (6):
>   meson: disable octeontx for buggy compilers on arm64
>   meson: change default cache line size for cortex-a72
>   net/mlx: fix library search in meson build
>   meson: add Mellanox BlueField cross-compile config
>   build: add option for armv8 crypto extension
>   mk: disable armv8 crypto extension for Mellanox BlueField
> 
>  config/arm/arm64_bluefield_linux_gcc          | 16 ++++++++++++++++
>  config/arm/meson.build                        | 18 +++++++++++-------
>  config/common_armv8a_linux                    |  1 +
>  config/defconfig_arm64-bluefield-linuxapp-gcc |  6 ++++++
>  drivers/crypto/armv8/Makefile                 |  4 ++++
>  drivers/event/meson.build                     |  6 +++++-
>  drivers/net/mlx4/meson.build                  | 19 +++++++++++--------
>  drivers/net/mlx5/meson.build                  | 19 +++++++++++--------
>  meson_options.txt                             |  2 ++
>  mk/machine/armv8a/rte.vars.mk                 |  4 ++++
>  10 files changed, 71 insertions(+), 24 deletions(-)  create mode 100644
> config/arm/arm64_bluefield_linux_gcc
> 
> --
> 2.21.0.196.g041f5ea
Yongseok Koh April 15, 2019, 8:56 p.m. UTC | #2
> On Apr 13, 2019, at 12:12 AM, Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote:
> 
> Other than 1/1, I don't think, this patches series fixing any build for arm64.

That's one of reasons for the title.

> It is adding features required for Mellanox BlueField support.

Hard to agree.

> Please change subject to more appropriate name.

If the title of the cover letter (which isn't merged anyway but informative)
still bothers you, let me know. I'd rather remove the cover letter like your
patchset.

>> -----Original Message-----
>> From: Yongseok Koh <yskoh@mellanox.com>
>> Sent: Saturday, April 13, 2019 4:55 AM
>> To: bruce.richardson@intel.com; Jerin Jacob Kollanukkaran
>> <jerinj@marvell.com>; Pavan Nikhilesh Bhagavatula
>> <pbhagavatula@marvell.com>; shahafs@mellanox.com
>> Cc: dev@dpdk.org; thomas@monjalon.net; gavin.hu@arm.com;
>> Honnappa.Nagarahalli@arm.com
>> Subject: [EXT] [PATCH 0/6] build: fix build for arm64
>> 
>> External Email
>> 
>> ----------------------------------------------------------------------
>> This patchset depends on
>> "meson: add infra to support machine specific flags" [1]
>> 
>> [1] https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatches.dpdk.org%2Fpatch%2F52606%2F&amp;data=02%7C01%7Cyskoh%40mellanox.com%7C0c76f968187240046bfd08d6bfdf7283%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636907363757515638&amp;sdata=X3fQ%2B%2B7RIs8MbTy%2Bok5WVm6wSmslrcyRuIuECAVhxXA%3D&amp;reserved=0
>> 
>> Yongseok Koh (6):
>>  meson: disable octeontx for buggy compilers on arm64
>>  meson: change default cache line size for cortex-a72
>>  net/mlx: fix library search in meson build
>>  meson: add Mellanox BlueField cross-compile config
>>  build: add option for armv8 crypto extension
>>  mk: disable armv8 crypto extension for Mellanox BlueField
>> 
>> config/arm/arm64_bluefield_linux_gcc          | 16 ++++++++++++++++
>> config/arm/meson.build                        | 18 +++++++++++-------
>> config/common_armv8a_linux                    |  1 +
>> config/defconfig_arm64-bluefield-linuxapp-gcc |  6 ++++++
>> drivers/crypto/armv8/Makefile                 |  4 ++++
>> drivers/event/meson.build                     |  6 +++++-
>> drivers/net/mlx4/meson.build                  | 19 +++++++++++--------
>> drivers/net/mlx5/meson.build                  | 19 +++++++++++--------
>> meson_options.txt                             |  2 ++
>> mk/machine/armv8a/rte.vars.mk                 |  4 ++++
>> 10 files changed, 71 insertions(+), 24 deletions(-)  create mode 100644
>> config/arm/arm64_bluefield_linux_gcc
>> 
>> --
>> 2.21.0.196.g041f5ea
>
Jerin Jacob Kollanukkaran April 16, 2019, 5:57 a.m. UTC | #3
> -----Original Message-----
> From: Yongseok Koh <yskoh@mellanox.com>
> Sent: Tuesday, April 16, 2019 2:26 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: bruce.richardson@intel.com; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Shahaf Shuler <shahafs@mellanox.com>;
> dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>;
> gavin.hu@arm.com; Honnappa.Nagarahalli@arm.com
> Subject: Re: [EXT] [PATCH 0/6] build: fix build for arm64
> 
> 
> > On Apr 13, 2019, at 12:12 AM, Jerin Jacob Kollanukkaran
> <jerinj@marvell.com> wrote:
> >
> > Other than 1/1, I don't think, this patches series fixing any build for arm64.
> 
> That's one of reasons for the title.
> 
> > It is adding features required for Mellanox BlueField support.
> 
> Hard to agree.

The data should say:
meson: disable octeontx for buggy compilers on arm64
meson: change default cache line size for cortex-a72
net/mlx: fix library search in meson build
meson: add Mellanox BlueField cross-compile config
build: add option for armv8 crypto extension
mk: disable armv8 crypto extension for Mellanox BlueField

> 
> > Please change subject to more appropriate name.
> 
> If the title of the cover letter (which isn't merged anyway but informative) still
> bothers you, let me know. I'd rather remove the cover letter like your patchset.

If those are fixes then it needs to back ported to stable tree.
What bothers to me as maintainer that it painting a different picture that
arm64 still has build issues for meson. It is not the case.
So it its good to say what the actual content is, Let me ask you way around,
If it is just informational not going to merged then why to change to something
more appropriate.

I don't have any strong opinion keep the cover letter or not? You can decide.




> 
> >> -----Original Message-----
> >> From: Yongseok Koh <yskoh@mellanox.com>
> >> Sent: Saturday, April 13, 2019 4:55 AM
> >> To: bruce.richardson@intel.com; Jerin Jacob Kollanukkaran
> >> <jerinj@marvell.com>; Pavan Nikhilesh Bhagavatula
> >> <pbhagavatula@marvell.com>; shahafs@mellanox.com
> >> Cc: dev@dpdk.org; thomas@monjalon.net; gavin.hu@arm.com;
> >> Honnappa.Nagarahalli@arm.com
> >> Subject: [EXT] [PATCH 0/6] build: fix build for arm64
> >>
> >> External Email
> >>
> >> ---------------------------------------------------------------------
> >> -
> >> This patchset depends on
> >> "meson: add infra to support machine specific flags" [1]
> >>
> >> [1]
> >> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >>
> hes.dpdk.org%2Fpatch%2F52606%2F&amp;data=02%7C01%7Cyskoh%40mellan
> ox.c
> >>
> om%7C0c76f968187240046bfd08d6bfdf7283%7Ca652971c7d2e4d9ba6a4d1492
> 56f4
> >>
> 61b%7C0%7C0%7C636907363757515638&amp;sdata=X3fQ%2B%2B7RIs8MbTy
> %2Bok5W
> >> Vm6wSmslrcyRuIuECAVhxXA%3D&amp;reserved=0
> >>
> >> Yongseok Koh (6):
> >>  meson: disable octeontx for buggy compilers on arm64
> >>  meson: change default cache line size for cortex-a72
> >>  net/mlx: fix library search in meson build
> >>  meson: add Mellanox BlueField cross-compile config
> >>  build: add option for armv8 crypto extension
> >>  mk: disable armv8 crypto extension for Mellanox BlueField
> >>
> >> config/arm/arm64_bluefield_linux_gcc          | 16 ++++++++++++++++
> >> config/arm/meson.build                        | 18 +++++++++++-------
> >> config/common_armv8a_linux                    |  1 +
> >> config/defconfig_arm64-bluefield-linuxapp-gcc |  6 ++++++
> >> drivers/crypto/armv8/Makefile                 |  4 ++++
> >> drivers/event/meson.build                     |  6 +++++-
> >> drivers/net/mlx4/meson.build                  | 19 +++++++++++--------
> >> drivers/net/mlx5/meson.build                  | 19 +++++++++++--------
> >> meson_options.txt                             |  2 ++
> >> mk/machine/armv8a/rte.vars.mk                 |  4 ++++
> >> 10 files changed, 71 insertions(+), 24 deletions(-)  create mode
> >> 100644 config/arm/arm64_bluefield_linux_gcc
> >>
> >> --
> >> 2.21.0.196.g041f5ea
> >
Thomas Monjalon April 17, 2019, 8:06 p.m. UTC | #4
13/04/2019 01:24, Yongseok Koh:
> This patchset depends on
> "meson: add infra to support machine specific flags" [1]
> 
> [1] http://patches.dpdk.org/patch/52606/
> 
> Yongseok Koh (6):
>   meson: disable octeontx for buggy compilers on arm64
>   meson: change default cache line size for cortex-a72
>   net/mlx: fix library search in meson build
>   meson: add Mellanox BlueField cross-compile config
>   build: add option for armv8 crypto extension
>   mk: disable armv8 crypto extension for Mellanox BlueField

There are some discussions about the crypto config (last 2 patches).
I think we should proceed with patches 1 to 4 in a v2,
so we can progress and discuss about the crypto option later.
Honnappa Nagarahalli April 17, 2019, 8:24 p.m. UTC | #5
> 
> 13/04/2019 01:24, Yongseok Koh:
> > This patchset depends on
> > "meson: add infra to support machine specific flags" [1]
> >
> > [1] http://patches.dpdk.org/patch/52606/
> >
> > Yongseok Koh (6):
> >   meson: disable octeontx for buggy compilers on arm64
> >   meson: change default cache line size for cortex-a72
> >   net/mlx: fix library search in meson build
> >   meson: add Mellanox BlueField cross-compile config
> >   build: add option for armv8 crypto extension
> >   mk: disable armv8 crypto extension for Mellanox BlueField
> 
> There are some discussions about the crypto config (last 2 patches).
> I think we should proceed with patches 1 to 4 in a v2, so we can progress and
> discuss about the crypto option later.
Many compiler folks are on holiday (due to extended holiday weekend 4/19, 4/22), I do not have an answer on the crypto question yet

>
Yongseok Koh April 17, 2019, 10:14 p.m. UTC | #6
> On Apr 17, 2019, at 1:06 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> 13/04/2019 01:24, Yongseok Koh:
>> This patchset depends on
>> "meson: add infra to support machine specific flags" [1]
>> 
>> [1] https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatches.dpdk.org%2Fpatch%2F52606%2F&amp;data=02%7C01%7Cyskoh%40mellanox.com%7C9827d8bf7195452905f908d6c37030f4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636911283960800945&amp;sdata=bwiJRKspk%2FACPpJlqtLRamW7ybjkjIafbkMST6pTC9A%3D&amp;reserved=0
>> 
>> Yongseok Koh (6):
>>  meson: disable octeontx for buggy compilers on arm64
>>  meson: change default cache line size for cortex-a72
>>  net/mlx: fix library search in meson build
>>  meson: add Mellanox BlueField cross-compile config
>>  build: add option for armv8 crypto extension
>>  mk: disable armv8 crypto extension for Mellanox BlueField
> 
> There are some discussions about the crypto config (last 2 patches).
> I think we should proceed with patches 1 to 4 in a v2,
> so we can progress and discuss about the crypto option later.

Will do v2 with 4 patches.

Yongseok