[v2,0/2] fix big endian build
mbox series

Message ID 20190409200636.2193-1-thomas@monjalon.net
Headers show
  • fix big endian build
Related show


Thomas Monjalon April 9, 2019, 8:06 p.m. UTC
There are at least 4 issues when compiling with a big endian toolchain.
2 of them are fixed in this patchset.
The remaining ones are in ice and bnxt PMDs.

About ice, the error is:
    drivers/net/ice/base/ice_flex_pipe.c:302:8: error:
    ‘state.entry_idx’ may be used uninitialized in this function
It is not obvious to fix, there may be few places where
a struct should be initialized. Please fix it soon.

About bnxt, the issue looks like a mistake reproduced several times:
    drivers/net/bnxt/bnxt_ethdev.c:2652:19: error:
    invalid use of void expression
    rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off));
The pattern "rte_cpu_to_le_32(rte_write32(" can be seen 4 times.
The result of the endian conversion is never used.
Please fix it soon.

Thomas Monjalon (2):
  mbuf: fix big endian build
  net/enetc: fix big endian build

v2 for checkpatch

 drivers/net/enetc/enetc_rxtx.c | 5 +++--
 lib/librte_mbuf/rte_mbuf.h     | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)