[0/3] librte_acl: fixes related to testing with the meson build
mbox series

Message ID 20190408182420.4398-1-aconole@redhat.com
Headers show
Series
  • librte_acl: fixes related to testing with the meson build
Related show

Message

Aaron Conole April 8, 2019, 6:24 p.m. UTC
This series fixes the following conditions in the RTE_ACL library:

  1. Fix outstanding compilation issues on ARM with the NEON optimized code
     These consisted mostly of compiler type-cast warnings.  Additionally, some
     of the vector code didn't initialize memory properly.

  2. Properly include ARM, and PPC objects when building on those platforms
     During the meson port, only the scalar code, and some of the x86_64 code was
     ported.

  3. Allow the unit tests to pass
     In order to support this, the unsupported symbols were moved to a separate
     file, which was needed to prevent the compiler from inlining references to the
     functions (resulting in non-scalar code always falling into the -ENOTSUP case).

     The tests were modified to primarily test the scalar version - a better system
     for exercising the non-scalar code needs to be developed.

Aaron Conole (3):
  acl: fix arm argument types
  acl: update the build for multi-arch
  acl: adjust the tests

 app/test/test_acl.c             | 62 +++++++++++++--------------------
 lib/librte_acl/Makefile         |  1 +
 lib/librte_acl/acl_run_neon.h   | 46 ++++++++++++++----------
 lib/librte_acl/acl_run_notsup.c | 46 ++++++++++++++++++++++++
 lib/librte_acl/meson.build      |  9 +++--
 5 files changed, 104 insertions(+), 60 deletions(-)
 create mode 100644 lib/librte_acl/acl_run_notsup.c

Comments

Aaron Conole April 8, 2019, 8:40 p.m. UTC | #1
Aaron Conole <aconole@redhat.com> writes:

> This series fixes the following conditions in the RTE_ACL library:
>
>   1. Fix outstanding compilation issues on ARM with the NEON optimized code
>      These consisted mostly of compiler type-cast warnings.  Additionally, some
>      of the vector code didn't initialize memory properly.
>
>   2. Properly include ARM, and PPC objects when building on those platforms
>      During the meson port, only the scalar code, and some of the x86_64 code was
>      ported.
>
>   3. Allow the unit tests to pass
>      In order to support this, the unsupported symbols were moved to a separate
>      file, which was needed to prevent the compiler from inlining references to the
>      functions (resulting in non-scalar code always falling into the -ENOTSUP case).
>
>      The tests were modified to primarily test the scalar version - a better system
>      for exercising the non-scalar code needs to be developed.
>
> Aaron Conole (3):
>   acl: fix arm argument types
>   acl: update the build for multi-arch
>   acl: adjust the tests
>
>  app/test/test_acl.c             | 62 +++++++++++++--------------------
>  lib/librte_acl/Makefile         |  1 +
>  lib/librte_acl/acl_run_neon.h   | 46 ++++++++++++++----------
>  lib/librte_acl/acl_run_notsup.c | 46 ++++++++++++++++++++++++
>  lib/librte_acl/meson.build      |  9 +++--
>  5 files changed, 104 insertions(+), 60 deletions(-)
>  create mode 100644 lib/librte_acl/acl_run_notsup.c

Might have sent prematurely - please ignore for the time being.