[v4,0/3] example and test cases optimizations
mbox series

Message ID 1554692551-28275-1-git-send-email-phil.yang@arm.com
Headers show
Series
  • example and test cases optimizations
Related show

Message

Phil Yang April 8, 2019, 3:02 a.m. UTC
v4:
packet_ordering: Fixed -Wmissing-braces issue for clang build.
(Thomas Monjalon)

v3:
test_distributor: Remove the conditional compilation and just keep the
__atomic_xxx calls. (Honnappa Nagarahalli)

v2:
1. Add per lcore statistics for each worker thread, removed __sync
builtins.
2. Reimplement test_distributor with atomic one-way barrier, if
C11_MEM_MODEL is enabled.
3. Reimplement test_ring_perf with atomic one-way barrier, if
C11_MEM_MODEL is enabled.

v1:
Reimplement packet_ordering with __atomic one-way barrier.

Phil Yang (3):
  packet_ordering: add statistics for each worker thread
  test/distributor: replace sync builtins with atomic builtins
  test/ring_perf: replace sync builtins with atomic builtins

 app/test/test_distributor.c                  |  7 ++--
 app/test/test_distributor_perf.c             |  2 +-
 app/test/test_ring_perf.c                    | 12 +++++--
 doc/guides/sample_app_ug/packet_ordering.rst |  4 ++-
 examples/packet_ordering/main.c              | 50 +++++++++++++++++++++++++---
 5 files changed, 63 insertions(+), 12 deletions(-)

Comments

Thomas Monjalon July 4, 2019, 8:15 p.m. UTC | #1
08/04/2019 05:02, Phil Yang:
> Phil Yang (3):
>   packet_ordering: add statistics for each worker thread
>   test/distributor: replace sync builtins with atomic builtins
>   test/ring_perf: replace sync builtins with atomic builtins

No more update regarding the performance gain or loss?

Any decision to merge it in 19.08?
Phil Yang July 5, 2019, 3:19 a.m. UTC | #2
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, July 5, 2019 4:16 AM
> To: dev@dpdk.org; Phil Yang (Arm Technology China) <Phil.Yang@arm.com>
> Cc: david.hunt@intel.com; reshma.pattan@intel.com; Gavin Hu (Arm
> Technology China) <Gavin.Hu@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>;
> bruce.richardson@intel.com; konstantin.ananyev@intel.com;
> david.marchand@redhat.com
> Subject: Re: [dpdk-dev] [PATCH v4 0/3] example and test cases optimizations
> 
> 08/04/2019 05:02, Phil Yang:
> > Phil Yang (3):
> >   packet_ordering: add statistics for each worker thread
> >   test/distributor: replace sync builtins with atomic builtins
> >   test/ring_perf: replace sync builtins with atomic builtins
> 


Hi Thomas,

Thanks for refreshing.
> No more update regarding the performance gain or loss?
Currently, I have no more update on this.  I didn't saw any performance loss with those patches on x86_64 and aarch64 platforms.

> 
> Any decision to merge it in 19.08?
> 

Thanks,
Phil
Thomas Monjalon July 8, 2019, 2:38 p.m. UTC | #3
08/04/2019 05:02, Phil Yang:
> Phil Yang (3):
>   packet_ordering: add statistics for each worker thread
>   test/distributor: replace sync builtins with atomic builtins
>   test/ring_perf: replace sync builtins with atomic builtins

After months of wait for comments,
Applied, thanks