From patchwork Thu Apr 4 08:55:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Varghese, Vipin" X-Patchwork-Id: 52262 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C8CB5F0D; Thu, 4 Apr 2019 10:54:54 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8AD195B40 for ; Thu, 4 Apr 2019 10:54:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2019 01:54:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,306,1549958400"; d="scan'208";a="146518218" Received: from unknown (HELO saesrv02-S2600CWR.intel.com) ([10.224.122.203]) by FMSMGA003.fm.intel.com with ESMTP; 04 Apr 2019 01:54:48 -0700 From: Vipin Varghese To: dev@dpdk.org, marko.kovacevic@intel.com, reshma.pattan@intel.com, david.marchand@redhat.com Cc: keith.wiles@intel.com, john.mcnamara@intel.com, stephen1.byrne@intel.com, amit.tamboli@intel.com, sanjay.padubidri@intel.com, amol.patel@intel.com, Vipin Varghese Date: Thu, 4 Apr 2019 14:25:13 +0530 Message-Id: <20190404085515.15789-1-vipin.varghese@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190402091836.35779-3-vipin.varghese@intel.com> References: <20190402091836.35779-3-vipin.varghese@intel.com> Subject: [dpdk-dev] [PATCH v6 0/2] app/pdump: enhance to support unique cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The patch series enhances application to support pdump capture to run on unique cores. Motivation ========== DPDK pdump capture tool currently runs as secondary on the default core 0. For all --pdump, core 0 iterates and capture packets. This leads to drops and delay in the capture. This introduces skew in result and performance bottleneck. In order to allow --pdump to unique cores, the pdump application has to be support multi-core in EAL arguments and each --pdump has to be mapped to unique cores. Status ====== - Default c_flag option is removed. - with option --multi, the application can run on unique cores. Change Log: =========== V6: - change MACRO value - David Marchand - use MACRO in usage function - David Marchand - correct spelling in documentation - Reshma Pathan V5: - Re-use MACRO and replace strncmp - David Marchand V4: - spelling correction - Reshma Pathan - remove c_falg - Reshma Pathan V3: - correct the parse_usage - Vipin Varghese - add change log - Vipin Varghese V2: - Replace option '-c' to '-l' - Keith Wiles Vipin Varghese (2): app/pdump: remove core restriction app/pdump: enhance to support multi-core capture app/pdump/main.c | 113 +++++++++++++++++++++++++++---------- doc/guides/tools/pdump.rst | 8 ++- 2 files changed, 91 insertions(+), 30 deletions(-) Future: ======= - Ehance multi mode, allow master to stop --pdump for desired file size. - Ehance multi mode, allow to suggest NUMA aware file locations. - Stop unique pdump.