mbox series

[v3,0/4] adding rsa priv key feature flag

Message ID 1553768834-19072-1-git-send-email-ayverma@marvell.com (mailing list archive)
Headers
Series adding rsa priv key feature flag |

Message

Ayuj Verma March 28, 2019, 10:27 a.m. UTC 
  Some PMDs can support RSA private key operations using CRT
(quintuple) or exponent key only. Thus add a feature flag
RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and
RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key
type is supported to perform rsa private key op.

App should query PMD feature flag to check if specific
key type is supported and call operation with relevant key type.

Changes in v3:
        - Rebase changes on top of latest unit test application
        - add feature flag description in documentation

Changes in v2:
        - RSA key type feature flags exponenet and quintuple,
          in place of making them part of xform capabilities.

Ayuj Verma (4):
  lib/cryptodev: add rsa priv key feature flag
  crypto/openssl: set rsa private op feature flag
  app/test: check for key type ff in asym unit test
  doc: add rsa key type to feature list

 app/test/test_cryptodev_asym.c             | 26 ++++++++++++++++++++++++++
 doc/guides/cryptodevs/features/openssl.ini |  2 ++
 doc/guides/cryptodevs/overview.rst         |  6 ++++++
 drivers/crypto/openssl/rte_openssl_pmd.c   |  4 +++-
 lib/librte_cryptodev/rte_cryptodev.c       |  4 ++++
 lib/librte_cryptodev/rte_cryptodev.h       |  4 ++++
 6 files changed, 45 insertions(+), 1 deletion(-)

Comments

Akhil Goyal March 29, 2019, 3:01 p.m. UTC | #1 
On 3/28/2019 3:57 PM, Ayuj Verma wrote:
> Some PMDs can support RSA private key operations using CRT
> (quintuple) or exponent key only. Thus add a feature flag
> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and
> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key
> type is supported to perform rsa private key op.
>
> App should query PMD feature flag to check if specific
> key type is supported and call operation with relevant key type.
>
> Changes in v3:
>          - Rebase changes on top of latest unit test application
>          - add feature flag description in documentation
>
> Changes in v2:
>          - RSA key type feature flags exponenet and quintuple,
>            in place of making them part of xform capabilities.
>
> Ayuj Verma (4):
>    lib/cryptodev: add rsa priv key feature flag
>    crypto/openssl: set rsa private op feature flag
>    app/test: check for key type ff in asym unit test
>    doc: add rsa key type to feature list
>
>   app/test/test_cryptodev_asym.c             | 26 ++++++++++++++++++++++++++
>   doc/guides/cryptodevs/features/openssl.ini |  2 ++
>   doc/guides/cryptodevs/overview.rst         |  6 ++++++
>   drivers/crypto/openssl/rte_openssl_pmd.c   |  4 +++-
>   lib/librte_cryptodev/rte_cryptodev.c       |  4 ++++
>   lib/librte_cryptodev/rte_cryptodev.h       |  4 ++++
>   6 files changed, 45 insertions(+), 1 deletion(-)
>
Series- Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

doc patch should be merged in previous patches.
Will do it while merging.

Thanks.
Akhil Goyal March 29, 2019, 3:17 p.m. UTC | #2 
On 3/28/2019 3:57 PM, Ayuj Verma wrote:
> Some PMDs can support RSA private key operations using CRT
> (quintuple) or exponent key only. Thus add a feature flag
> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and
> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key
> type is supported to perform rsa private key op.
>
> App should query PMD feature flag to check if specific
> key type is supported and call operation with relevant key type.
>
> Changes in v3:
>          - Rebase changes on top of latest unit test application
>          - add feature flag description in documentation
>
> Changes in v2:
>          - RSA key type feature flags exponenet and quintuple,
>            in place of making them part of xform capabilities.
>
> Ayuj Verma (4):
>    lib/cryptodev: add rsa priv key feature flag
>    crypto/openssl: set rsa private op feature flag
>    app/test: check for key type ff in asym unit test
>    doc: add rsa key type to feature list
>
>   app/test/test_cryptodev_asym.c             | 26 ++++++++++++++++++++++++++
>   doc/guides/cryptodevs/features/openssl.ini |  2 ++
>   doc/guides/cryptodevs/overview.rst         |  6 ++++++
>   drivers/crypto/openssl/rte_openssl_pmd.c   |  4 +++-
>   lib/librte_cryptodev/rte_cryptodev.c       |  4 ++++
>   lib/librte_cryptodev/rte_cryptodev.h       |  4 ++++
>   6 files changed, 45 insertions(+), 1 deletion(-)
>
Applied to dpdk-next-crypto

4th patch squashed to 1st and 2nd.
Also added description for 3rd patch. Please add relevant information in 
the description in future.

Thanks.
Ayuj Verma March 29, 2019, 3:20 p.m. UTC | #3 
Hi Akhil,


Thanks.

Please add relevant information in the description in future.

Sure will keep this in mind.


Thanks and regards

Ayuj Verma
Akhil Goyal April 3, 2019, 8:47 a.m. UTC | #4 
On 3/29/2019 8:47 PM, Akhil Goyal wrote:
>
> On 3/28/2019 3:57 PM, Ayuj Verma wrote:
>> Some PMDs can support RSA private key operations using CRT
>> (quintuple) or exponent key only. Thus add a feature flag
>> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and
>> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key
>> type is supported to perform rsa private key op.
>>
>> App should query PMD feature flag to check if specific
>> key type is supported and call operation with relevant key type.
>>
>> Changes in v3:
>>           - Rebase changes on top of latest unit test application
>>           - add feature flag description in documentation
>>
>> Changes in v2:
>>           - RSA key type feature flags exponenet and quintuple,
>>             in place of making them part of xform capabilities.
>>
>> Ayuj Verma (4):
>>     lib/cryptodev: add rsa priv key feature flag
>>     crypto/openssl: set rsa private op feature flag
>>     app/test: check for key type ff in asym unit test
>>     doc: add rsa key type to feature list
>>
>>    app/test/test_cryptodev_asym.c             | 26 ++++++++++++++++++++++++++
>>    doc/guides/cryptodevs/features/openssl.ini |  2 ++
>>    doc/guides/cryptodevs/overview.rst         |  6 ++++++
>>    drivers/crypto/openssl/rte_openssl_pmd.c   |  4 +++-
>>    lib/librte_cryptodev/rte_cryptodev.c       |  4 ++++
>>    lib/librte_cryptodev/rte_cryptodev.h       |  4 ++++
>>    6 files changed, 45 insertions(+), 1 deletion(-)
>>
> Applied to dpdk-next-crypto
>
> 4th patch squashed to 1st and 2nd.
> Also added description for 3rd patch. Please add relevant information in
> the description in future.
>
> Thanks.
Following errors were observed in compiling documentation

Warning generate_overview_table(): Unknown feature 'RSA PRIV OP KEY EXP' 
in 'openssl.ini'

Warning generate_overview_table(): Unknown feature 'RSA PRIV OP KEY QT' 
in 'openssl.ini'


I corrected these byadding the two features in features/default.ini. -Akhil
Ayuj Verma April 3, 2019, 10:09 a.m. UTC | #5 
Hi Akhil,


Thanks.


Regards

Ayuj Verma