mbox series

[00/15] net/enic: 19.05 updates

Message ID 20190228070317.17002-1-hyonkim@cisco.com (mailing list archive)
Headers
Series net/enic: 19.05 updates |

Message

Hyong Youb Kim (hyonkim) Feb. 28, 2019, 7:03 a.m. UTC 
  This patch series fixes bugs in enic's implementation of flow API and
adds very limited support for RAW, RSS, and PASSTHRU. Limited RSS and
PASSTHRU are intended to support partial offloads in OVS-DPDK and
VPP. These apps use MARK + default RSS and PASSTHRU + MARK to "mark
packet and then receive normally". Cisco VIC can support these, even
though general RSS and PASSTHRU are not possible.

Intentionally removed Cc: stable from the last patch ("net/enic: fix
several issues with inner packet matching") as it depends on a non-fix
patch ("net/enic: move arguments into struct"). I will submit backport
request for these separately, after rc1.

Hyong Youb Kim (15):
  net/enic: remove unused code
  net/enic: fix flow director SCTP matching
  net/enic: fix SCTP match for flow API
  net/enic: allow flow mark ID 0
  net/enic: check for unsupported flow item types
  net/enic: enable limited RSS flow action
  net/enic: enable limited PASSTHRU flow action
  net/enic: move arguments into struct
  net/enic: enable limited support for RAW flow item
  net/enic: initialize VXLAN port regardless of overlay offload
  net/enic: fix a couple issues with VXLAN match
  net/enic: fix an endian bug in VLAN match
  net/enic: fix several issues with inner packet matching
  doc: update enic guide
  doc: update release notes for enic

 doc/guides/nics/enic.rst               |  16 +-
 doc/guides/rel_notes/release_19_05.rst |   5 +
 drivers/net/enic/Makefile              |   1 -
 drivers/net/enic/base/vnic_rss.c       |  23 -
 drivers/net/enic/base/vnic_rss.h       |   5 -
 drivers/net/enic/enic.h                |   8 +-
 drivers/net/enic/enic_clsf.c           |  38 +-
 drivers/net/enic/enic_flow.c           | 786 +++++++++++++++++++++------------
 drivers/net/enic/enic_main.c           |   9 +-
 drivers/net/enic/enic_res.c            |  26 --
 drivers/net/enic/enic_res.h            |   2 -
 drivers/net/enic/enic_rxtx_common.h    |   3 +-
 drivers/net/enic/meson.build           |   1 -
 13 files changed, 557 insertions(+), 366 deletions(-)
 delete mode 100644 drivers/net/enic/base/vnic_rss.c

Comments

Thomas Monjalon March 1, 2019, 2:26 p.m. UTC | #1 
Hi,

> Hyong Youb Kim (15):
>   net/enic: remove unused code
>   net/enic: fix flow director SCTP matching
>   net/enic: fix SCTP match for flow API
>   net/enic: allow flow mark ID 0
>   net/enic: check for unsupported flow item types
>   net/enic: enable limited RSS flow action
>   net/enic: enable limited PASSTHRU flow action
>   net/enic: move arguments into struct
>   net/enic: enable limited support for RAW flow item
>   net/enic: initialize VXLAN port regardless of overlay offload
>   net/enic: fix a couple issues with VXLAN match
>   net/enic: fix an endian bug in VLAN match
>   net/enic: fix several issues with inner packet matching
>   doc: update enic guide
>   doc: update release notes for enic

It is better to update the doc in the patch of the code change.
It would allow to find the code changes by looking at the doc history
(with "git blame" or others).
The other benefit is to avoid some "noise" in the git history for doc.

Thanks
Hyong Youb Kim (hyonkim) March 1, 2019, 2:56 p.m. UTC | #2 
On Fri, Mar 01, 2019 at 03:26:24PM +0100, Thomas Monjalon wrote:
> Hi,
> 
> > Hyong Youb Kim (15):
> >   net/enic: remove unused code
> >   net/enic: fix flow director SCTP matching
> >   net/enic: fix SCTP match for flow API
> >   net/enic: allow flow mark ID 0
> >   net/enic: check for unsupported flow item types
> >   net/enic: enable limited RSS flow action
> >   net/enic: enable limited PASSTHRU flow action
> >   net/enic: move arguments into struct
> >   net/enic: enable limited support for RAW flow item
> >   net/enic: initialize VXLAN port regardless of overlay offload
> >   net/enic: fix a couple issues with VXLAN match
> >   net/enic: fix an endian bug in VLAN match
> >   net/enic: fix several issues with inner packet matching
> >   doc: update enic guide
> >   doc: update release notes for enic
> 
> It is better to update the doc in the patch of the code change.
> It would allow to find the code changes by looking at the doc history
> (with "git blame" or others).
> The other benefit is to avoid some "noise" in the git history for doc.

I will send a v2.

Thanks.
-Hyong