mbox series

[v3,0/3] Replace compilation time options with log level

Message ID 20190220230023.17029-1-dharmik.thakkar@arm.com (mailing list archive)
Headers
Series Replace compilation time options with log level |

Message

Dharmik Thakkar Feb. 20, 2019, 11 p.m. UTC
  Currently, in test code, for printing extra information,
compilation time options are used. This approach does not compile the
code always. Macro needs to be set for the code to compile.

This patchset replaces compilation time option with log level based
approach, thus enabling compilation of code always. Log levels can be
set using eal parameters.

Dharmik Thakkar (3):
  test/hash: replace macro with log-level approach
  test/efd: enable unit test compilation always
  test/timer: enable unit test compilation always

 test/test/test_efd.c            | 24 ++++++++----------------
 test/test/test_hash.c           |  3 +--
 test/test/test_timer_racecond.c | 23 ++++++++++-------------
 3 files changed, 19 insertions(+), 31 deletions(-)
  

Comments

Stephen Hemminger Feb. 20, 2019, 11:08 p.m. UTC | #1
On Wed, 20 Feb 2019 17:00:20 -0600
Dharmik Thakkar <dharmik.thakkar@arm.com> wrote:

> Currently, in test code, for printing extra information,
> compilation time options are used. This approach does not compile the
> code always. Macro needs to be set for the code to compile.
> 
> This patchset replaces compilation time option with log level based
> approach, thus enabling compilation of code always. Log levels can be
> set using eal parameters.
> 
> Dharmik Thakkar (3):
>   test/hash: replace macro with log-level approach
>   test/efd: enable unit test compilation always
>   test/timer: enable unit test compilation always
> 
>  test/test/test_efd.c            | 24 ++++++++----------------
>  test/test/test_hash.c           |  3 +--
>  test/test/test_timer_racecond.c | 23 ++++++++++-------------
>  3 files changed, 19 insertions(+), 31 deletions(-)
> 

Maybe the tests should use their own dynamic logging (i.e. --log-level=test.hash:debug)
  
Dharmik Thakkar Feb. 26, 2019, 11:05 p.m. UTC | #2
> On Feb 20, 2019, at 5:08 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> On Wed, 20 Feb 2019 17:00:20 -0600
> Dharmik Thakkar <dharmik.thakkar@arm.com> wrote:
> 
>> Currently, in test code, for printing extra information,
>> compilation time options are used. This approach does not compile the
>> code always. Macro needs to be set for the code to compile.
>> 
>> This patchset replaces compilation time option with log level based
>> approach, thus enabling compilation of code always. Log levels can be
>> set using eal parameters.
>> 
>> Dharmik Thakkar (3):
>>  test/hash: replace macro with log-level approach
>>  test/efd: enable unit test compilation always
>>  test/timer: enable unit test compilation always
>> 
>> test/test/test_efd.c            | 24 ++++++++----------------
>> test/test/test_hash.c           |  3 +--
>> test/test/test_timer_racecond.c | 23 ++++++++++-------------
>> 3 files changed, 19 insertions(+), 31 deletions(-)
>> 
> 
> Maybe the tests should use their own dynamic logging (i.e. --log-level=test.hash:debug)
Updated. Thank you!