[0/3] promiscuous mode enable on VF

  There is need to enable promiscuous mode enable on VF,
pf host should also enable to support that.

Zhao Wei (3):
  net/ixgbe: promiscuous mode enable on VF
  net/ixgbe: enable promiscous mode on PF host
  net/ixgbe: update API version

 drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++
 drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
 drivers/net/ixgbe/ixgbe_pf.c     | 79 +++++++++++++++++++++++++++++-----------
 3 files changed, 79 insertions(+), 22 deletions(-)
  

On Wed, Jan 16, 2019 at 6:08 AM Wei Zhao <wei.zhao1@intel.com> wrote:

> There is need to enable promiscuous mode enable on VF,
> pf host should also enable to support that.
>
> Zhao Wei (3):
>   net/ixgbe: promiscuous mode enable on VF
>   net/ixgbe: enable promiscous mode on PF host
>   net/ixgbe: update API version
>
>  drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++
>  drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
>  drivers/net/ixgbe/ixgbe_pf.c     | 79
> +++++++++++++++++++++++++++++-----------
>  3 files changed, 79 insertions(+), 22 deletions(-)
>
> --
> 2.7.5
>

This series looks more about a missing feature than a proper fix.
We have a new pf/vf api supported in this series and a new behaviour for
promiscuous.
This is not stable material to me unless you expose a clear problem that
this series wants to address.
  

On Wed, 16 Jan 2019 12:42:52 +0800
Wei Zhao <wei.zhao1@intel.com> wrote:

> There is need to enable promiscuous mode enable on VF,
> pf host should also enable to support that.
> 
> Zhao Wei (3):
>   net/ixgbe: promiscuous mode enable on VF
>   net/ixgbe: enable promiscous mode on PF host
>   net/ixgbe: update API version
> 
>  drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++
>  drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
>  drivers/net/ixgbe/ixgbe_pf.c     | 79 +++++++++++++++++++++++++++++-----------
>  3 files changed, 79 insertions(+), 22 deletions(-)
> 

Is there someway to check if PF on host allows promiscious mode (and
fail the attempt to set it on VF if not allowed).
  

From: David Marchand [mailto:david.marchand@redhat.com]
Sent: Wednesday, January 16, 2019 4:29 PM
To: Zhao1, Wei <wei.zhao1@intel.com>
Cc: dev@dpdk.org; dpdk stable <stable@dpdk.org>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF

On Wed, Jan 16, 2019 at 6:08 AM Wei Zhao <wei.zhao1@intel.com<mailto:wei.zhao1@intel.com>> wrote:
There is need to enable promiscuous mode enable on VF,
pf host should also enable to support that.

Zhao Wei (3):
  net/ixgbe: promiscuous mode enable on VF
  net/ixgbe: enable promiscous mode on PF host
  net/ixgbe: update API version

 drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++
 drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
 drivers/net/ixgbe/ixgbe_pf.c     | 79 +++++++++++++++++++++++++++++-----------
 3 files changed, 79 insertions(+), 22 deletions(-)

--
2.7.5

This series looks more about a missing feature than a proper fix.
We have a new pf/vf api supported in this series and a new behaviour for promiscuous.
This is not stable material to me unless you expose a clear problem that this series wants to address.

Yes, this a new feature enable related, but this patch set will not introduce problem, because vf
promiscuous mode is close by default, this set is just send out for request from users that want to use
vf promiscuous. They will open it in their APP. NOT only ixgbe, but also other NIC vf HAS SUPPORT this feature.


--
David Marchand
  

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, January 17, 2019 2:59 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF
> 
> On Wed, 16 Jan 2019 12:42:52 +0800
> Wei Zhao <wei.zhao1@intel.com> wrote:
> 
> > There is need to enable promiscuous mode enable on VF, pf host should
> > also enable to support that.
> >
> > Zhao Wei (3):
> >   net/ixgbe: promiscuous mode enable on VF
> >   net/ixgbe: enable promiscous mode on PF host
> >   net/ixgbe: update API version
> >
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++
> > drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
> >  drivers/net/ixgbe/ixgbe_pf.c     | 79
> +++++++++++++++++++++++++++++-----------
> >  3 files changed, 79 insertions(+), 22 deletions(-)
> >
> 
> Is there someway to check if PF on host allows promiscious mode (and fail
> the attempt to set it on VF if not allowed).

Yes, 
Pf host has check vfinfo[vf].api_version, that is key for that check.
If fail, it will return -1.


	switch (vfinfo[vf].api_version) {
 	case ixgbe_mbox_api_12:
+		/* promisc introduced in 1.3 version */
+		if (xcast_mode == IXGBEVF_XCAST_MODE_PROMISC)
+			return -EOPNOTSUPP;
+		break;
+		/* Fall threw */
+	case ixgbe_mbox_api_13:
 		break;
 	default:
 		return -1;
 	}