mbox series

[0/6] net/tap: fixes and cleanups

Message ID 20190111180659.5972-1-stephen@networkplumber.org (mailing list archive)
Headers
Series net/tap: fixes and cleanups |

Message

Stephen Hemminger Jan. 11, 2019, 6:06 p.m. UTC 
  The tap device (used by vdev_netvsc on Azure) has a bug that
prevents it working with primary/secondary process model because
the device name generation assumed a single process.  The fix for
this is to have the kernel assign the device name (patch #5).

While investigating this, found a number of other small issues
that should be cleaned up as well.

Stephen Hemminger (6):
  net/tap: use strlcpy for interface name
  net/tap: allow full length names
  net/tap: check interface name in kvargs
  net/tap: lower the priority of log messages
  net/tap: let kernel choose tun device name
  net/tap: get rid of global tuntap_name

 drivers/net/tap/rte_eth_tap.c | 106 +++++++++++++++++++++-------------
 1 file changed, 65 insertions(+), 41 deletions(-)

Comments

Wiles, Keith Jan. 11, 2019, 7:47 p.m. UTC | #1 
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> The tap device (used by vdev_netvsc on Azure) has a bug that
> prevents it working with primary/secondary process model because
> the device name generation assumed a single process.  The fix for
> this is to have the kernel assign the device name (patch #5).
> 
> While investigating this, found a number of other small issues
> that should be cleaned up as well.
> 
> Stephen Hemminger (6):
>  net/tap: use strlcpy for interface name
>  net/tap: allow full length names
>  net/tap: check interface name in kvargs
>  net/tap: lower the priority of log messages
>  net/tap: let kernel choose tun device name
>  net/tap: get rid of global tuntap_name
> 
> drivers/net/tap/rte_eth_tap.c | 106 +++++++++++++++++++++-------------
> 1 file changed, 65 insertions(+), 41 deletions(-)
> 
> -- 
> 2.20.1
> 

All of these look good except for a few comments. The styling changes I think need to be address, but if everyone is find with it then I  will be OK after a few more drinks.

Acked-by Keith Wiles <keith.wiles@intel.com>

Regards,
Keith