Message ID | 20190111180659.5972-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 428E11BA65; Fri, 11 Jan 2019 19:07:11 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 3BF721BA5D for <dev@dpdk.org>; Fri, 11 Jan 2019 19:07:09 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id u6so7279720pfh.11 for <dev@dpdk.org>; Fri, 11 Jan 2019 10:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I8GmCa+eD9EUeqxSV7DmRDihC3d7WjJNPCzsViZNuMA=; b=nczt/gz1Byqd5HmWgkc/ze4/0fYwtl3K+NMDJQgHN2qZtyUJ1gbhEyjJpGtZH6U3pO nmj6uJUiTWlvbxRN1IQOg0aTo5iyCjZZnNTOBUXZsunPNifDnfjcdd444QiEu6ul3W7Z OEYHjf0zjnBNMpn2XBVCU1gYdFckJIVoXrkJEIpGbjPwEfBUCnk4gN3F1tt5C2AbIK61 jKMsDaRydVBUFh8UDxFfxaIcf4XvgdLXvoTi0cqbq/2TAVmokkhzWJRIRZ0ChJ/kgLZM fplBSYbOG8n1O3KLVdziPI8MBVZUzic0PrckCV24poEaUTvdSEPP2jdXSO+/n/JHAuvC Mjfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I8GmCa+eD9EUeqxSV7DmRDihC3d7WjJNPCzsViZNuMA=; b=NZn+pjgGE8HI8QaCgLP0ekIrszpeDefmIE2Hcp6WAiTHVID8gbE257DCM9YPgiG1fK 6zkTmYuXk9QcJiYlGOHfUc6qi6EWLnY8tUZx4ohw/KdytexTTnyUDRUT0qClqQjTK4+d F+OnVtO1JJDcQDebDoDh4zE6Cs+aFkeRQ9UswKWPFd6XYp8eGkAF/A2NovxEkmfnDufa H5JIV+2+++fw/FAy9qvKz23QK8No+dDWzpSQOW559Abfa9F5Chq4GKlNhTlsEnJMcIw9 NouIClR7B7ZVLj/ABLjdZU2iuvZ0WWoclfv75Y8k1FUTos658A9tQbl0VBLn8bI2zQon rv+g== X-Gm-Message-State: AJcUukdy0lDWZdE1KfCzeq9str7dfhCjGfRD1WCPr3TcvFAtGK0irz8h hBQEAj57DdSnrIaMmgcJksBkevxlq6c= X-Google-Smtp-Source: ALg8bN4VdmNTwBNvPpi4Xv72LcXyDqT/qEcNkw0AXVgLOWjz3I/8BpZxuOHf/P2HizlHACHRD9IZOQ== X-Received: by 2002:a62:33c1:: with SMTP id z184mr15463110pfz.104.1547230027774; Fri, 11 Jan 2019 10:07:07 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n186sm107213303pfn.137.2019.01.11.10.07.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jan 2019 10:07:06 -0800 (PST) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Fri, 11 Jan 2019 10:06:53 -0800 Message-Id: <20190111180659.5972-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/6] net/tap: fixes and cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/tap: fixes and cleanups
|
|
Message
Stephen Hemminger
Jan. 11, 2019, 6:06 p.m. UTC
The tap device (used by vdev_netvsc on Azure) has a bug that prevents it working with primary/secondary process model because the device name generation assumed a single process. The fix for this is to have the kernel assign the device name (patch #5). While investigating this, found a number of other small issues that should be cleaned up as well. Stephen Hemminger (6): net/tap: use strlcpy for interface name net/tap: allow full length names net/tap: check interface name in kvargs net/tap: lower the priority of log messages net/tap: let kernel choose tun device name net/tap: get rid of global tuntap_name drivers/net/tap/rte_eth_tap.c | 106 +++++++++++++++++++++------------- 1 file changed, 65 insertions(+), 41 deletions(-)
Comments
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger <stephen@networkplumber.org> wrote: > > The tap device (used by vdev_netvsc on Azure) has a bug that > prevents it working with primary/secondary process model because > the device name generation assumed a single process. The fix for > this is to have the kernel assign the device name (patch #5). > > While investigating this, found a number of other small issues > that should be cleaned up as well. > > Stephen Hemminger (6): > net/tap: use strlcpy for interface name > net/tap: allow full length names > net/tap: check interface name in kvargs > net/tap: lower the priority of log messages > net/tap: let kernel choose tun device name > net/tap: get rid of global tuntap_name > > drivers/net/tap/rte_eth_tap.c | 106 +++++++++++++++++++++------------- > 1 file changed, 65 insertions(+), 41 deletions(-) > > -- > 2.20.1 > All of these look good except for a few comments. The styling changes I think need to be address, but if everyone is find with it then I will be OK after a few more drinks. Acked-by Keith Wiles <keith.wiles@intel.com> Regards, Keith