mbox series

[v3,0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM.

Message ID 20190109145015.3010-1-i.maximets@samsung.com (mailing list archive)
Headers
Series Missing barriers and VIRTIO_F_ORDER_PLATFORM. |

Message

Ilya Maximets Jan. 9, 2019, 2:50 p.m. UTC 
  Version 3:
  * Added 2 patches with fixes for current virtio driver.
    Not directly connected with the new feature.

Version 2:
  * rebased on current master (packed rings).

RFC --> Version 1:
  * Dropped vendor-specific hack to determine if we need real barriers.
  * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking.

Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER
      to VIRTIO_F_ORDER_PLATFORM is not merged yet:
      https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html

Ilya Maximets (3):
  net/virtio: add missing barrier before reading the flags
  net/virtio: update memory ordering comment for vq notify
  net/virtio: add platform memory ordering feature support

 drivers/net/virtio/virtio_ethdev.c |  2 ++
 drivers/net/virtio/virtio_ethdev.h |  3 +-
 drivers/net/virtio/virtio_pci.h    |  7 ++++
 drivers/net/virtio/virtio_rxtx.c   | 16 ++++-----
 drivers/net/virtio/virtqueue.h     | 56 +++++++++++++++++++++++-------
 5 files changed, 63 insertions(+), 21 deletions(-)

Comments

Michael S. Tsirkin Jan. 9, 2019, 2:55 p.m. UTC | #1 
On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote:
> Version 3:
>   * Added 2 patches with fixes for current virtio driver.
>     Not directly connected with the new feature.

New version shouldn't be reply-to old one really :).
But the patches are good I think.

Acked-by: Michael S. Tsirkin <mst@redhat.com>



> Version 2:
>   * rebased on current master (packed rings).
> 
> RFC --> Version 1:
>   * Dropped vendor-specific hack to determine if we need real barriers.
>   * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking.
> 
> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER
>       to VIRTIO_F_ORDER_PLATFORM is not merged yet:
>       https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html
> 
> Ilya Maximets (3):
>   net/virtio: add missing barrier before reading the flags
>   net/virtio: update memory ordering comment for vq notify
>   net/virtio: add platform memory ordering feature support
> 
>  drivers/net/virtio/virtio_ethdev.c |  2 ++
>  drivers/net/virtio/virtio_ethdev.h |  3 +-
>  drivers/net/virtio/virtio_pci.h    |  7 ++++
>  drivers/net/virtio/virtio_rxtx.c   | 16 ++++-----
>  drivers/net/virtio/virtqueue.h     | 56 +++++++++++++++++++++++-------
>  5 files changed, 63 insertions(+), 21 deletions(-)
> 
> -- 
> 2.17.1
Ilya Maximets Jan. 9, 2019, 3:24 p.m. UTC | #2 
On 09.01.2019 17:55, Michael S. Tsirkin wrote:
> On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote:
>> Version 3:
>>   * Added 2 patches with fixes for current virtio driver.
>>     Not directly connected with the new feature.
> 
> New version shouldn't be reply-to old one really :).

It's kind of a common practice and a recommended thing for the
dpdk mail-list. At least it was.
I'm not doing that on other lists. =)

> But the patches are good I think.
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Thanks.

> 
> 
> 
>> Version 2:
>>   * rebased on current master (packed rings).
>>
>> RFC --> Version 1:
>>   * Dropped vendor-specific hack to determine if we need real barriers.
>>   * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking.
>>
>> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER
>>       to VIRTIO_F_ORDER_PLATFORM is not merged yet:
>>       https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html
>>
>> Ilya Maximets (3):
>>   net/virtio: add missing barrier before reading the flags
>>   net/virtio: update memory ordering comment for vq notify
>>   net/virtio: add platform memory ordering feature support
>>
>>  drivers/net/virtio/virtio_ethdev.c |  2 ++
>>  drivers/net/virtio/virtio_ethdev.h |  3 +-
>>  drivers/net/virtio/virtio_pci.h    |  7 ++++
>>  drivers/net/virtio/virtio_rxtx.c   | 16 ++++-----
>>  drivers/net/virtio/virtqueue.h     | 56 +++++++++++++++++++++++-------
>>  5 files changed, 63 insertions(+), 21 deletions(-)
>>
>> -- 
>> 2.17.1
> 
>
Ferruh Yigit Jan. 9, 2019, 4:53 p.m. UTC | #3 
On 1/9/2019 3:24 PM, Ilya Maximets wrote:
> On 09.01.2019 17:55, Michael S. Tsirkin wrote:
>> On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote:
>>> Version 3:
>>>   * Added 2 patches with fixes for current virtio driver.
>>>     Not directly connected with the new feature.
>>
>> New version shouldn't be reply-to old one really :).
> 
> It's kind of a common practice and a recommended thing for the
> dpdk mail-list. At least it was.
> I'm not doing that on other lists. =)

Yes this is something recommended to do. It helps a lot to be able to see all
versions and comments in same email thread.

> 
>> But the patches are good I think.
>>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Thanks.
> 
>>
>>
>>
>>> Version 2:
>>>   * rebased on current master (packed rings).
>>>
>>> RFC --> Version 1:
>>>   * Dropped vendor-specific hack to determine if we need real barriers.
>>>   * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking.
>>>
>>> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER
>>>       to VIRTIO_F_ORDER_PLATFORM is not merged yet:
>>>       https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html
>>>
>>> Ilya Maximets (3):
>>>   net/virtio: add missing barrier before reading the flags
>>>   net/virtio: update memory ordering comment for vq notify
>>>   net/virtio: add platform memory ordering feature support
>>>
>>>  drivers/net/virtio/virtio_ethdev.c |  2 ++
>>>  drivers/net/virtio/virtio_ethdev.h |  3 +-
>>>  drivers/net/virtio/virtio_pci.h    |  7 ++++
>>>  drivers/net/virtio/virtio_rxtx.c   | 16 ++++-----
>>>  drivers/net/virtio/virtqueue.h     | 56 +++++++++++++++++++++++-------
>>>  5 files changed, 63 insertions(+), 21 deletions(-)
>>>
>>> -- 
>>> 2.17.1
>>
>>
Maxime Coquelin Jan. 10, 2019, 3:19 p.m. UTC | #4 
On 1/9/19 3:55 PM, Michael S. Tsirkin wrote:
> On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote:
>> Version 3:
>>    * Added 2 patches with fixes for current virtio driver.
>>      Not directly connected with the new feature.
> 
> New version shouldn't be reply-to old one really :).
> But the patches are good I think.
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> 
> 
> 
>> Version 2:
>>    * rebased on current master (packed rings).
>>
>> RFC --> Version 1:
>>    * Dropped vendor-specific hack to determine if we need real barriers.
>>    * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking.
>>
>> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER
>>        to VIRTIO_F_ORDER_PLATFORM is not merged yet:
>>        https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html
>>
>> Ilya Maximets (3):
>>    net/virtio: add missing barrier before reading the flags
>>    net/virtio: update memory ordering comment for vq notify
>>    net/virtio: add platform memory ordering feature support
>>
>>   drivers/net/virtio/virtio_ethdev.c |  2 ++
>>   drivers/net/virtio/virtio_ethdev.h |  3 +-
>>   drivers/net/virtio/virtio_pci.h    |  7 ++++
>>   drivers/net/virtio/virtio_rxtx.c   | 16 ++++-----
>>   drivers/net/virtio/virtqueue.h     | 56 +++++++++++++++++++++++-------
>>   5 files changed, 63 insertions(+), 21 deletions(-)
>>
>> -- 
>> 2.17.1

Applied to dpdk-next-virtio/master.

Thanks,
Maxime