[v6,0/5] vhost: vhost_user.c code cleanup
mbox series

Message ID 153782013094.27450.17651924330876922486.stgit@T460
Headers show
Series
  • vhost: vhost_user.c code cleanup
Related show

Message

Nikolay Nikolaev Sept. 24, 2018, 8:16 p.m. UTC
vhost: vhost_user.c code cleanup

This patchesries introduce a set of code redesigns in vhost_user.c.

The goal is to unify and simplify vhost-user message handling. The
patches do not intend to introduce any functional changes.

v6 changes:
 - Even more fixes to the usage of struct VhostUserMsg in
   the patches (Anatoly Burakov)

v5 changes:
 - fixed the usage of struct VhostUserMsg in all patches (Anatoly Burakov)

v4 changes:
 - use struct VhostUserMsg as the coding style guide suggests (Anatoly Burakov)
 - VH_RESULT_FATAL is removed as not needed anymore (Maxime Coquelin)

v3 changes:
 - rebased on top of git://dpdk.org/next/dpdk-next-virtio dead0602
 - introduce VH_RESULT_FATAL (Maxime Coquelin)
 - vhost_user_set_features return VH_RESULT_FATAL on failure.
   This allows keeping the propagate error logic (Ilya Maximets)
 - fixed vhost_user_set_vring_kick and vhost_user_set_protocol_features
   return VH_RESULT_ERR upon failure
 - fixed missing break in case VH_RESULT_ERR (Ilya Maximets)
 - fixed a type on the description of 2/5 patch (Maxime Coquelin)

v2 changes:
 - Fix the comments by Tiwei Bie
 - Keep the old behavior
   - Fall through when the callback returns VH_RESULT_ERR
   - Fall through if the request is out of range

---

Nikolay Nikolaev (5):
      vhost: unify struct VhostUserMsg usage
      vhost: make message handling functions prepare the reply
      vhost: handle unsupported message types in functions
      vhost: unify message handling function signature
      vhost: message handling implemented as a callback array


 lib/librte_vhost/vhost_user.c |  394 ++++++++++++++++++++++-------------------
 1 file changed, 209 insertions(+), 185 deletions(-)

--
Signature

Comments

Maxime Coquelin Sept. 26, 2018, 1:51 p.m. UTC | #1
Hi Nikolay,

On 09/24/2018 10:16 PM, Nikolay Nikolaev wrote:
> vhost: vhost_user.c code cleanup
> 
> This patchesries introduce a set of code redesigns in vhost_user.c.
> 
> The goal is to unify and simplify vhost-user message handling. The
> patches do not intend to introduce any functional changes.
> 
> v6 changes:
>   - Even more fixes to the usage of struct VhostUserMsg in
>     the patches (Anatoly Burakov)
> 
> v5 changes:
>   - fixed the usage of struct VhostUserMsg in all patches (Anatoly Burakov)
> 
> v4 changes:
>   - use struct VhostUserMsg as the coding style guide suggests (Anatoly Burakov)
>   - VH_RESULT_FATAL is removed as not needed anymore (Maxime Coquelin)
> 
> v3 changes:
>   - rebased on top of git://dpdk.org/next/dpdk-next-virtio dead0602
>   - introduce VH_RESULT_FATAL (Maxime Coquelin)
>   - vhost_user_set_features return VH_RESULT_FATAL on failure.
>     This allows keeping the propagate error logic (Ilya Maximets)
>   - fixed vhost_user_set_vring_kick and vhost_user_set_protocol_features
>     return VH_RESULT_ERR upon failure
>   - fixed missing break in case VH_RESULT_ERR (Ilya Maximets)
>   - fixed a type on the description of 2/5 patch (Maxime Coquelin)
> 
> v2 changes:
>   - Fix the comments by Tiwei Bie
>   - Keep the old behavior
>     - Fall through when the callback returns VH_RESULT_ERR
>     - Fall through if the request is out of range
> 
> ---
> 
> Nikolay Nikolaev (5):
>        vhost: unify struct VhostUserMsg usage
>        vhost: make message handling functions prepare the reply
>        vhost: handle unsupported message types in functions
>        vhost: unify message handling function signature
>        vhost: message handling implemented as a callback array
> 
> 
>   lib/librte_vhost/vhost_user.c |  394 ++++++++++++++++++++++-------------------
>   1 file changed, 209 insertions(+), 185 deletions(-)
> 
> --
> Signature
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Series applied to dpdk-next-virtio with small change I suggested in
patch 5.

Thanks for your contribution!
Maxime