[v2,0/6] crypto/mvsam: add new features and fixes
mbox series

Message ID 1537541639-22764-1-git-send-email-amo@semihalf.com
Headers show
Series
  • crypto/mvsam: add new features and fixes
Related show

Message

Andrzej Ostruszka Sept. 21, 2018, 2:53 p.m. UTC
This patch series introduces following changes:

* Add support for HMAC SHA224, AES ECB and NULL algorithms.
* Update hash digest sizes to match hardware capabilities.
* Fix a shared build.

v2:
  * added Cc: stable@dpdk.org to couple of patches
  * rephrased the subject/commit msgs

Szymon Sliwa (1):
  crypto/mvsam: update hash digest sizes

Tomasz Duszynski (5):
  crypto/mvsam: fix shared library build
  crypto/mvsam: support for HMAC SHA224
  crypto/mvsam: support for AES ECB
  crypto/mvsam: support for crypto/auth NULL algorithms
  crypto/mvsam: add 3DES ECB to the capabilities list

 drivers/crypto/mvsam/Makefile           |   2 +-
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  15 ++++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++-----
 3 files changed, 144 insertions(+), 23 deletions(-)

Comments

Akhil Goyal Sept. 25, 2018, 3:24 p.m. UTC | #1
Hi Andrzej,

On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote:
> This patch series introduces following changes:
>
> * Add support for HMAC SHA224, AES ECB and NULL algorithms.
> * Update hash digest sizes to match hardware capabilities.
> * Fix a shared build.
>
> v2:
>    * added Cc: stable@dpdk.org to couple of patches
>    * rephrased the subject/commit msgs
>
> Szymon Sliwa (1):
>    crypto/mvsam: update hash digest sizes
>
> Tomasz Duszynski (5):
>    crypto/mvsam: fix shared library build
>    crypto/mvsam: support for HMAC SHA224
>    crypto/mvsam: support for AES ECB
>    crypto/mvsam: support for crypto/auth NULL algorithms
>    crypto/mvsam: add 3DES ECB to the capabilities list
>
>   drivers/crypto/mvsam/Makefile           |   2 +-
>   drivers/crypto/mvsam/rte_mrvl_pmd.c     |  15 ++++
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++-----
>   3 files changed, 144 insertions(+), 23 deletions(-)
>
I am not able to cleanly apply your 3 patchsets.
http://patches.dpdk.org/user/todo/dpdk/?series=1172
http://patches.dpdk.org/user/todo/dpdk/?series=1440
http://patches.dpdk.org/user/todo/dpdk/?series=1442

Could you please rebase and send a single patchset if possible.
Also, I believe http://patches.dpdk.org/patch/44254/
can be squashed with http://patches.dpdk.org/patch/45104/

Thanks,
Akhil
Andrzej Ostruszka Sept. 26, 2018, 10:03 a.m. UTC | #2
Hello Akhil

On 25.09.2018 17:24, Akhil Goyal wrote:
> Hi Andrzej,
[...]
> I am not able to cleanly apply your 3 patchsets.
> http://patches.dpdk.org/user/todo/dpdk/?series=1172
> http://patches.dpdk.org/user/todo/dpdk/?series=1440
> http://patches.dpdk.org/user/todo/dpdk/?series=1442
> 
> Could you please rebase and send a single patchset if possible.

The problem is that next-crypto is not in sync with next-net.  In
particular it is missing this commit:

7a39d1b common/mvep: add common code for Marvell drivers

Could you rebase/merge next-crypto with next-net to have this commit?

> Also, I believe http://patches.dpdk.org/patch/44254/
> can be squashed with http://patches.dpdk.org/patch/45104/

No problem I can package all patches into one set but as mentioned above
some of them depend on common mvep code introduced already in next-net.

Best regards
Andrzej
Akhil Goyal Sept. 26, 2018, 10:51 a.m. UTC | #3
On 9/26/2018 3:33 PM, Andrzej Ostruszka wrote:
> Hello Akhil
>
> On 25.09.2018 17:24, Akhil Goyal wrote:
>> Hi Andrzej,
> [...]
>> I am not able to cleanly apply your 3 patchsets.
>> http://patches.dpdk.org/user/todo/dpdk/?series=1172
>> http://patches.dpdk.org/user/todo/dpdk/?series=1440
>> http://patches.dpdk.org/user/todo/dpdk/?series=1442
>>
>> Could you please rebase and send a single patchset if possible.
> The problem is that next-crypto is not in sync with next-net.  In
> particular it is missing this commit:
>
> 7a39d1b common/mvep: add common code for Marvell drivers
>
> Could you rebase/merge next-crypto with next-net to have this commit?
If it is dependent on net-next, then I will defer this set to be applied 
next week when the master is in sync with net-next.
>
>> Also, I believe http://patches.dpdk.org/patch/44254/
>> can be squashed with http://patches.dpdk.org/patch/45104/
> No problem I can package all patches into one set but as mentioned above
> some of them depend on common mvep code introduced already in next-net.
No need for now.. I will wait for master to get in sync and then apply 
the dependent patches.
Is there any series which can be applied without any dependency?
And it would be a good practice to mention the dependencies in the cover 
note in future.

-Akhil
Akhil Goyal Oct. 1, 2018, 1:28 p.m. UTC | #4
On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote:
> This patch series introduces following changes:
>
> * Add support for HMAC SHA224, AES ECB and NULL algorithms.
> * Update hash digest sizes to match hardware capabilities.
> * Fix a shared build.
>
> v2:
>    * added Cc: stable@dpdk.org to couple of patches
>    * rephrased the subject/commit msgs
>
> Szymon Sliwa (1):
>    crypto/mvsam: update hash digest sizes
>
> Tomasz Duszynski (5):
>    crypto/mvsam: fix shared library build
>    crypto/mvsam: support for HMAC SHA224
>    crypto/mvsam: support for AES ECB
>    crypto/mvsam: support for crypto/auth NULL algorithms
>    crypto/mvsam: add 3DES ECB to the capabilities list
>
>   drivers/crypto/mvsam/Makefile           |   2 +-
>   drivers/crypto/mvsam/rte_mrvl_pmd.c     |  15 ++++
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++-----
>   3 files changed, 144 insertions(+), 23 deletions(-)
Series applied to dpdk-next-crypto

Thanks