Message ID | 20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B754658EC; Fri, 31 Aug 2018 14:44:01 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E8D1658C6 for <dev@dpdk.org>; Fri, 31 Aug 2018 14:44:00 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180831124359euoutp01ca93f4a6f667309319bd22284af64900~P_LGk8T5k2524625246euoutp01g for <dev@dpdk.org>; Fri, 31 Aug 2018 12:43:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180831124359euoutp01ca93f4a6f667309319bd22284af64900~P_LGk8T5k2524625246euoutp01g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1535719439; bh=ZgHHNLvDuHpv7WRGjQgFo4faglKnuLSuZsJKisyoStE=; h=From:To:Cc:Subject:Date:References:From; b=W2RcRtPWszEswbS2kHXzuolsXUGARcX/CXJvxKizLiwSlY598wMa8wrzssybL1EMO 8/jPlmDZN6cLey5QQdb+MHyXX8Pbp25ZZ1E+HJ0SreNMumTlyFhCcvIIcHCwkk6uNn JRzhC11OgVuevzhdM3J+tcVfZKgjcHxhp7xBPUG4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180831124359eucas1p21e33b1a71115c3cedbf518de5227da51~P_LGH93ve2421124211eucas1p2r; Fri, 31 Aug 2018 12:43:59 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id C9.7F.04294.E08398B5; Fri, 31 Aug 2018 13:43:59 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m; Fri, 31 Aug 2018 12:43:58 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20180831124358eusmtrp225f4aa81c1fbcbb0f7e72611c4308808~P_LFIRdyu2459624596eusmtrp2C; Fri, 31 Aug 2018 12:43:58 +0000 (GMT) X-AuditID: cbfec7f4-c77a99c0000010c6-a4-5b89380e2814 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 3D.DF.04128.E08398B5; Fri, 31 Aug 2018 13:43:58 +0100 (BST) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20180831124357eusmtip25183dad93190da4202802b40686184ff~P_LEhKQgK2135921359eusmtip2f; Fri, 31 Aug 2018 12:43:57 +0000 (GMT) From: Ilya Maximets <i.maximets@samsung.com> To: dev@dpdk.org Cc: Jingjing Wu <jingjing.wu@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Ilya Maximets <i.maximets@samsung.com> Date: Fri, 31 Aug 2018 15:45:15 +0300 X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djPc7r8Fp3RBh9fMFl0f2hhsrixyt7i 3aftTBZX2n+yW8xc8JnR4v2fRSwW0zf0s1lsPfOX0WL/88PsDpwevxYsZfVYvOclk0ffllWM AcxRXDYpqTmZZalF+nYJXBlLV3YwFczkrDjeN4+lgXE3WxcjJ4eEgInE25172bsYuTiEBFYw SqxYeJ8RwvnCKLFv5idmCOczo8TquYcYYVquXr0NVbUcqOpWAxuE8wOoavUZFpAqNgEdiVOr j4B1iAgISHzuXAxWxCxwlEniWtd0ZpCEsICmxMndq9lBbBYBVYlJs7axQ6yQl1i94QDYbgmB 62wSHYunAyU4OHgFyiRapsZA1LhInP6ylhXCFpZ4dXwLVK+MxP+d85kg7HqJ+y0vGSHmdDBK TD/0DyphL7Hl9TmwmcxAR6zfpQ9iSgg4Skz8Uw5h8knceCsIUswMZE7aBnIxSJhXoqNNCGKG isTvg8uZIWwpiZvvPkMd4CHRdm0lOHiFBGIlPj15yjiBUW4WwqoFjIyrGMVTS4tz01OLjfJS y/WKE3OLS/PS9ZLzczcxAlPB6X/Hv+xg3PUn6RCjAAejEg8vw/v2aCHWxLLiytxDjBIczEoi vJwZHdFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEefm00qKFBNITS1KzU1MLUotgskwcnFINjAky 71leVNW3b1oy0/fkJt+r2hobW5bm/mxPmr3256w2uxlb9axP8X8zeyy6qOE/T4fGH9tsxrqP 1i4r+r7oi/r3Rt98YutkpJNxIjDs0RGu5fzeXOvryxzu6Ar8eMtyk+Gkx7oSn7zGq6yGDR+7 Ln66ILeK8fetnR9Uv937nfT20Rp+6eYiTiWW4oxEQy3mouJEAOMKvcUBAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t/xe7p8Fp3RBs3T+Sy6P7QwWdxYZW/x 7tN2Josr7T/ZLWYu+Mxo8f7PIhaL6Rv62Sy2nvnLaLH/+WF2B06PXwuWsnos3vOSyaNvyyrG AOYoPZui/NKSVIWM/OISW6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYyl KzuYCmZyVhzvm8fSwLibrYuRk0NCwETi6tXbjF2MXBxCAksZJXbs6mKHSEhJ/Ph1gRXCFpb4 c62LDaLoG6PE/QuTwIrYBHQkTq0+wghiiwgISHzuXAxWxCxwmkniwNpNzCAJYQFNiZO7V4M1 sAioSkyatQ3I5uDgFbCW2HLcCmKBvMTqDQeYJzDyLGBkWMUoklpanJueW2ykV5yYW1yal66X nJ+7iREYhNuO/dyyg7HrXfAhRgEORiUeXob37dFCrIllxZW5hxglOJiVRHg5MzqihXhTEiur Uovy44tKc1KLDzGaAu2eyCwlmpwPjJC8knhDU0NzC0tDc2NzYzMLJXHe8waVUUIC6Yklqdmp qQWpRTB9TBycUg2M0akRD5M/9pw5avVUsGLP9b8ec3/3On4sSgkL65zkd2ZR36wfYgJLdsUt EhKdJr2cq4xz1ze9JkG/tJgZJ7ZcjfsW7NZyN4FP+nzGF86bc99W3z7Ffmr3rXct/Ks3T3fS OXRPL1xPtOMNz/XsZCeGsqnJqqE7Mu7v097w98XxJQzCx4Jzvx7fqsRSnJFoqMVcVJwIAMSB +kRYAgAA Message-Id: <20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com> X-CMS-MailID: 20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec References: <CGME20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec@eucas1p2.samsung.com> Subject: [dpdk-dev] [RFC 0/2] CPU non-blocking delay X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
CPU non-blocking delay
|
|
Message
Ilya Maximets
Aug. 31, 2018, 12:45 p.m. UTC
Sending as RFC because I failed to force meson to build without deprecation warnings. I tried a lot of different combinations of 'allow_experimental_apis' and '-DALLOW_EXPERIMENTAL_APIS' without success. Any help appreciated. Ilya Maximets (2): eal: add nanosleep based delay function drivers/net: use sleep delay by default for intel NICs drivers/net/avf/Makefile | 1 + drivers/net/avf/base/avf_osdep.h | 4 +- drivers/net/e1000/Makefile | 1 + drivers/net/e1000/base/e1000_osdep.h | 2 +- drivers/net/i40e/base/i40e_osdep.h | 6 +-- drivers/net/ifc/base/ifcvf_osdep.h | 2 +- drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- lib/librte_eal/common/eal_common_timer.c | 19 +++++++ .../common/include/generic/rte_cycles.h | 11 ++++ lib/librte_eal/rte_eal_version.map | 1 + test/test/autotest_data.py | 6 +++ test/test/meson.build | 1 + test/test/test_cycles.c | 51 ++++++++++++++----- 13 files changed, 85 insertions(+), 22 deletions(-)
Comments
On Fri, Aug 31, 2018 at 03:45:15PM +0300, Ilya Maximets wrote: > Sending as RFC because I failed to force meson to > build without deprecation warnings. I tried a lot > of different combinations of 'allow_experimental_apis' > and '-DALLOW_EXPERIMENTAL_APIS' without success. > Any help appreciated. > I'll try and take a look. /Bruce
On Fri, Aug 31, 2018 at 03:45:15PM +0300, Ilya Maximets wrote: > Sending as RFC because I failed to force meson to > build without deprecation warnings. I tried a lot > of different combinations of 'allow_experimental_apis' > and '-DALLOW_EXPERIMENTAL_APIS' without success. > Any help appreciated. > See patch: http://patches.dpdk.org/patch/44129/ Basically, the experimental_apis setting was not getting passed through and used by the base code libraries when set at the higher level, since they were being built individually by the respective base/meson.build files, rather than by the main driver build loop. Putting in an explicit check for the value in the base code files should make your life easier here. You just need to ensure that the "allow_experimental_apis" setting is set *before* the call to "subdir(base)" e.g. in ixgbe, it's currently after and needs to be moved by your patchset. Regards, /Bruce PS: I also notice that i40e is using the experimental APIs cflags directly, rather than the variable, I'll have to fix that in a later patch.
On 31.08.2018 16:39, Bruce Richardson wrote: > On Fri, Aug 31, 2018 at 03:45:15PM +0300, Ilya Maximets wrote: >> Sending as RFC because I failed to force meson to >> build without deprecation warnings. I tried a lot >> of different combinations of 'allow_experimental_apis' >> and '-DALLOW_EXPERIMENTAL_APIS' without success. >> Any help appreciated. >> > > See patch: http://patches.dpdk.org/patch/44129/ > > Basically, the experimental_apis setting was not getting passed through and > used by the base code libraries when set at the higher level, since they > were being built individually by the respective base/meson.build files, > rather than by the main driver build loop. Putting in an explicit check for > the value in the base code files should make your life easier here. You > just need to ensure that the "allow_experimental_apis" setting is set > *before* the call to "subdir(base)" e.g. in ixgbe, it's currently after and > needs to be moved by your patchset. Thanks. It works. Best regards, Ilya Maximets. > > Regards, > /Bruce > > PS: I also notice that i40e is using the experimental APIs cflags directly, > rather than the variable, I'll have to fix that in a later patch. > >