[v2,0/5] L2fwd-crypto fixes
mbox series

Message ID 20180719083959.41480-1-pablo.de.lara.guarch@intel.com
Headers show
Series
  • L2fwd-crypto fixes
Related show

Message

De Lara Guarch, Pablo July 19, 2018, 8:39 a.m. UTC
v2 changes:
- Split patch into multiple patches for better review
- First two patches are fixes for previous releases

Pablo de Lara (5):
  examples/l2fwd-crypto: check return value on IV size check
  examples/l2fwd-crypto: skip device not supporting operation
  examples/l2fwd-crypto: separate IV check from xform setting
  examples/l2fwd-crypto: fix session mempool size
  examples/l2fwd-crypto: remove duplicated capability check

 examples/l2fwd-crypto/main.c | 539 +++++++++++++++++++++++++++----------------
 1 file changed, 340 insertions(+), 199 deletions(-)

Comments

Trahe, Fiona July 20, 2018, 9:01 a.m. UTC | #1
Hi Pablo,

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, July 19, 2018 9:40 AM
> To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2 0/5] L2fwd-crypto fixes
> 
> v2 changes:
> - Split patch into multiple patches for better review
> - First two patches are fixes for previous releases
> 
> Pablo de Lara (5):
>   examples/l2fwd-crypto: check return value on IV size check
>   examples/l2fwd-crypto: skip device not supporting operation
>   examples/l2fwd-crypto: separate IV check from xform setting
>   examples/l2fwd-crypto: fix session mempool size
>   examples/l2fwd-crypto: remove duplicated capability check
> 
>  examples/l2fwd-crypto/main.c | 539 +++++++++++++++++++++++++++----------------
>  1 file changed, 340 insertions(+), 199 deletions(-)
> 
> --
> 2.14.4
One minor comment in patch 4, apart from that 
Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>
De Lara Guarch, Pablo July 20, 2018, 10:41 a.m. UTC | #2
Hi Fiona,

> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, July 20, 2018 10:02 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH v2 0/5] L2fwd-crypto fixes
> 
> Hi Pablo,
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Thursday, July 19, 2018 9:40 AM
> > To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH v2 0/5] L2fwd-crypto fixes
> >
> > v2 changes:
> > - Split patch into multiple patches for better review
> > - First two patches are fixes for previous releases
> >
> > Pablo de Lara (5):
> >   examples/l2fwd-crypto: check return value on IV size check
> >   examples/l2fwd-crypto: skip device not supporting operation
> >   examples/l2fwd-crypto: separate IV check from xform setting
> >   examples/l2fwd-crypto: fix session mempool size
> >   examples/l2fwd-crypto: remove duplicated capability check
> >
> >  examples/l2fwd-crypto/main.c | 539 +++++++++++++++++++++++++++---------
> -------
> >  1 file changed, 340 insertions(+), 199 deletions(-)
> >
> > --
> > 2.14.4
> One minor comment in patch 4, apart from that
> Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>

Thanks for the review. I will make that change on the fly when applying the patchset,
as it is a minor change, to avoid spam.
De Lara Guarch, Pablo July 20, 2018, 10:45 a.m. UTC | #3
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Friday, July 20, 2018 11:41 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/5] L2fwd-crypto fixes
> 
> Hi Fiona,
> 
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, July 20, 2018 10:02 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> > Declan <declan.doherty@intel.com>
> > Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> > Subject: RE: [PATCH v2 0/5] L2fwd-crypto fixes
> >
> > Hi Pablo,
> >
> > > -----Original Message-----
> > > From: De Lara Guarch, Pablo
> > > Sent: Thursday, July 19, 2018 9:40 AM
> > > To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>
> > > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > > <pablo.de.lara.guarch@intel.com>
> > > Subject: [PATCH v2 0/5] L2fwd-crypto fixes
> > >
> > > v2 changes:
> > > - Split patch into multiple patches for better review
> > > - First two patches are fixes for previous releases
> > >
> > > Pablo de Lara (5):
> > >   examples/l2fwd-crypto: check return value on IV size check
> > >   examples/l2fwd-crypto: skip device not supporting operation
> > >   examples/l2fwd-crypto: separate IV check from xform setting
> > >   examples/l2fwd-crypto: fix session mempool size
> > >   examples/l2fwd-crypto: remove duplicated capability check
> > >
> > >  examples/l2fwd-crypto/main.c | 539
> > > +++++++++++++++++++++++++++---------
> > -------
> > >  1 file changed, 340 insertions(+), 199 deletions(-)
> > >
> > > --
> > > 2.14.4
> > One minor comment in patch 4, apart from that
> > Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> Thanks for the review. I will make that change on the fly when applying the
> patchset, as it is a minor change, to avoid spam.

Series applied to dpdk-next-crypto, with change requested.

Pablo