[v5,00/10] Make unit tests great again
mbox series

Message ID 1531843225-14638-1-git-send-email-reshma.pattan@intel.com
Headers show
Series
  • Make unit tests great again
Related show

Message

Reshma Pattan July 17, 2018, 4 p.m. UTC
Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script.

In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memory at runtime as needed. This has the implication that the old test grouping can now be retired and replaced with a more sensible way of running unit tests (using multiprocessing pool of workers and a queue of tests). This patchset accomplishes exactly that.

This patchset merges changes done in [1], [2]

[1] http://dpdk.org/dev/patchwork/patch/40370/
[2] http://patches.dpdk.org/patch/40373/

Removed unused and duplicate make rules for test-basic,
test-mempool, test-ring from make file system in patch 10/10.

v4: Removed unused and duplicate make rules for test-basic,
test-mempool, test-ring from make file system in patch 10/10.

Reshma Pattan (10):
  autotest: fix printing
  autotest: fix invalid code on reports
  autotest: make autotest runner python 2/3 compliant
  autotest: visually separate different test categories
  autotest: improve filtering
  autotest: remove autotest grouping
  autotest: properly parallelize unit tests
  autotest: update autotest test case list
  mk: update make targets for classified testcases
  mk: remove unnecessary make rules of test

 mk/rte.sdkroot.mk            |    4 +-
 mk/rte.sdktest.mk            |   32 +-
 test/test/autotest.py        |   13 +-
 test/test/autotest_data.py   | 1081 +++++++++++++++++++++++++-----------------
 test/test/autotest_runner.py |  519 ++++++++++----------
 5 files changed, 947 insertions(+), 702 deletions(-)

Comments

Thomas Monjalon July 26, 2018, 8:04 p.m. UTC | #1
17/07/2018 18:00, Reshma Pattan:
> Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script.
> 
> In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memory at runtime as needed. This has the implication that the old test grouping can now be retired and replaced with a more sensible way of running unit tests (using multiprocessing pool of workers and a queue of tests). This patchset accomplishes exactly that.
> 
> This patchset merges changes done in [1], [2]
> 
> [1] http://dpdk.org/dev/patchwork/patch/40370/
> [2] http://patches.dpdk.org/patch/40373/
> 
> Removed unused and duplicate make rules for test-basic,
> test-mempool, test-ring from make file system in patch 10/10.
> 
> v4: Removed unused and duplicate make rules for test-basic,
> test-mempool, test-ring from make file system in patch 10/10.
> 
> Reshma Pattan (10):
>   autotest: fix printing
>   autotest: fix invalid code on reports
>   autotest: make autotest runner python 2/3 compliant
>   autotest: visually separate different test categories
>   autotest: improve filtering
>   autotest: remove autotest grouping
>   autotest: properly parallelize unit tests
>   autotest: update autotest test case list
>   mk: update make targets for classified testcases
>   mk: remove unnecessary make rules of test

Patches 1 to 7 are from Anatoly.
Patches 8 and 9 were initiated by Jananee.

Please fix authorship of these patches.
Note: it should not happen if you use git-am to get the patches.
Reshma Pattan July 27, 2018, 8:36 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, July 26, 2018 9:05 PM
> To: Pattan, Reshma <reshma.pattan@intel.com>
> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
> 
> 17/07/2018 18:00, Reshma Pattan:
> > Previously, unit tests were running in groups. There were technical reasons
> why that was the case (mostly having to do with limiting memory), but it was
> hard to maintain and update the autotest script.
> >
> > In 18.05, limiting of memory at DPDK startup was no longer necessary, as
> DPDK allocates memory at runtime as needed. This has the implication that
> the old test grouping can now be retired and replaced with a more sensible
> way of running unit tests (using multiprocessing pool of workers and a queue
> of tests). This patchset accomplishes exactly that.
> >
> > This patchset merges changes done in [1], [2]
> >
> > [1] http://dpdk.org/dev/patchwork/patch/40370/
> > [2] http://patches.dpdk.org/patch/40373/
> >
> > Removed unused and duplicate make rules for test-basic, test-mempool,
> > test-ring from make file system in patch 10/10.
> >
> > v4: Removed unused and duplicate make rules for test-basic,
> > test-mempool, test-ring from make file system in patch 10/10.
> >
> > Reshma Pattan (10):
> >   autotest: fix printing
> >   autotest: fix invalid code on reports
> >   autotest: make autotest runner python 2/3 compliant
> >   autotest: visually separate different test categories
> >   autotest: improve filtering
> >   autotest: remove autotest grouping
> >   autotest: properly parallelize unit tests
> >   autotest: update autotest test case list
> >   mk: update make targets for classified testcases
> >   mk: remove unnecessary make rules of test
> 
> Patches 1 to 7 are from Anatoly.
> Patches 8 and 9 were initiated by Jananee.

The respective patches have i.e 1 to 7 have Anatolys Signed--off
And 8 and 9 have Jananees Signed-off along with mine. 

I have used git-am. What I am missing here?

Thanks,
Reshma
Burakov, Anatoly July 27, 2018, 8:51 a.m. UTC | #3
On 27-Jul-18 9:36 AM, Pattan, Reshma wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> Sent: Thursday, July 26, 2018 9:05 PM
>> To: Pattan, Reshma <reshma.pattan@intel.com>
>> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
>> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
>>
>> 17/07/2018 18:00, Reshma Pattan:
>>> Previously, unit tests were running in groups. There were technical reasons
>> why that was the case (mostly having to do with limiting memory), but it was
>> hard to maintain and update the autotest script.
>>>
>>> In 18.05, limiting of memory at DPDK startup was no longer necessary, as
>> DPDK allocates memory at runtime as needed. This has the implication that
>> the old test grouping can now be retired and replaced with a more sensible
>> way of running unit tests (using multiprocessing pool of workers and a queue
>> of tests). This patchset accomplishes exactly that.
>>>
>>> This patchset merges changes done in [1], [2]
>>>
>>> [1] http://dpdk.org/dev/patchwork/patch/40370/
>>> [2] http://patches.dpdk.org/patch/40373/
>>>
>>> Removed unused and duplicate make rules for test-basic, test-mempool,
>>> test-ring from make file system in patch 10/10.
>>>
>>> v4: Removed unused and duplicate make rules for test-basic,
>>> test-mempool, test-ring from make file system in patch 10/10.
>>>
>>> Reshma Pattan (10):
>>>    autotest: fix printing
>>>    autotest: fix invalid code on reports
>>>    autotest: make autotest runner python 2/3 compliant
>>>    autotest: visually separate different test categories
>>>    autotest: improve filtering
>>>    autotest: remove autotest grouping
>>>    autotest: properly parallelize unit tests
>>>    autotest: update autotest test case list
>>>    mk: update make targets for classified testcases
>>>    mk: remove unnecessary make rules of test
>>
>> Patches 1 to 7 are from Anatoly.
>> Patches 8 and 9 were initiated by Jananee.
> 
> The respective patches have i.e 1 to 7 have Anatolys Signed--off
> And 8 and 9 have Jananees Signed-off along with mine.
> 
> I have used git-am. What I am missing here?
> 
> Thanks,
> Reshma
> 

The signoff is part of commit message, but the author name is part of 
commit metadata. I.e. as it stands, if these patches are applied, the 
commit message says i am the author, but the actual commit metadata says 
it's you.

Use "git show --pretty=fuller" to see who is the author and who is the 
committer of each commit. To fix each commit, do an interactive rebase, 
stop after each commit (i.e. mark each commit as "edit") and do

git commit --amend --author="Author Name <email@address.com>"

(this is a brute force way - a "smarter" way would be to use git 
filter-branch, but IMO it's overkill unless you do that often and 
already have all necessary scripts ready and set up :) )
Reshma Pattan July 27, 2018, 10:12 a.m. UTC | #4
Hi,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, July 26, 2018 9:05 PM
> To: Pattan, Reshma <reshma.pattan@intel.com>
> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
> > Reshma Pattan (10):
> >   autotest: fix printing
> >   autotest: fix invalid code on reports
> >   autotest: make autotest runner python 2/3 compliant
> >   autotest: visually separate different test categories
> >   autotest: improve filtering
> >   autotest: remove autotest grouping
> >   autotest: properly parallelize unit tests
> >   autotest: update autotest test case list
> >   mk: update make targets for classified testcases
> >   mk: remove unnecessary make rules of test
> 
> Patches 1 to 7 are from Anatoly.
> Patches 8 and 9 were initiated by Jananee.
> 
> Please fix authorship of these patches.
> Note: it should not happen if you use git-am to get the patches.
> 

Addressed in v6 and sent.

Thanks,
Reshma