[0/3] deprecate attach and detach functions
mbox series

Message ID 1531318450-3942-1-git-send-email-arybchenko@solarflare.com
Headers show
Series
  • deprecate attach and detach functions
Related show

Message

Andrew Rybchenko July 11, 2018, 2:14 p.m. UTC
As discussed in [1] EAL hotplug should be used directly to add/remove devices.

app/pdump changes are build-tested only.

[1] http://mails.dpdk.org/archives/dev/2018-July/107507.html

Andrew Rybchenko (3):
  app/pdump: use hotplug add instead of attach
  ethdev: deprecate attach and detach functions
  eal: deprecate device attach and detach functions

 app/pdump/main.c                        | 94 ++++++++++++++++++-------
 app/test-pmd/Makefile                   |  1 +
 app/test-pmd/meson.build                |  1 +
 doc/guides/rel_notes/deprecation.rst    | 12 ++++
 lib/librte_eal/common/include/rte_dev.h |  2 +
 lib/librte_ethdev/rte_ethdev.h          |  2 +
 6 files changed, 88 insertions(+), 24 deletions(-)

Comments

Thomas Monjalon July 26, 2018, 9:32 p.m. UTC | #1
11/07/2018 16:14, Andrew Rybchenko:
> As discussed in [1] EAL hotplug should be used directly to add/remove devices.
> 
> app/pdump changes are build-tested only.
> 
> [1] http://mails.dpdk.org/archives/dev/2018-July/107507.html
> 
> Andrew Rybchenko (3):
>   app/pdump: use hotplug add instead of attach
>   ethdev: deprecate attach and detach functions
>   eal: deprecate device attach and detach functions

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Stephen Hemminger Aug. 1, 2018, 4:26 p.m. UTC | #2
On Wed, 11 Jul 2018 15:14:07 +0100
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> As discussed in [1] EAL hotplug should be used directly to add/remove devices.
> 
> app/pdump changes are build-tested only.
> 
> [1] http://mails.dpdk.org/archives/dev/2018-July/107507.html
> 
> Andrew Rybchenko (3):
>   app/pdump: use hotplug add instead of attach
>   ethdev: deprecate attach and detach functions
>   eal: deprecate device attach and detach functions
> 
>  app/pdump/main.c                        | 94 ++++++++++++++++++-------
>  app/test-pmd/Makefile                   |  1 +
>  app/test-pmd/meson.build                |  1 +
>  doc/guides/rel_notes/deprecation.rst    | 12 ++++
>  lib/librte_eal/common/include/rte_dev.h |  2 +
>  lib/librte_ethdev/rte_ethdev.h          |  2 +
>  6 files changed, 88 insertions(+), 24 deletions(-)
> 

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Thomas Monjalon Aug. 5, 2018, 11:10 p.m. UTC | #3
01/08/2018 18:26, Stephen Hemminger:
> On Wed, 11 Jul 2018 15:14:07 +0100
> Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> 
> > As discussed in [1] EAL hotplug should be used directly to add/remove devices.
> > 
> > app/pdump changes are build-tested only.
> > 
> > [1] http://mails.dpdk.org/archives/dev/2018-July/107507.html
> > 
> > Andrew Rybchenko (3):
> >   app/pdump: use hotplug add instead of attach
> >   ethdev: deprecate attach and detach functions
> >   eal: deprecate device attach and detach functions
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

There are only 2 acks, probably because everybody is on holidays,
but there is no comment after more than 3 weeks.
I don't want to apply the code change in pdump app after -rc3,
so it is applied in 18.08-rc3.
Thanks