[v2,0/4] add head/tailroom requirement for crypto PMDs
mbox series

Message ID 1531233760-4929-1-git-send-email-anoob.joseph@caviumnetworks.com
Headers show
Series
  • add head/tailroom requirement for crypto PMDs
Related show

Message

Anoob Joseph July 10, 2018, 2:42 p.m. UTC
This series adds the ability, for crypto PMDs, to communicate the
minimum head/tailroom requirement it may have, using the existing
cryptodev_info framework.

The availability and use of head/tailroom is an optimisation if the
hardware supports its use for crypto-op info. Devices that do not
support using the head/tailroom, can continue to operate without
any performance-drop.

Cavium's OcteonTX crypto hardware supports this feature and would use
headroom and tailroom for submitting crypto-ops to the hardware.

v2:
* Added corresponding change in scheduler PMD

v1:
* Removed deprecation notice and updated release notes
* Added corresponding change in test-cryptodev

Anoob Joseph (4):
  cryptodev: add min headroom and tailroom requirement
  app/crypto-perf: honour cryptodev's min headroom/tailroom
  test/crypto: skip validation of head/tailroom used by PMD
  crypto/scheduler: add minimum head/tailroom requirement

 app/test-crypto-perf/cperf_options.h         |  2 +
 app/test-crypto-perf/cperf_test_common.c     | 33 ++++++++++-----
 app/test-crypto-perf/main.c                  | 17 ++++++++
 doc/guides/rel_notes/release_18_08.rst       |  6 +++
 drivers/crypto/scheduler/scheduler_pmd_ops.c | 16 ++++++++
 lib/librte_cryptodev/rte_cryptodev.h         |  6 +++
 test/test/test_cryptodev_blockcipher.c       | 60 +++++++++++++++++++++++++---
 7 files changed, 123 insertions(+), 17 deletions(-)

Comments

Pablo de Lara July 10, 2018, 5:20 p.m. UTC | #1
> -----Original Message-----
> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
> Sent: Tuesday, July 10, 2018 3:43 PM
> To: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoob.joseph@caviumnetworks.com>; Akhil Goyal
> <akhil.goyal@nxp.com>; Ankur Dwivedi
> <ankur.dwivedi@caviumnetworks.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; dev@dpdk.org
> Subject: [PATCH v2 0/4] add head/tailroom requirement for crypto PMDs
> 
> This series adds the ability, for crypto PMDs, to communicate the minimum
> head/tailroom requirement it may have, using the existing cryptodev_info
> framework.
> 
> The availability and use of head/tailroom is an optimisation if the hardware
> supports its use for crypto-op info. Devices that do not support using the
> head/tailroom, can continue to operate without any performance-drop.
> 
> Cavium's OcteonTX crypto hardware supports this feature and would use
> headroom and tailroom for submitting crypto-ops to the hardware.
> 

Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Pablo de Lara July 10, 2018, 5:29 p.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Tuesday, July 10, 2018 6:21 PM
> To: Anoob Joseph <anoob.joseph@caviumnetworks.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; Ankur Dwivedi
> <ankur.dwivedi@caviumnetworks.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/4] add head/tailroom requirement for
> crypto PMDs
> 
> 
> 
> > -----Original Message-----
> > From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
> > Sent: Tuesday, July 10, 2018 3:43 PM
> > To: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Cc: Anoob Joseph <anoob.joseph@caviumnetworks.com>; Akhil Goyal
> > <akhil.goyal@nxp.com>; Ankur Dwivedi
> > <ankur.dwivedi@caviumnetworks.com>; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>; Narayana Prasad
> > <narayanaprasad.athreya@caviumnetworks.com>; dev@dpdk.org
> > Subject: [PATCH v2 0/4] add head/tailroom requirement for crypto PMDs
> >
> > This series adds the ability, for crypto PMDs, to communicate the
> > minimum head/tailroom requirement it may have, using the existing
> > cryptodev_info framework.
> >
> > The availability and use of head/tailroom is an optimisation if the
> > hardware supports its use for crypto-op info. Devices that do not
> > support using the head/tailroom, can continue to operate without any
> performance-drop.
> >
> > Cavium's OcteonTX crypto hardware supports this feature and would use
> > headroom and tailroom for submitting crypto-ops to the hardware.
> >
> 
> Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Series applied to dpdk-next-crypto.
Thanks,

Pablo