[v9,00/15] Vhost: add support to packed ring layout
mbox series

Message ID 20180706070722.2043-1-maxime.coquelin@redhat.com
Headers show
Series
  • Vhost: add support to packed ring layout
Related show

Message

Maxime Coquelin July 6, 2018, 7:07 a.m. UTC
This series is a handover from Jen's "[PATCH v4 00/20]
implement packed virtqueues", which only implements the
vhost side. Virtio PMD implementation will follow in a 
next series.

The series applies on top of previous reworks I posted
during this cycle that merges mergeable and non-mergeable
receive paths, and refactors transmit path to re-use
vector buffers.

I haven't run performance tests for now as the Virtio PMD
side isn't ready.

The series has been tested with Tiwei's series implementing
packed ring support to Kernel's virtio-net driver, and
with Wei series implementing the Qemu side.

To test it, I have used testpmd on host side with a vhost
vdev and a tap vdev forwarding to each other. Transferts
of big random files have been done in both ways with
integrity verified.

Tests have been run with Rx mrg ON/OFF and events suppression
ON/OFF.

Tests have also been run with legacy split ring layout to
ensure no regression have been introduced.

Changes since v8:
=================
- Fix indents (Tiwei)
- Rename struct vring_desc_packed to vring_packed_desc (Tiwei)

Changes since v7:
=================
- Align structs and defines naming with Kernel header (Tiwei)
- Fix event based notifications (Tiwei)
- Fix Clang build issues caused by unused symbols (Tiwei)

Changes since v6:
=================
- Various style cleanups (Tiwei, Jason)
- Simplify event based notification (Jason)
- Build support with future kernels (Tiwei)
- Prevent buffer vectors overflow in map_one_desc (Tiwei)

Changes since v5:
=================
- Remove duplicated VHOST_USER_F_PROTOCOL_FEATURES definition (Tiwei)
- Fix vq_is_ready (Maxime)
- Fix local used index overflow in flush_shadow_used_ring_packed (Tiwei)
- Make desc_is_avail() a bool (Tiwei)
- Improve desc_is_avail() logic (Tiwei)
- Remove split rings addr NULL assignment in the right patch (Tiwei)
- Make buffer id a uint16_t (Tiwei)

Jens Freimann (2):
  vhost: add virtio packed virtqueue defines
  vhost: add helpers for packed virtqueues

Maxime Coquelin (12):
  vhost: clear shadow used table index at flush time
  vhost: make indirect desc table copy desc type agnostic
  vhost: clear batch copy index at copy time
  vhost: extract split ring handling from Rx and Tx functions
  vhost: append shadow used ring function names with split
  vhost: add shadow used ring support for packed rings
  vhost: create descriptor mapping function
  vhost: add vector filling support for packed ring
  vhost: add Rx support for packed ring
  vhost: add Tx support for packed ring
  vhost: add notification for packed ring
  vhost: advertize packed ring layout support

Yuanhan Liu (1):
  vhost: vring address setup for packed queues

 lib/librte_vhost/vhost.c      | 115 ++++++-
 lib/librte_vhost/vhost.h      | 130 ++++++-
 lib/librte_vhost/vhost_user.c | 127 +++++--
 lib/librte_vhost/virtio_net.c | 776 +++++++++++++++++++++++++++++++++---------
 4 files changed, 939 insertions(+), 209 deletions(-)

Comments

Tiwei Bie July 9, 2018, 1:28 a.m. UTC | #1
On Fri, Jul 06, 2018 at 09:07:07AM +0200, Maxime Coquelin wrote:
> This series is a handover from Jen's "[PATCH v4 00/20]
> implement packed virtqueues", which only implements the
> vhost side. Virtio PMD implementation will follow in a 
> next series.
> 
> The series applies on top of previous reworks I posted
> during this cycle that merges mergeable and non-mergeable
> receive paths, and refactors transmit path to re-use
> vector buffers.
> 
> I haven't run performance tests for now as the Virtio PMD
> side isn't ready.
> 
> The series has been tested with Tiwei's series implementing
> packed ring support to Kernel's virtio-net driver, and
> with Wei series implementing the Qemu side.
> 
> To test it, I have used testpmd on host side with a vhost
> vdev and a tap vdev forwarding to each other. Transferts
> of big random files have been done in both ways with
> integrity verified.
> 
> Tests have been run with Rx mrg ON/OFF and events suppression
> ON/OFF.
> 
> Tests have also been run with legacy split ring layout to
> ensure no regression have been introduced.
> 
> Changes since v8:
> =================
> - Fix indents (Tiwei)
> - Rename struct vring_desc_packed to vring_packed_desc (Tiwei)
> 
> Changes since v7:
> =================
> - Align structs and defines naming with Kernel header (Tiwei)
> - Fix event based notifications (Tiwei)
> - Fix Clang build issues caused by unused symbols (Tiwei)
> 
> Changes since v6:
> =================
> - Various style cleanups (Tiwei, Jason)
> - Simplify event based notification (Jason)
> - Build support with future kernels (Tiwei)
> - Prevent buffer vectors overflow in map_one_desc (Tiwei)
> 
> Changes since v5:
> =================
> - Remove duplicated VHOST_USER_F_PROTOCOL_FEATURES definition (Tiwei)
> - Fix vq_is_ready (Maxime)
> - Fix local used index overflow in flush_shadow_used_ring_packed (Tiwei)
> - Make desc_is_avail() a bool (Tiwei)
> - Improve desc_is_avail() logic (Tiwei)
> - Remove split rings addr NULL assignment in the right patch (Tiwei)
> - Make buffer id a uint16_t (Tiwei)
> 
> Jens Freimann (2):
>   vhost: add virtio packed virtqueue defines
>   vhost: add helpers for packed virtqueues
> 
> Maxime Coquelin (12):
>   vhost: clear shadow used table index at flush time
>   vhost: make indirect desc table copy desc type agnostic
>   vhost: clear batch copy index at copy time
>   vhost: extract split ring handling from Rx and Tx functions
>   vhost: append shadow used ring function names with split
>   vhost: add shadow used ring support for packed rings
>   vhost: create descriptor mapping function
>   vhost: add vector filling support for packed ring
>   vhost: add Rx support for packed ring
>   vhost: add Tx support for packed ring
>   vhost: add notification for packed ring
>   vhost: advertize packed ring layout support
> 
> Yuanhan Liu (1):
>   vhost: vring address setup for packed queues
> 
>  lib/librte_vhost/vhost.c      | 115 ++++++-
>  lib/librte_vhost/vhost.h      | 130 ++++++-
>  lib/librte_vhost/vhost_user.c | 127 +++++--
>  lib/librte_vhost/virtio_net.c | 776 +++++++++++++++++++++++++++++++++---------
>  4 files changed, 939 insertions(+), 209 deletions(-)
> 
> -- 
> 2.14.4
> 

For the series:
Acked-by: Tiwei Bie <tiwei.bie@intel.com>
Tiwei Bie July 9, 2018, 7:04 a.m. UTC | #2
On Fri, Jul 06, 2018 at 09:07:07AM +0200, Maxime Coquelin wrote:
> This series is a handover from Jen's "[PATCH v4 00/20]
> implement packed virtqueues", which only implements the
> vhost side. Virtio PMD implementation will follow in a 
> next series.
> 
> The series applies on top of previous reworks I posted
> during this cycle that merges mergeable and non-mergeable
> receive paths, and refactors transmit path to re-use
> vector buffers.
> 
> I haven't run performance tests for now as the Virtio PMD
> side isn't ready.
> 
> The series has been tested with Tiwei's series implementing
> packed ring support to Kernel's virtio-net driver, and
> with Wei series implementing the Qemu side.
> 
> To test it, I have used testpmd on host side with a vhost
> vdev and a tap vdev forwarding to each other. Transferts
> of big random files have been done in both ways with
> integrity verified.
> 
> Tests have been run with Rx mrg ON/OFF and events suppression
> ON/OFF.
> 
> Tests have also been run with legacy split ring layout to
> ensure no regression have been introduced.
> 
> Changes since v8:
> =================
> - Fix indents (Tiwei)
> - Rename struct vring_desc_packed to vring_packed_desc (Tiwei)
> 
> Changes since v7:
> =================
> - Align structs and defines naming with Kernel header (Tiwei)
> - Fix event based notifications (Tiwei)
> - Fix Clang build issues caused by unused symbols (Tiwei)
> 
> Changes since v6:
> =================
> - Various style cleanups (Tiwei, Jason)
> - Simplify event based notification (Jason)
> - Build support with future kernels (Tiwei)
> - Prevent buffer vectors overflow in map_one_desc (Tiwei)
> 
> Changes since v5:
> =================
> - Remove duplicated VHOST_USER_F_PROTOCOL_FEATURES definition (Tiwei)
> - Fix vq_is_ready (Maxime)
> - Fix local used index overflow in flush_shadow_used_ring_packed (Tiwei)
> - Make desc_is_avail() a bool (Tiwei)
> - Improve desc_is_avail() logic (Tiwei)
> - Remove split rings addr NULL assignment in the right patch (Tiwei)
> - Make buffer id a uint16_t (Tiwei)
> 
> Jens Freimann (2):
>   vhost: add virtio packed virtqueue defines
>   vhost: add helpers for packed virtqueues
> 
> Maxime Coquelin (12):
>   vhost: clear shadow used table index at flush time
>   vhost: make indirect desc table copy desc type agnostic
>   vhost: clear batch copy index at copy time
>   vhost: extract split ring handling from Rx and Tx functions
>   vhost: append shadow used ring function names with split
>   vhost: add shadow used ring support for packed rings
>   vhost: create descriptor mapping function
>   vhost: add vector filling support for packed ring
>   vhost: add Rx support for packed ring
>   vhost: add Tx support for packed ring
>   vhost: add notification for packed ring
>   vhost: advertize packed ring layout support
> 
> Yuanhan Liu (1):
>   vhost: vring address setup for packed queues
> 
>  lib/librte_vhost/vhost.c      | 115 ++++++-
>  lib/librte_vhost/vhost.h      | 130 ++++++-
>  lib/librte_vhost/vhost_user.c | 127 +++++--
>  lib/librte_vhost/virtio_net.c | 776 +++++++++++++++++++++++++++++++++---------
>  4 files changed, 939 insertions(+), 209 deletions(-)
> 
> -- 
> 2.14.4
> 

Applied to dpdk-next-virtio/master, thanks.