[v4,0/4] net/virtio: Tx simple path removal and offload improvements
mbox series

Message ID 20180702152547.31423-1-maxime.coquelin@redhat.com
Headers show
Series
  • net/virtio: Tx simple path removal and offload improvements
Related show

Message

Maxime Coquelin July 2, 2018, 3:25 p.m. UTC
In this v3, the main change is the removal of the Tx simple path.
Indeed, this path is not compliant with the Virtio specification,
so could cause problems with some host implementations.

Since Marvin has introduced the in-order path, we have a good
replacement for simple Tx and so we think it is better to
remove it than disabling it by defaul

Maxime Coquelin (4):
  net/virtio: remove simple Tx path
  net/virtio: improve Tx offload features negotiation
  net/virtio: don't use simple Rx if TCP LRO or VLAN strip
  net/virtio: improve offload check performance

 drivers/net/virtio/virtio_ethdev.c      | 49 ++++++++++++++++------
 drivers/net/virtio/virtio_ethdev.h      |  3 --
 drivers/net/virtio/virtio_pci.h         |  4 +-
 drivers/net/virtio/virtio_rxtx.c        | 74 ++++++---------------------------
 drivers/net/virtio/virtio_rxtx_simple.c | 67 -----------------------------
 drivers/net/virtio/virtio_rxtx_simple.h | 49 ----------------------
 drivers/net/virtio/virtio_user_ethdev.c |  1 -
 7 files changed, 51 insertions(+), 196 deletions(-)

Comments

Tiwei Bie July 3, 2018, 2:49 a.m. UTC | #1
On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote:
> In this v3, the main change is the removal of the Tx simple path.
> Indeed, this path is not compliant with the Virtio specification,
> so could cause problems with some host implementations.
> 
> Since Marvin has introduced the in-order path, we have a good
> replacement for simple Tx and so we think it is better to
> remove it than disabling it by defaul
> 
> Maxime Coquelin (4):
>   net/virtio: remove simple Tx path
>   net/virtio: improve Tx offload features negotiation
>   net/virtio: don't use simple Rx if TCP LRO or VLAN strip
>   net/virtio: improve offload check performance
> 
>  drivers/net/virtio/virtio_ethdev.c      | 49 ++++++++++++++++------
>  drivers/net/virtio/virtio_ethdev.h      |  3 --
>  drivers/net/virtio/virtio_pci.h         |  4 +-
>  drivers/net/virtio/virtio_rxtx.c        | 74 ++++++---------------------------
>  drivers/net/virtio/virtio_rxtx_simple.c | 67 -----------------------------
>  drivers/net/virtio/virtio_rxtx_simple.h | 49 ----------------------
>  drivers/net/virtio/virtio_user_ethdev.c |  1 -
>  7 files changed, 51 insertions(+), 196 deletions(-)
> 
> -- 
> 2.14.4
> 

For the series:
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks!
Tiwei Bie July 4, 2018, 5:17 a.m. UTC | #2
On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote:
> In this v3, the main change is the removal of the Tx simple path.
> Indeed, this path is not compliant with the Virtio specification,
> so could cause problems with some host implementations.
> 
> Since Marvin has introduced the in-order path, we have a good
> replacement for simple Tx and so we think it is better to
> remove it than disabling it by defaul
> 
> Maxime Coquelin (4):
>   net/virtio: remove simple Tx path
>   net/virtio: improve Tx offload features negotiation
>   net/virtio: don't use simple Rx if TCP LRO or VLAN strip
>   net/virtio: improve offload check performance
> 
>  drivers/net/virtio/virtio_ethdev.c      | 49 ++++++++++++++++------
>  drivers/net/virtio/virtio_ethdev.h      |  3 --
>  drivers/net/virtio/virtio_pci.h         |  4 +-
>  drivers/net/virtio/virtio_rxtx.c        | 74 ++++++---------------------------
>  drivers/net/virtio/virtio_rxtx_simple.c | 67 -----------------------------
>  drivers/net/virtio/virtio_rxtx_simple.h | 49 ----------------------
>  drivers/net/virtio/virtio_user_ethdev.c |  1 -
>  7 files changed, 51 insertions(+), 196 deletions(-)
> 

Applied to dpdk-next-virtio/master, thanks.