[00/31] bnxt patchset
mbox series

Message ID 20180619213058.12273-1-ajit.khaparde@broadcom.com
Headers show
Series
  • bnxt patchset
Related show

Message

Ajit Khaparde June 19, 2018, 9:30 p.m. UTC
Patchset against dpdk-next-net contains bug fixes,
some code refactoring and style cleanup.

Please apply.

Ajit Khaparde (15):
  net/bnxt: fix clear port stats
  net/bnxt: add Tx batching support
  net/bnxt: Rx processing optimization
  net/bnxt: set min and max descriptor count for Tx and Rx rings
  net/bnxt: fix dev close operation
  net/bnxt: set ring coalesce parameters for Stratus NIC
  net/bnxt: fix HW Tx checksum offload check
  net/bnxt: add support for VF id 0xd800
  net/bnxt: fix rx/tx queue start/stop operations
  net/bnxt: code cleanup style of bnxt vnic
  net/bnxt: filter/flow refactoring
  net/bnxt: check filter type before clearing it
  net/bnxt: fix set MTU
  net/bnxt: fix incorrect IO address handling in Tx
  net/bnxt: allocate RSS context only if RSS mode is enabled.

Jay Ding (1):
  net/bnxt: check for invalid vnic id

Rob Miller (1):
  net/bnxt: update HWRM API to v1.9.2.9

Scott Branden (11):
  net/bnxt: code cleanup style of bnxt cpr
  net/bnxt: code cleanup style of bnxt rxr
  net/bnxt: code cleanup style of rte pmd bnxt file
  net/bnxt: code cleanup style of bnxt stats
  net/bnxt: code cleanup style of bnxt vnic
  net/bnxt: code cleanup style of bnxt txq
  net/bnxt: code cleanup style of bnxt rxq
  net/bnxt: code cleanup style of bnxt txr
  net/bnxt: code cleanup style of bnxt ring
  net/bnxt: code cleanup style of bnxt ethdev
  net/bnxt: move function check zero bytes to bnxt util.h

Somnath Kotur (2):
  net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter
  net/bnxt: fix to move a flow to a different queue

Xiaoxin Peng (1):
  net/bnxt: fix Tx with multiple mbuf

 drivers/net/bnxt/Makefile              |    2 +
 drivers/net/bnxt/bnxt.h                |   27 +
 drivers/net/bnxt/bnxt_cpr.c            |   22 +-
 drivers/net/bnxt/bnxt_cpr.h            |   12 +
 drivers/net/bnxt/bnxt_ethdev.c         |  284 +++++---
 drivers/net/bnxt/bnxt_filter.c         | 1090 +----------------------------
 drivers/net/bnxt/bnxt_filter.h         |    1 -
 drivers/net/bnxt/bnxt_flow.c           | 1171 ++++++++++++++++++++++++++++++++
 drivers/net/bnxt/bnxt_hwrm.c           |  156 +++--
 drivers/net/bnxt/bnxt_hwrm.h           |    3 +
 drivers/net/bnxt/bnxt_ring.c           |  194 +++++-
 drivers/net/bnxt/bnxt_ring.h           |   41 +-
 drivers/net/bnxt/bnxt_rxq.c            |   76 ++-
 drivers/net/bnxt/bnxt_rxq.h            |   16 +-
 drivers/net/bnxt/bnxt_rxr.c            |   82 ++-
 drivers/net/bnxt/bnxt_rxr.h            |    8 +-
 drivers/net/bnxt/bnxt_stats.c          |   84 ++-
 drivers/net/bnxt/bnxt_stats.h          |   27 +-
 drivers/net/bnxt/bnxt_txq.c            |   24 +-
 drivers/net/bnxt/bnxt_txq.h            |   10 +-
 drivers/net/bnxt/bnxt_txr.c            |  161 +++--
 drivers/net/bnxt/bnxt_txr.h            |   19 +-
 drivers/net/bnxt/bnxt_util.c           |   18 +
 drivers/net/bnxt/bnxt_util.h           |   11 +
 drivers/net/bnxt/bnxt_vnic.c           |   28 +-
 drivers/net/bnxt/bnxt_vnic.h           |    8 +-
 drivers/net/bnxt/hsi_struct_def_dpdk.h |  113 ++-
 drivers/net/bnxt/rte_pmd_bnxt.c        |   97 ++-
 drivers/net/bnxt/rte_pmd_bnxt.h        |   69 +-
 29 files changed, 2314 insertions(+), 1540 deletions(-)
 create mode 100644 drivers/net/bnxt/bnxt_flow.c
 create mode 100644 drivers/net/bnxt/bnxt_util.c
 create mode 100644 drivers/net/bnxt/bnxt_util.h

Comments

Ferruh Yigit June 26, 2018, 3:27 p.m. UTC | #1
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> Patchset against dpdk-next-net contains bug fixes,
> some code refactoring and style cleanup.
> 
> Please apply.
> 
> Ajit Khaparde (15):
>   net/bnxt: fix clear port stats
>   net/bnxt: add Tx batching support
>   net/bnxt: Rx processing optimization
>   net/bnxt: set min and max descriptor count for Tx and Rx rings
>   net/bnxt: fix dev close operation
>   net/bnxt: set ring coalesce parameters for Stratus NIC
>   net/bnxt: fix HW Tx checksum offload check
>   net/bnxt: add support for VF id 0xd800
>   net/bnxt: fix rx/tx queue start/stop operations
>   net/bnxt: code cleanup style of bnxt vnic
>   net/bnxt: filter/flow refactoring
>   net/bnxt: check filter type before clearing it
>   net/bnxt: fix set MTU
>   net/bnxt: fix incorrect IO address handling in Tx
>   net/bnxt: allocate RSS context only if RSS mode is enabled.
> 
> Jay Ding (1):
>   net/bnxt: check for invalid vnic id
> 
> Rob Miller (1):
>   net/bnxt: update HWRM API to v1.9.2.9
> 
> Scott Branden (11):
>   net/bnxt: code cleanup style of bnxt cpr
>   net/bnxt: code cleanup style of bnxt rxr
>   net/bnxt: code cleanup style of rte pmd bnxt file
>   net/bnxt: code cleanup style of bnxt stats
>   net/bnxt: code cleanup style of bnxt vnic
>   net/bnxt: code cleanup style of bnxt txq
>   net/bnxt: code cleanup style of bnxt rxq
>   net/bnxt: code cleanup style of bnxt txr
>   net/bnxt: code cleanup style of bnxt ring
>   net/bnxt: code cleanup style of bnxt ethdev
>   net/bnxt: move function check zero bytes to bnxt util.h
> 
> Somnath Kotur (2):
>   net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter
>   net/bnxt: fix to move a flow to a different queue
> 
> Xiaoxin Peng (1):
>   net/bnxt: fix Tx with multiple mbuf


Hi Ajit,

./devtools/check-git-log.sh is giving some errors [1], can you please check them?


[1]
Wrong headline format:
        net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter
        net/bnxt: allocate RSS context only if RSS mode is enabled.
Wrong headline uppercase:
        net/bnxt: Rx processing optimization
        net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter
Wrong headline lowercase:
        net/bnxt: fix rx/tx queue start/stop operations
        net/bnxt: code cleanup style of rte pmd bnxt file
Headline too long:
        net/bnxt: set min and max descriptor count for Tx and Rx rings
        net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter
Line too long:
        we are repurposing the same ntuple filter with different destination queues.
Wrong tag:
        Fixes: 893074951314 (net/bnxt: free memory in close operation)
        Fixes: 1383434c9089("net/bnxt: reset L2 filter id once filter is freed")
Wrong 'Fixes' reference:
        Fixes: 893074951314 (net/bnxt: free memory in close operation)
        Fixes: 1383434c9089("net/bnxt: reset L2 filter id once filter is freed")
Is it candidate for Cc: stable@dpdk.org backport?
        net/bnxt: fix rx/tx queue start/stop operations
        net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter
Ajit Khaparde June 28, 2018, 8:15 p.m. UTC | #2
On Tue, Jun 26, 2018 at 8:27 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> > Patchset against dpdk-next-net contains bug fixes,
> > some code refactoring and style cleanup.
> >
> > Please apply.
> >
> > Ajit Khaparde (15):
> >   net/bnxt: fix clear port stats
> >   net/bnxt: add Tx batching support
> >   net/bnxt: Rx processing optimization
> >   net/bnxt: set min and max descriptor count for Tx and Rx rings
> >   net/bnxt: fix dev close operation
> >   net/bnxt: set ring coalesce parameters for Stratus NIC
> >   net/bnxt: fix HW Tx checksum offload check
> >   net/bnxt: add support for VF id 0xd800
> >   net/bnxt: fix rx/tx queue start/stop operations
> >   net/bnxt: code cleanup style of bnxt vnic
> >   net/bnxt: filter/flow refactoring
> >   net/bnxt: check filter type before clearing it
> >   net/bnxt: fix set MTU
> >   net/bnxt: fix incorrect IO address handling in Tx
> >   net/bnxt: allocate RSS context only if RSS mode is enabled.
> >
> > Jay Ding (1):
> >   net/bnxt: check for invalid vnic id
> >
> > Rob Miller (1):
> >   net/bnxt: update HWRM API to v1.9.2.9
> >
> > Scott Branden (11):
> >   net/bnxt: code cleanup style of bnxt cpr
> >   net/bnxt: code cleanup style of bnxt rxr
> >   net/bnxt: code cleanup style of rte pmd bnxt file
> >   net/bnxt: code cleanup style of bnxt stats
> >   net/bnxt: code cleanup style of bnxt vnic
> >   net/bnxt: code cleanup style of bnxt txq
> >   net/bnxt: code cleanup style of bnxt rxq
> >   net/bnxt: code cleanup style of bnxt txr
> >   net/bnxt: code cleanup style of bnxt ring
> >   net/bnxt: code cleanup style of bnxt ethdev
> >   net/bnxt: move function check zero bytes to bnxt util.h
> >
> > Somnath Kotur (2):
> >   net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter
> >   net/bnxt: fix to move a flow to a different queue
> >
> > Xiaoxin Peng (1):
> >   net/bnxt: fix Tx with multiple mbuf
>
>
> Hi Ajit,
>
> ​​
> ./devtools/check-git-log.sh is giving some errors [1], can you please
> check them?
>
​Took care of this and other comments as well.​

​ Thanks​