[dpdk-dev,00/16] Adding Cavium's crypto device(CPT) driver
mbox series

Message ID 1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com
Headers show
Series
  • Adding Cavium's crypto device(CPT) driver
Related show

Message

Anoob Joseph June 8, 2018, 4:45 p.m. UTC
Ankur Dwivedi (4):
  crypto/cpt/base: add hardware enq/deq API for CPT
  crypto/cpt/base: add sym crypto session init API for CPT
  crypto/cpt/base: add sym crypto request prepare for CPT
  crypto/cpt: build with meson

Murthy NSSR (3):
  crypto/cpt/base: add request prepare API for ZUC and SNOW3G
  crypto/cpt/base: add request prepare API for Kasumi
  crypto/cpt/base: add prepare request API for HASH and HMAC

Nithin Dabilpuram (3):
  config: add Cavium CPT PMD skeleton
  crypto/cpt/base: add hardware definitions Cavium CPT
  crypto/cpt/base: add hardware initialization API for CPT

Ragothaman Jayaraman (3):
  crypto/cpt: adds the session related function callbacks
  crypto/cpt: adds the enqueue and dequeue callbacks
  doc: add Cavium's CPT guide

Srisivasubramanian Srinivasan (3):
  crypto/cpt: add driver initializations
  crypto/cpt: add the basic device callback functions
  crypto/cpt: adds some more callback functions for CPT

 MAINTAINERS                                |    7 +
 config/common_base                         |    8 +
 doc/guides/cryptodevs/cpt.rst              |  112 ++
 drivers/crypto/Makefile                    |    1 +
 drivers/crypto/cpt/Makefile                |   49 +
 drivers/crypto/cpt/base/cpt.h              |  231 +++
 drivers/crypto/cpt/base/cpt8xxx_device.c   |  200 ++
 drivers/crypto/cpt/base/cpt8xxx_device.h   |   85 +
 drivers/crypto/cpt/base/cpt_debug.h        |  231 +++
 drivers/crypto/cpt/base/cpt_device.c       |  383 ++++
 drivers/crypto/cpt/base/cpt_device.h       |  162 ++
 drivers/crypto/cpt/base/cpt_hw_types.h     |  836 +++++++++
 drivers/crypto/cpt/base/cpt_ops.c          | 2756 ++++++++++++++++++++++++++++
 drivers/crypto/cpt/base/cpt_request_mgr.c  |  424 +++++
 drivers/crypto/cpt/base/cpt_request_mgr.h  |   75 +
 drivers/crypto/cpt/base/cpt_vf_mbox.c      |  176 ++
 drivers/crypto/cpt/base/cpt_vf_mbox.h      |   60 +
 drivers/crypto/cpt/base/mcode_defines.h    |  215 +++
 drivers/crypto/cpt/cpt_pmd_cryptodev.c     |  271 +++
 drivers/crypto/cpt/cpt_pmd_logs.h          |   50 +
 drivers/crypto/cpt/cpt_pmd_ops.c           | 1936 +++++++++++++++++++
 drivers/crypto/cpt/cpt_pmd_ops.h           |   96 +
 drivers/crypto/cpt/meson.build             |   16 +
 drivers/crypto/cpt/rte_pmd_cpt_version.map |    4 +
 drivers/crypto/meson.build                 |    2 +-
 mk/rte.app.mk                              |    2 +-
 26 files changed, 8386 insertions(+), 2 deletions(-)
 create mode 100644 doc/guides/cryptodevs/cpt.rst
 create mode 100644 drivers/crypto/cpt/Makefile
 create mode 100644 drivers/crypto/cpt/base/cpt.h
 create mode 100644 drivers/crypto/cpt/base/cpt8xxx_device.c
 create mode 100644 drivers/crypto/cpt/base/cpt8xxx_device.h
 create mode 100644 drivers/crypto/cpt/base/cpt_debug.h
 create mode 100644 drivers/crypto/cpt/base/cpt_device.c
 create mode 100644 drivers/crypto/cpt/base/cpt_device.h
 create mode 100644 drivers/crypto/cpt/base/cpt_hw_types.h
 create mode 100644 drivers/crypto/cpt/base/cpt_ops.c
 create mode 100644 drivers/crypto/cpt/base/cpt_request_mgr.c
 create mode 100644 drivers/crypto/cpt/base/cpt_request_mgr.h
 create mode 100644 drivers/crypto/cpt/base/cpt_vf_mbox.c
 create mode 100644 drivers/crypto/cpt/base/cpt_vf_mbox.h
 create mode 100644 drivers/crypto/cpt/base/mcode_defines.h
 create mode 100644 drivers/crypto/cpt/cpt_pmd_cryptodev.c
 create mode 100644 drivers/crypto/cpt/cpt_pmd_logs.h
 create mode 100644 drivers/crypto/cpt/cpt_pmd_ops.c
 create mode 100644 drivers/crypto/cpt/cpt_pmd_ops.h
 create mode 100644 drivers/crypto/cpt/meson.build
 create mode 100644 drivers/crypto/cpt/rte_pmd_cpt_version.map

Comments

Anoob Joseph June 18, 2018, 1:02 p.m. UTC | #1
Hi Akhil, Pablo,

Are there any top level comments on this?

Thanks,
Anoob
On 08/06/18 22:15, Anoob Joseph wrote:
> Ankur Dwivedi (4):
>    crypto/cpt/base: add hardware enq/deq API for CPT
>    crypto/cpt/base: add sym crypto session init API for CPT
>    crypto/cpt/base: add sym crypto request prepare for CPT
>    crypto/cpt: build with meson
>
> Murthy NSSR (3):
>    crypto/cpt/base: add request prepare API for ZUC and SNOW3G
>    crypto/cpt/base: add request prepare API for Kasumi
>    crypto/cpt/base: add prepare request API for HASH and HMAC
>
> Nithin Dabilpuram (3):
>    config: add Cavium CPT PMD skeleton
>    crypto/cpt/base: add hardware definitions Cavium CPT
>    crypto/cpt/base: add hardware initialization API for CPT
>
> Ragothaman Jayaraman (3):
>    crypto/cpt: adds the session related function callbacks
>    crypto/cpt: adds the enqueue and dequeue callbacks
>    doc: add Cavium's CPT guide
>
> Srisivasubramanian Srinivasan (3):
>    crypto/cpt: add driver initializations
>    crypto/cpt: add the basic device callback functions
>    crypto/cpt: adds some more callback functions for CPT
>
>   MAINTAINERS                                |    7 +
>   config/common_base                         |    8 +
>   doc/guides/cryptodevs/cpt.rst              |  112 ++
>   drivers/crypto/Makefile                    |    1 +
>   drivers/crypto/cpt/Makefile                |   49 +
>   drivers/crypto/cpt/base/cpt.h              |  231 +++
>   drivers/crypto/cpt/base/cpt8xxx_device.c   |  200 ++
>   drivers/crypto/cpt/base/cpt8xxx_device.h   |   85 +
>   drivers/crypto/cpt/base/cpt_debug.h        |  231 +++
>   drivers/crypto/cpt/base/cpt_device.c       |  383 ++++
>   drivers/crypto/cpt/base/cpt_device.h       |  162 ++
>   drivers/crypto/cpt/base/cpt_hw_types.h     |  836 +++++++++
>   drivers/crypto/cpt/base/cpt_ops.c          | 2756 ++++++++++++++++++++++++++++
>   drivers/crypto/cpt/base/cpt_request_mgr.c  |  424 +++++
>   drivers/crypto/cpt/base/cpt_request_mgr.h  |   75 +
>   drivers/crypto/cpt/base/cpt_vf_mbox.c      |  176 ++
>   drivers/crypto/cpt/base/cpt_vf_mbox.h      |   60 +
>   drivers/crypto/cpt/base/mcode_defines.h    |  215 +++
>   drivers/crypto/cpt/cpt_pmd_cryptodev.c     |  271 +++
>   drivers/crypto/cpt/cpt_pmd_logs.h          |   50 +
>   drivers/crypto/cpt/cpt_pmd_ops.c           | 1936 +++++++++++++++++++
>   drivers/crypto/cpt/cpt_pmd_ops.h           |   96 +
>   drivers/crypto/cpt/meson.build             |   16 +
>   drivers/crypto/cpt/rte_pmd_cpt_version.map |    4 +
>   drivers/crypto/meson.build                 |    2 +-
>   mk/rte.app.mk                              |    2 +-
>   26 files changed, 8386 insertions(+), 2 deletions(-)
>   create mode 100644 doc/guides/cryptodevs/cpt.rst
>   create mode 100644 drivers/crypto/cpt/Makefile
>   create mode 100644 drivers/crypto/cpt/base/cpt.h
>   create mode 100644 drivers/crypto/cpt/base/cpt8xxx_device.c
>   create mode 100644 drivers/crypto/cpt/base/cpt8xxx_device.h
>   create mode 100644 drivers/crypto/cpt/base/cpt_debug.h
>   create mode 100644 drivers/crypto/cpt/base/cpt_device.c
>   create mode 100644 drivers/crypto/cpt/base/cpt_device.h
>   create mode 100644 drivers/crypto/cpt/base/cpt_hw_types.h
>   create mode 100644 drivers/crypto/cpt/base/cpt_ops.c
>   create mode 100644 drivers/crypto/cpt/base/cpt_request_mgr.c
>   create mode 100644 drivers/crypto/cpt/base/cpt_request_mgr.h
>   create mode 100644 drivers/crypto/cpt/base/cpt_vf_mbox.c
>   create mode 100644 drivers/crypto/cpt/base/cpt_vf_mbox.h
>   create mode 100644 drivers/crypto/cpt/base/mcode_defines.h
>   create mode 100644 drivers/crypto/cpt/cpt_pmd_cryptodev.c
>   create mode 100644 drivers/crypto/cpt/cpt_pmd_logs.h
>   create mode 100644 drivers/crypto/cpt/cpt_pmd_ops.c
>   create mode 100644 drivers/crypto/cpt/cpt_pmd_ops.h
>   create mode 100644 drivers/crypto/cpt/meson.build
>   create mode 100644 drivers/crypto/cpt/rte_pmd_cpt_version.map
>
Pablo de Lara June 18, 2018, 2:29 p.m. UTC | #2
Hi Anoob,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anoob Joseph
> Sent: Monday, June 18, 2018 2:02 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Ankur Dwivedi
> <ankur.dwivedi@cavium.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Murthy NSSR
> <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
> <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
> <Ragothaman.Jayaraman@cavium.com>; Srisivasubramanian Srinivasan
> <Srisivasubramanian.Srinivasan@cavium.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT)
> driver
> 
> Hi Akhil, Pablo,
> 
> Are there any top level comments on this?

Sorry for the delay. I didn't have the time to review this yet.
Will do that asap.

Thanks,
Pablo
Pablo de Lara July 9, 2018, 10:55 p.m. UTC | #3
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, June 18, 2018 3:30 PM
> To: Anoob Joseph <Anoob.Joseph@caviumnetworks.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Ankur Dwivedi
> <ankur.dwivedi@cavium.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Murthy NSSR
> <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
> <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
> <Ragothaman.Jayaraman@cavium.com>; Srisivasubramanian Srinivasan
> <Srisivasubramanian.Srinivasan@cavium.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT)
> driver
> 
> Hi Anoob,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anoob Joseph
> > Sent: Monday, June 18, 2018 2:02 PM
> > To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Cc: Thomas Monjalon <thomas@monjalon.net>; Ankur Dwivedi
> > <ankur.dwivedi@cavium.com>; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>; Murthy NSSR
> > <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
> > <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
> > <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
> > <Ragothaman.Jayaraman@cavium.com>; Srisivasubramanian Srinivasan
> > <Srisivasubramanian.Srinivasan@cavium.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto
> > device(CPT) driver
> >
> > Hi Akhil, Pablo,
> >
> > Are there any top level comments on this?
> 
> Sorry for the delay. I didn't have the time to review this yet.
> Will do that asap.

Hi Anoob,

I had some comments on this patchset.
Could you address these comments and send a v2?
Please, take into account the following patchset which will be applied tomorrow
(just waiting for a couple of acks):

http://patches.dpdk.org/user/todo/dpdk/?series=416


> 
> Thanks,
> Pablo
Anoob Joseph July 10, 2018, 3:41 a.m. UTC | #4
Hi Pablo,

Thanks for the review. We had made some architectural modifications to 
the PMD while addressing your comments. This is taking longer than 
expected and so we might as well defer the v2 to the next release cycle. 
Is that fine?

Do you suggest submitting the patches as and when it is ready or should 
I wait till next release cycle?

> Please, take into account the following patchset which will be applied tomorrow
> (just waiting for a couple of acks):

> http://patches.dpdk.org/user/todo/dpdk/?series=416

This series is integrated.

Thanks,
Anoob

On 10-07-2018 04:25, De Lara Guarch, Pablo wrote:
> External Email
>
>> -----Original Message-----
>> From: De Lara Guarch, Pablo
>> Sent: Monday, June 18, 2018 3:30 PM
>> To: Anoob Joseph <Anoob.Joseph@caviumnetworks.com>; Akhil Goyal
>> <akhil.goyal@nxp.com>
>> Cc: Thomas Monjalon <thomas@monjalon.net>; Ankur Dwivedi
>> <ankur.dwivedi@cavium.com>; Jerin Jacob
>> <jerin.jacob@caviumnetworks.com>; Murthy NSSR
>> <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
>> <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
>> <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
>> <Ragothaman.Jayaraman@cavium.com>; Srisivasubramanian Srinivasan
>> <Srisivasubramanian.Srinivasan@cavium.com>; dev@dpdk.org
>> Subject: RE: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT)
>> driver
>>
>> Hi Anoob,
>>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anoob Joseph
>>> Sent: Monday, June 18, 2018 2:02 PM
>>> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
>>> <pablo.de.lara.guarch@intel.com>
>>> Cc: Thomas Monjalon <thomas@monjalon.net>; Ankur Dwivedi
>>> <ankur.dwivedi@cavium.com>; Jerin Jacob
>>> <jerin.jacob@caviumnetworks.com>; Murthy NSSR
>>> <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
>>> <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
>>> <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
>>> <Ragothaman.Jayaraman@cavium.com>; Srisivasubramanian Srinivasan
>>> <Srisivasubramanian.Srinivasan@cavium.com>; dev@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto
>>> device(CPT) driver
>>>
>>> Hi Akhil, Pablo,
>>>
>>> Are there any top level comments on this?
>> Sorry for the delay. I didn't have the time to review this yet.
>> Will do that asap.
> Hi Anoob,
>
> I had some comments on this patchset.
> Could you address these comments and send a v2?
> Please, take into account the following patchset which will be applied tomorrow
> (just waiting for a couple of acks):
>
> http://patches.dpdk.org/user/todo/dpdk/?series=416
>
>
>> Thanks,
>> Pablo
Pablo de Lara July 10, 2018, 8:11 a.m. UTC | #5
Hi Anoob,

> -----Original Message-----
> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
> Sent: Tuesday, July 10, 2018 4:41 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; 'Akhil Goyal'
> <akhil.goyal@nxp.com>
> Cc: 'Thomas Monjalon' <thomas@monjalon.net>; 'Ankur Dwivedi'
> <ankur.dwivedi@cavium.com>; 'Jerin Jacob'
> <jerin.jacob@caviumnetworks.com>; 'Murthy NSSR'
> <Nidadavolu.Murthy@cavium.com>; 'Narayana Prasad'
> <narayanaprasad.athreya@caviumnetworks.com>; 'Nithin Dabilpuram'
> <nithin.dabilpuram@cavium.com>; 'Ragothaman Jayaraman'
> <Ragothaman.Jayaraman@cavium.com>; 'Srisivasubramanian Srinivasan'
> <Srisivasubramanian.Srinivasan@cavium.com>; 'dev@dpdk.org'
> <dev@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT)
> driver
> 
> Hi Pablo,
> 
> Thanks for the review. We had made some architectural modifications to the
> PMD while addressing your comments. This is taking longer than expected and
> so we might as well defer the v2 to the next release cycle.
> Is that fine?
> 
> Do you suggest submitting the patches as and when it is ready or should I wait
> till next release cycle?

It's ok to defer to next release, no problem. I suggest to wait until 18.08 is out, to make sure that people don't forget about it when they are focused on 18.08 last changes.


> 
> > Please, take into account the following patchset which will be applied
> > tomorrow (just waiting for a couple of acks):
> 
> > http://patches.dpdk.org/user/todo/dpdk/?series=416
> 
> This series is integrated.
> 
> Thanks,
> Anoob
> 
> On 10-07-2018 04:25, De Lara Guarch, Pablo wrote:
> > External Email
> >
> >> -----Original Message-----
> >> From: De Lara Guarch, Pablo
> >> Sent: Monday, June 18, 2018 3:30 PM
> >> To: Anoob Joseph <Anoob.Joseph@caviumnetworks.com>; Akhil Goyal
> >> <akhil.goyal@nxp.com>
> >> Cc: Thomas Monjalon <thomas@monjalon.net>; Ankur Dwivedi
> >> <ankur.dwivedi@cavium.com>; Jerin Jacob
> >> <jerin.jacob@caviumnetworks.com>; Murthy NSSR
> >> <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
> >> <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
> >> <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
> >> <Ragothaman.Jayaraman@cavium.com>; Srisivasubramanian Srinivasan
> >> <Srisivasubramanian.Srinivasan@cavium.com>; dev@dpdk.org
> >> Subject: RE: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto
> >> device(CPT) driver
> >>
> >> Hi Anoob,
> >>
> >>> -----Original Message-----
> >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anoob Joseph
> >>> Sent: Monday, June 18, 2018 2:02 PM
> >>> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
> >>> <pablo.de.lara.guarch@intel.com>
> >>> Cc: Thomas Monjalon <thomas@monjalon.net>; Ankur Dwivedi
> >>> <ankur.dwivedi@cavium.com>; Jerin Jacob
> >>> <jerin.jacob@caviumnetworks.com>; Murthy NSSR
> >>> <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
> >>> <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
> >>> <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
> >>> <Ragothaman.Jayaraman@cavium.com>; Srisivasubramanian Srinivasan
> >>> <Srisivasubramanian.Srinivasan@cavium.com>; dev@dpdk.org
> >>> Subject: Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto
> >>> device(CPT) driver
> >>>
> >>> Hi Akhil, Pablo,
> >>>
> >>> Are there any top level comments on this?
> >> Sorry for the delay. I didn't have the time to review this yet.
> >> Will do that asap.
> > Hi Anoob,
> >
> > I had some comments on this patchset.
> > Could you address these comments and send a v2?
> > Please, take into account the following patchset which will be applied
> > tomorrow (just waiting for a couple of acks):
> >
> > http://patches.dpdk.org/user/todo/dpdk/?series=416
> >
> >
> >> Thanks,
> >> Pablo