[dpdk-dev,memnic,3/7] pmd: use helper macros
Commit Message
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Do not touch pktmbuf directly.
Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
to access the property.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
pmd/pmd_memnic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
2014-09-11 07:47, Hiroshi Shimamoto:
> Do not touch pktmbuf directly.
>
> Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
> to access the property.
I guess this change is for compatibility with DPDK 1.8.
Does it have an impact on performance?
> Subject: Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
>
> 2014-09-11 07:47, Hiroshi Shimamoto:
> > Do not touch pktmbuf directly.
> >
> > Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
> > to access the property.
>
> I guess this change is for compatibility with DPDK 1.8.
Yep, I had the thought need to prepare upcoming code.
> Does it have an impact on performance?
No, it must not.
thanks,
Hiroshi
>
> --
> Thomas
@@ -308,8 +308,8 @@ static uint16_t memnic_recv_pkts(void *rx_queue,
rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
mb->pkt.in_port = q->port_id;
- mb->pkt.pkt_len = p->len;
- mb->pkt.data_len = p->len;
+ rte_pktmbuf_pkt_len(mb) = p->len;
+ rte_pktmbuf_data_len(mb) = p->len;
rx_pkts[nr] = mb;
pkts++;