Message ID | 20190509171907.14693-1-dharmik.thakkar@arm.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4604749DF; Thu, 9 May 2019 19:19:57 +0200 (CEST) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 332CB2862 for <dev@dpdk.org>; Thu, 9 May 2019 19:19:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7126C374; Thu, 9 May 2019 10:19:55 -0700 (PDT) Received: from dp6132.austin.arm.com (dp6132.austin.arm.com [10.118.12.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E7133F6C4; Thu, 9 May 2019 10:19:55 -0700 (PDT) From: Dharmik Thakkar <dharmik.thakkar@arm.com> To: Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, zhongdahulinfan@163.com, Dharmik Thakkar <dharmik.thakkar@arm.com> Date: Thu, 9 May 2019 17:19:04 +0000 Message-Id: <20190509171907.14693-1-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190509133924.7153-1-dharmik.thakkar@arm.com> References: <20190509133924.7153-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
hash: fix bugs in 'free key with position'
|
|
Message
Dharmik Thakkar
May 9, 2019, 5:19 p.m. UTC
This patch series solves 2 bugs reported on Bugzilla (bug-261) within the function rte_hash_free_key_with_postion(). It also adds a test case to catch similar bugs in the future. https://bugs.dpdk.org/show_bug.cgi?id=261 --- v4: * Fix compilation failure (Yipeng) v3: * Split the patch and update commit logs (Thomas) v2: * Add comments in test_hash.c (Yipeng) * Resolve checkpatch warning Dharmik Thakkar (3): hash: fix position bug in 'free key with position' hash: fix total entries in free key with position test/hash: add test for 'free key with position' app/test/test_hash.c | 94 +++++++++++++++++++++++++++++++ lib/librte_hash/rte_cuckoo_hash.c | 15 +++-- 2 files changed, 104 insertions(+), 5 deletions(-)
Comments
09/05/2019 19:19, Dharmik Thakkar: > This patch series solves 2 bugs reported on Bugzilla (bug-261) within > the function rte_hash_free_key_with_postion(). It also adds a test case > to catch similar bugs in the future. > > https://bugs.dpdk.org/show_bug.cgi?id=261 Yipeng, Sameh, should it enter in 19.05-rc4? Are you sure it does not break things more? If yes, please give your ack.
>-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Thursday, May 9, 2019 12:24 PM >To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com> >Cc: dev@dpdk.org; Dharmik Thakkar <dharmik.thakkar@arm.com>; honnappa.nagarahalli@arm.com; zhongdahulinfan@163.com >Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position' > >09/05/2019 19:19, Dharmik Thakkar: >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within >> the function rte_hash_free_key_with_postion(). It also adds a test case >> to catch similar bugs in the future. >> >> https://bugs.dpdk.org/show_bug.cgi?id=261 > >Yipeng, Sameh, should it enter in 19.05-rc4? >Are you sure it does not break things more? >If yes, please give your ack. [Wang, Yipeng] Please go ahead Thomas, I reviewed the code and it will not break other things. The changes are refrained inside an experimental API function. I haven't done the meson build test though.
09/05/2019 21:36, Wang, Yipeng1: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > >09/05/2019 19:19, Dharmik Thakkar: > >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within > >> the function rte_hash_free_key_with_postion(). It also adds a test case > >> to catch similar bugs in the future. > >> > >> https://bugs.dpdk.org/show_bug.cgi?id=261 > > > >Yipeng, Sameh, should it enter in 19.05-rc4? > >Are you sure it does not break things more? > >If yes, please give your ack. > [Wang, Yipeng] > Please go ahead Thomas, I reviewed the code and it will not break other things. The > changes are refrained inside an experimental API function. > > I haven't done the meson build test though. Applied, thanks