mbox series

[v3,0/4] net/mlx5: code cleanup in rx and tx files

Message ID cover.1557061532.git.dekelp@mellanox.com (mailing list archive)
Headers
Series net/mlx5: code cleanup in rx and tx files |

Message

Dekel Peled May 5, 2019, 1:09 p.m. UTC 
  During work on Rx feature I did some cleanup actions.
This series includes those changes divided by their type.

---
v2: Change 2nd patch type to "fix".
v3: Apply minor code-review comment on 2nd patch.
    Add Acked-by in all patches.
---

Dekel Peled (4):
  net/mlx5: remove unused functions
  net/mlx5: fix missing validation of null pointer
  net/mlx5: fix description of function return value
  net/mlx5: move locally used functions to static

 drivers/net/mlx5/mlx5_rxq.c  | 220 +++++++++++++++++++------------------------
 drivers/net/mlx5/mlx5_rxtx.h |  20 ----
 drivers/net/mlx5/mlx5_txq.c  |  13 ---
 3 files changed, 95 insertions(+), 158 deletions(-)

Comments

Shahaf Shuler May 8, 2019, 4:43 a.m. UTC | #1 
Dekel,

Sunday, May 5, 2019 4:09 PM, Dekel Peled:
> Subject: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files
> 
> During work on Rx feature I did some cleanup actions.
> This series includes those changes divided by their type.
> 
> ---
> v2: Change 2nd patch type to "fix".
> v3: Apply minor code-review comment on 2nd patch.
>     Add Acked-by in all patches.
> ---

I was trying to apply your patch but hit clang compilation issue, please address:

error: static function
      'mlx5_check_mprq_support' is used in an inline function with external linkage [-Werror,-Wstatic-in-inline]
        if (mlx5_check_mprq_support(dev) < 0)
            ^
/.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxtx.h:248:1: note: use 'static' to give inline
      function 'mlx5_mprq_enabled' internal linkage
int mlx5_mprq_enabled(struct rte_eth_dev *dev);
^
static 
/.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxq.c:69:1: note: 'mlx5_check_mprq_support'
      declared here
mlx5_check_mprq_support(struct rte_eth_dev *dev)

> 
> Dekel Peled (4):
>   net/mlx5: remove unused functions
>   net/mlx5: fix missing validation of null pointer
>   net/mlx5: fix description of function return value
>   net/mlx5: move locally used functions to static
> 
>  drivers/net/mlx5/mlx5_rxq.c  | 220 +++++++++++++++++++-------------------
> -----
>  drivers/net/mlx5/mlx5_rxtx.h |  20 ----  drivers/net/mlx5/mlx5_txq.c  |  13 --
> -
>  3 files changed, 95 insertions(+), 158 deletions(-)
> 
> --
> 1.8.3.1