mbox series

[v2,0/5] make lcore_config internal

Message ID 20190410171603.8979-1-stephen@networkplumber.org (mailing list archive)
Headers
Series make lcore_config internal |

Message

Stephen Hemminger April 10, 2019, 5:15 p.m. UTC 
  This set of patches makes the lcore_config structure less visible
as part of the ABI.  This version does not break the ABI (yet)
follow on patch moves lcore_config into eal_private.h

The changes in v2 is to:
 - new patch to use unsigned int in lcore.h first
 - incorporate feedback from David
 - don't include last patch to make it private
	(to avoid accidental early merge)
	
Stephen Hemminger (5):
  eal: use unsigned int in rte_lcore.h functions
  eal: add accessor functions for lcore_config
  bus: use lcore accessor functions
  examples/bond: use lcore accessor
  app/test: use lcore accessor functions

 app/test/test_cryptodev.c                 |  2 +-
 app/test/test_hash_readwrite_lf.c         | 14 +++---
 app/test/test_ring_perf.c                 | 22 +++++----
 app/test/test_stack_perf.c                | 20 ++++----
 doc/guides/rel_notes/release_19_05.rst    |  6 +++
 drivers/bus/dpaa/dpaa_bus.c               |  6 ++-
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  4 +-
 examples/bond/main.c                      |  5 +-
 lib/librte_eal/common/eal_common_lcore.c  | 39 +++++++++++++++
 lib/librte_eal/common/include/rte_lcore.h | 58 ++++++++++++++++-------
 lib/librte_eal/rte_eal_version.map        | 11 +++++
 11 files changed, 136 insertions(+), 51 deletions(-)

Comments

Stephen Hemminger May 2, 2019, 11:15 p.m. UTC | #1 
On Wed, 10 Apr 2019 10:15:58 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> This set of patches makes the lcore_config structure less visible
> as part of the ABI.  This version does not break the ABI (yet)
> follow on patch moves lcore_config into eal_private.h
> 
> The changes in v2 is to:
>  - new patch to use unsigned int in lcore.h first
>  - incorporate feedback from David
>  - don't include last patch to make it private
> 	(to avoid accidental early merge)
> 	
> Stephen Hemminger (5):
>   eal: use unsigned int in rte_lcore.h functions
>   eal: add accessor functions for lcore_config
>   bus: use lcore accessor functions
>   examples/bond: use lcore accessor
>   app/test: use lcore accessor functions
> 
>  app/test/test_cryptodev.c                 |  2 +-
>  app/test/test_hash_readwrite_lf.c         | 14 +++---
>  app/test/test_ring_perf.c                 | 22 +++++----
>  app/test/test_stack_perf.c                | 20 ++++----
>  doc/guides/rel_notes/release_19_05.rst    |  6 +++
>  drivers/bus/dpaa/dpaa_bus.c               |  6 ++-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  4 +-
>  examples/bond/main.c                      |  5 +-
>  lib/librte_eal/common/eal_common_lcore.c  | 39 +++++++++++++++
>  lib/librte_eal/common/include/rte_lcore.h | 58 ++++++++++++++++-------
>  lib/librte_eal/rte_eal_version.map        | 11 +++++
>  11 files changed, 136 insertions(+), 51 deletions(-)
> 

Why is this patchset still stuck in the queue?
The parts with deprecation and accessor functions should really go in 19.05
but since it has sat around for so long, it is probably too late.