mbox series

[0/4] net/mlx5: code cleanup in rx and tx files

Message ID cover.1556534247.git.dekelp@mellanox.com (mailing list archive)
Headers
Series net/mlx5: code cleanup in rx and tx files |

Message

Dekel Peled April 29, 2019, 11 a.m. UTC 
  During work on Rx feature I did some cleanup actions.
This series includes those changes divided by their type.

Dekel Peled (4):
  net/mlx5: remove unused functions
  net/mlx5: add missing validation of null pointer
  net/mlx5: fix description of function return value
  net/mlx5: move locally used functions to static

 drivers/net/mlx5/mlx5_rxq.c  | 218 +++++++++++++++++++------------------------
 drivers/net/mlx5/mlx5_rxtx.h |  20 ----
 drivers/net/mlx5/mlx5_txq.c  |  13 ---
 3 files changed, 94 insertions(+), 157 deletions(-)

Comments

Shahaf Shuler May 2, 2019, 2:10 p.m. UTC | #1 
Hi Dekel,

Monday, April 29, 2019 2:01 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files
> 
> During work on Rx feature I did some cleanup actions.
> This series includes those changes divided by their type.

Good cleanup.
I am basically OK w/ the series, you can add my Acked-by to next version. See small comment below.

> 
> Dekel Peled (4):
>   net/mlx5: remove unused functions
>   net/mlx5: add missing validation of null pointer

This one should be "fix ..." and not "add ..." + Cc for stable. Since you actually fix a possible segfault. 

>   net/mlx5: fix description of function return value
>   net/mlx5: move locally used functions to static
> 
>  drivers/net/mlx5/mlx5_rxq.c  | 218 +++++++++++++++++++-------------------
> -----
>  drivers/net/mlx5/mlx5_rxtx.h |  20 ----  drivers/net/mlx5/mlx5_txq.c  |  13 --
> -
>  3 files changed, 94 insertions(+), 157 deletions(-)
> 
> --
> 1.8.3.1