| Message ID | 20190501195014.2938-1-bruce.richardson@intel.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FEFBB62; Wed, 1 May 2019 21:50:22 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8286E1D7 for <dev@dpdk.org>; Wed, 1 May 2019 21:50:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2019 12:50:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,418,1549958400"; d="scan'208";a="140463368" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.222.236]) by orsmga006.jf.intel.com with ESMTP; 01 May 2019 12:50:18 -0700 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com> Date: Wed, 1 May 2019 20:50:10 +0100 Message-Id: <20190501195014.2938-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series | fix warnings with gcc 9 on Fedora 30 | |
Message
Bruce Richardson
May 1, 2019, 7:50 p.m. UTC
This set of changes fixes warnings seen when compiling DPDK on Fedora 30. In most cases these warnings appear to be false positives, which means we have the option to just disable the warning. Because the changes required to the code to silence the warnings are fairly small I've chosen in all cases to change the code rather than disable the warnings, but I'm open to doing the opposite if it's felt it's a better solution. [One thing I didn't like about disabling the warnings is that the disabling flags are not supported by clang, so adding them involves compiler checks :-(] NOTE: this set does not cover all warnings with GCC9, but it does cover those seen when building with meson. There is still one warning disable flag needed when building with make, which will need a follow-on set to fix. Bruce Richardson (4): net/ixgbe: fix warning with GCC 9 on Fedora 30 bus/fslmc: fix printf of null pointer raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 drivers/bus/fslmc/fslmc_bus.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 2 ++ drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 5 +++++ 4 files changed, 9 insertions(+), 2 deletions(-)
Comments
01/05/2019 21:50, Bruce Richardson: > This set of changes fixes warnings seen when compiling DPDK on Fedora 30. > In most cases these warnings appear to be false positives, which means we > have the option to just disable the warning. Because the changes required > to the code to silence the warnings are fairly small I've chosen in all cases > to change the code rather than disable the warnings, but I'm open to doing > the opposite if it's felt it's a better solution. [One thing I didn't like > about disabling the warnings is that the disabling flags are not supported > by clang, so adding them involves compiler checks :-(] > > NOTE: this set does not cover all warnings with GCC9, but it does cover > those seen when building with meson. There is still one warning disable > flag needed when building with make, which will need a follow-on set to > fix. > > Bruce Richardson (4): > net/ixgbe: fix warning with GCC 9 on Fedora 30 > bus/fslmc: fix printf of null pointer > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 Cc: stable@dpdk.org Applied, thanks
On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <thomas@monjalon.net> wrote: > 01/05/2019 21:50, Bruce Richardson: > > This set of changes fixes warnings seen when compiling DPDK on Fedora 30. > > In most cases these warnings appear to be false positives, which means we > > have the option to just disable the warning. Because the changes required > > to the code to silence the warnings are fairly small I've chosen in all > cases > > to change the code rather than disable the warnings, but I'm open to > doing > > the opposite if it's felt it's a better solution. [One thing I didn't > like > > about disabling the warnings is that the disabling flags are not > supported > > by clang, so adding them involves compiler checks :-(] > > > > NOTE: this set does not cover all warnings with GCC9, but it does cover > > those seen when building with meson. There is still one warning disable > > flag needed when building with make, which will need a follow-on set to > > fix. > > > > Bruce Richardson (4): > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > bus/fslmc: fix printf of null pointer > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: stable@dpdk.org > > Applied, thanks > > I had a comment on patch 2, and the bigger problem is -Waddress-of-packed-member. The quicker solution for now is to downgrade it to warning only so that we can fix the parts later rather than globally disable it.
On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1]thomas@monjalon.net> > wrote: > > 01/05/2019 21:50, Bruce Richardson: > > This set of changes fixes warnings seen when compiling DPDK on > Fedora 30. > > In most cases these warnings appear to be false positives, which > means we > > have the option to just disable the warning. Because the changes > required > > to the code to silence the warnings are fairly small I've chosen > in all cases > > to change the code rather than disable the warnings, but I'm open > to doing > > the opposite if it's felt it's a better solution. [One thing I > didn't like > > about disabling the warnings is that the disabling flags are not > supported > > by clang, so adding them involves compiler checks :-(] > > > > NOTE: this set does not cover all warnings with GCC9, but it does > cover > > those seen when building with meson. There is still one warning > disable > > flag needed when building with make, which will need a follow-on > set to > > fix. > > > > Bruce Richardson (4): > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > bus/fslmc: fix printf of null pointer > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > Cc: [2]stable@dpdk.org > Applied, thanks > > I had a comment on patch 2, and the bigger problem is > -Waddress-of-packed-member. > The quicker solution for now is to downgrade it to warning only so that > we can fix the parts later rather than globally disable it. > -- Well, it is already a warning, it's just that with make we build by default with -Werror when building from git. Also, that particular warning is already disabled for clang compilation, so extending that to being disabled for gcc seems fine for a fix for this release. /Bruce
On Thu, May 2, 2019 at 3:24 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1] > thomas@monjalon.net> > > wrote: > > > > 01/05/2019 21:50, Bruce Richardson: > > > This set of changes fixes warnings seen when compiling DPDK on > > Fedora 30. > > > In most cases these warnings appear to be false positives, which > > means we > > > have the option to just disable the warning. Because the changes > > required > > > to the code to silence the warnings are fairly small I've chosen > > in all cases > > > to change the code rather than disable the warnings, but I'm open > > to doing > > > the opposite if it's felt it's a better solution. [One thing I > > didn't like > > > about disabling the warnings is that the disabling flags are not > > supported > > > by clang, so adding them involves compiler checks :-(] > > > > > > NOTE: this set does not cover all warnings with GCC9, but it does > > cover > > > those seen when building with meson. There is still one warning > > disable > > > flag needed when building with make, which will need a follow-on > > set to > > > fix. > > > > > > Bruce Richardson (4): > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > bus/fslmc: fix printf of null pointer > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: [2]stable@dpdk.org > > Applied, thanks > > > > I had a comment on patch 2, and the bigger problem is > > -Waddress-of-packed-member. > > The quicker solution for now is to downgrade it to warning only so > that > > we can fix the parts later rather than globally disable it. > > -- > Well, it is already a warning, it's just that with make we build by default > with -Werror when building from git. > Err, why don't we have -Werror for meson ? Also, that particular warning is already disabled for clang compilation, so > extending that to being disabled for gcc seems fine for a fix for this > release. > Arf, indeed..
On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon > <[1][2]thomas@monjalon.net> > > wrote: > > > > 01/05/2019 21:50, Bruce Richardson: > > > This set of changes fixes warnings seen when compiling DPDK > on > > Fedora 30. > > > In most cases these warnings appear to be false positives, > which > > means we > > > have the option to just disable the warning. Because the > changes > > required > > > to the code to silence the warnings are fairly small I've > chosen > > in all cases > > > to change the code rather than disable the warnings, but > I'm open > > to doing > > > the opposite if it's felt it's a better solution. [One > thing I > > didn't like > > > about disabling the warnings is that the disabling flags > are not > > supported > > > by clang, so adding them involves compiler checks :-(] > > > > > > NOTE: this set does not cover all warnings with GCC9, but > it does > > cover > > > those seen when building with meson. There is still one > warning > > disable > > > flag needed when building with make, which will need a > follow-on > > set to > > > fix. > > > > > > Bruce Richardson (4): > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > bus/fslmc: fix printf of null pointer > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: [2][3]stable@dpdk.org > > Applied, thanks > > > > I had a comment on patch 2, and the bigger problem is > > -Waddress-of-packed-member. > > The quicker solution for now is to downgrade it to warning only > so that > > we can fix the parts later rather than globally disable it. > > -- > Well, it is already a warning, it's just that with make we build by > default > with -Werror when building from git. > > Err, why don't we have -Werror for meson ? > Because it's generally not a good idea to use -Werror by default. However, the test-meson-build script (which we should all be using for test compilation before upstreaming) sets it for all builds. /Bruce
On Thu, May 2, 2019 at 3:46 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon > > <[1][2]thomas@monjalon.net> > > > wrote: > > > > > > 01/05/2019 21:50, Bruce Richardson: > > > > This set of changes fixes warnings seen when compiling DPDK > > on > > > Fedora 30. > > > > In most cases these warnings appear to be false positives, > > which > > > means we > > > > have the option to just disable the warning. Because the > > changes > > > required > > > > to the code to silence the warnings are fairly small I've > > chosen > > > in all cases > > > > to change the code rather than disable the warnings, but > > I'm open > > > to doing > > > > the opposite if it's felt it's a better solution. [One > > thing I > > > didn't like > > > > about disabling the warnings is that the disabling flags > > are not > > > supported > > > > by clang, so adding them involves compiler checks :-(] > > > > > > > > NOTE: this set does not cover all warnings with GCC9, but > > it does > > > cover > > > > those seen when building with meson. There is still one > > warning > > > disable > > > > flag needed when building with make, which will need a > > follow-on > > > set to > > > > fix. > > > > > > > > Bruce Richardson (4): > > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > > bus/fslmc: fix printf of null pointer > > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > > Cc: [2][3]stable@dpdk.org > > > Applied, thanks > > > > > > I had a comment on patch 2, and the bigger problem is > > > -Waddress-of-packed-member. > > > The quicker solution for now is to downgrade it to warning only > > so that > > > we can fix the parts later rather than globally disable it. > > > -- > > Well, it is already a warning, it's just that with make we build by > > default > > with -Werror when building from git. > > > > Err, why don't we have -Werror for meson ? > > > > Because it's generally not a good idea to use -Werror by default. However, > the test-meson-build script (which we should all be using for test > compilation before upstreaming) sets it for all builds. > Yes ok, so that old releases still build on newer toolchains. As for the test-meson-builds.sh and test-build.sh scripts, they are still widely unknown except by maintainers. But at least, the ci build script would catch the errors, since it configures with "meson build --werror -Dexamples=all $OPTS"
On Thu, May 02, 2019 at 03:53:36PM +0200, David Marchand wrote: > On Thu, May 2, 2019 at 3:46 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson > > <[1][2]bruce.richardson@intel.com> wrote: > > > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand > wrote: > > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon > > <[1][2][3]thomas@monjalon.net> > > > wrote: > > > > > > 01/05/2019 21:50, Bruce Richardson: > > > > This set of changes fixes warnings seen when > compiling DPDK > > on > > > Fedora 30. > > > > In most cases these warnings appear to be false > positives, > > which > > > means we > > > > have the option to just disable the warning. Because > the > > changes > > > required > > > > to the code to silence the warnings are fairly small > I've > > chosen > > > in all cases > > > > to change the code rather than disable the warnings, > but > > I'm open > > > to doing > > > > the opposite if it's felt it's a better solution. > [One > > thing I > > > didn't like > > > > about disabling the warnings is that the disabling > flags > > are not > > > supported > > > > by clang, so adding them involves compiler checks > :-(] > > > > > > > > NOTE: this set does not cover all warnings with > GCC9, but > > it does > > > cover > > > > those seen when building with meson. There is still > one > > warning > > > disable > > > > flag needed when building with make, which will need > a > > follow-on > > > set to > > > > fix. > > > > > > > > Bruce Richardson (4): > > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > > bus/fslmc: fix printf of null pointer > > > > raw/skeleton_rawdev: fix warnings with GCC 9 on > Fedora 30 > > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora > 30 > > > Cc: [2][3][4]stable@dpdk.org > > > Applied, thanks > > > > > > I had a comment on patch 2, and the bigger problem is > > > -Waddress-of-packed-member. > > > The quicker solution for now is to downgrade it to > warning only > > so that > > > we can fix the parts later rather than globally disable > it. > > > -- > > Well, it is already a warning, it's just that with make we > build by > > default > > with -Werror when building from git. > > > > Err, why don't we have -Werror for meson ? > > > Because it's generally not a good idea to use -Werror by default. > However, > the test-meson-build script (which we should all be using for test > compilation before upstreaming) sets it for all builds. > > Yes ok, so that old releases still build on newer toolchains. > As for the test-meson-builds.sh and test-build.sh scripts, they are > still widely unknown except by maintainers. > But at least, the ci build script would catch the errors, since it > configures with "meson build --werror -Dexamples=all $OPTS" > -- Yep, that's the idea. So long as it's easy enough for maintainers and CI to use werror, we should be covered.