mbox series

[v6,0/2] app/pdump: enhance to support unique cores

Message ID 20190404085515.15789-1-vipin.varghese@intel.com (mailing list archive)
Headers
Series app/pdump: enhance to support unique cores |

Message

Varghese, Vipin April 4, 2019, 8:55 a.m. UTC
  The patch series enhances application to support pdump capture to run
on unique cores.

Motivation
==========

DPDK pdump capture tool currently runs as secondary on the default core 0.
For all --pdump, core 0 iterates and capture packets. This leads to drops
and delay in the capture. This introduces skew in result and performance
bottleneck.

In order to allow --pdump to unique cores, the pdump application has to be
support multi-core in EAL arguments and each --pdump has to be mapped to
unique cores.

Status
======

 - Default c_flag option is removed.
 - with option --multi, the application can run on unique cores.

Change Log:
===========

V6:
 - change MACRO value - David Marchand
 - use MACRO in usage function - David Marchand
 - correct spelling in documentation - Reshma Pathan

V5:
 - Re-use MACRO and replace strncmp - David Marchand

V4:
 - spelling correction - Reshma Pathan
 - remove c_falg - Reshma Pathan

V3:
 - correct the parse_usage - Vipin Varghese
 - add change log - Vipin Varghese

V2:
 - Replace option '-c' to '-l' - Keith Wiles

Vipin Varghese (2):
  app/pdump: remove core restriction
  app/pdump: enhance to support multi-core capture

 app/pdump/main.c           | 113 +++++++++++++++++++++++++++----------
 doc/guides/tools/pdump.rst |   8 ++-
 2 files changed, 91 insertions(+), 30 deletions(-)

Future:
=======
 - Ehance multi mode, allow master to stop --pdump for desired file size.
 - Ehance multi mode, allow to suggest NUMA aware file locations.
 - Stop unique pdump.
  

Comments

Thomas Monjalon April 22, 2019, 7:49 p.m. UTC | #1
04/04/2019 10:55, Vipin Varghese:
> The patch series enhances application to support pdump capture to run
> on unique cores.
> 
> Motivation
> ==========
> 
> DPDK pdump capture tool currently runs as secondary on the default core 0.
> For all --pdump, core 0 iterates and capture packets. This leads to drops
> and delay in the capture. This introduces skew in result and performance
> bottleneck.
> 
> In order to allow --pdump to unique cores, the pdump application has to be
> support multi-core in EAL arguments and each --pdump has to be mapped to
> unique cores.

Applied, thanks