| Message ID | 20190417134946.1250-1-xiaolong.ye@intel.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 934571B627; Wed, 17 Apr 2019 15:55:36 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C42F61B5FF for <dev@dpdk.org>; Wed, 17 Apr 2019 15:55:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 06:55:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,362,1549958400"; d="scan'208";a="151639757" Received: from yexl-server.sh.intel.com ([10.67.110.206]) by orsmga002.jf.intel.com with ESMTP; 17 Apr 2019 06:55:32 -0700 From: Xiaolong Ye <xiaolong.ye@intel.com> To: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, David Marchand <david.marchand@redhat.com> Cc: Qi Zhang <qi.z.zhang@intel.com>, Karlsson Magnus <magnus.karlsson@intel.com>, Topel Bjorn <bjorn.topel@intel.com>, Xiaolong Ye <xiaolong.ye@intel.com> Date: Wed, 17 Apr 2019 21:49:42 +0800 Message-Id: <20190417134946.1250-1-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <CAJFAV8y=fHuFWrbuH7fHB3kAHxiQMexmPSKvN+4v1nKVv3QAcg@mail.gmail.com> References: <CAJFAV8y=fHuFWrbuH7fHB3kAHxiQMexmPSKvN+4v1nKVv3QAcg@mail.gmail.com> Subject: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series | some fixes for AF_XDP pmd | |
Message
Xiaolong Ye
April 17, 2019, 1:49 p.m. UTC
This patchset provides some fixes to af_xdp pmd, at first, I just added a simple error handling when Tx queue allocation fails, then David suggested a better way to do it and pointed out the inconsistent issue of reserve/submit ops (for Tx queue) and peek/release ops (for Rx queue), the third patch addressed this. v4 changes: - remove unnecessary mtu valid check in eth_dev_mtu_set - add Reported-by and Reviewed-by tags of David v3 changes: - address David's review comments - add one patch to specify the mtu range - add one fix patch for typo v2 changes: - adopt David's suggestion to refactor the code Xiaolong Ye (4): net/af_xdp: enqueue buf ring when allocate Tx queue fails net/af_xdp: specify minimal and maximal MTU net/af_xdp: make reserve/submit peek/release consistent net/af_xdp: fix typos in Rx function drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- 1 file changed, 46 insertions(+), 41 deletions(-)
Comments
On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye <xiaolong.ye@intel.com> wrote: > This patchset provides some fixes to af_xdp pmd, at first, I just added > a simple error handling when Tx queue allocation fails, then David > suggested a better way to do it and pointed out the inconsistent issue > of reserve/submit ops (for Tx queue) and peek/release ops (for Rx > queue), the third patch addressed this. > > v4 changes: > > - remove unnecessary mtu valid check in eth_dev_mtu_set > - add Reported-by and Reviewed-by tags of David > > v3 changes: > > - address David's review comments > - add one patch to specify the mtu range > - add one fix patch for typo > > v2 changes: > > - adopt David's suggestion to refactor the code > > Xiaolong Ye (4): > net/af_xdp: enqueue buf ring when allocate Tx queue fails > net/af_xdp: specify minimal and maximal MTU > net/af_xdp: make reserve/submit peek/release consistent > net/af_xdp: fix typos in Rx function > > drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- > 1 file changed, 46 insertions(+), 41 deletions(-) > > -- > 2.17.1 > > LGTM. Thanks Xiaolong.
On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye <xiaolong.ye@intel.com> wrote: > >> This patchset provides some fixes to af_xdp pmd, at first, I just added >> a simple error handling when Tx queue allocation fails, then David >> suggested a better way to do it and pointed out the inconsistent issue >> of reserve/submit ops (for Tx queue) and peek/release ops (for Rx >> queue), the third patch addressed this. >> >> v4 changes: >> >> - remove unnecessary mtu valid check in eth_dev_mtu_set >> - add Reported-by and Reviewed-by tags of David >> >> v3 changes: >> >> - address David's review comments >> - add one patch to specify the mtu range >> - add one fix patch for typo >> >> v2 changes: >> >> - adopt David's suggestion to refactor the code >> >> Xiaolong Ye (4): >> net/af_xdp: enqueue buf ring when allocate Tx queue fails >> net/af_xdp: specify minimal and maximal MTU >> net/af_xdp: make reserve/submit peek/release consistent >> net/af_xdp: fix typos in Rx function >> >> drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- >> 1 file changed, 46 insertions(+), 41 deletions(-) >> >> -- >> 2.17.1 >> >> >LGTM. >Thanks Xiaolong. Thanks a lot for your guidance. :) > > >-- >David Marchand
On 4/17/2019 3:02 PM, David Marchand wrote: > On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye <xiaolong.ye@intel.com > <mailto:xiaolong.ye@intel.com>> wrote: > > This patchset provides some fixes to af_xdp pmd, at first, I just added > a simple error handling when Tx queue allocation fails, then David > suggested a better way to do it and pointed out the inconsistent issue > of reserve/submit ops (for Tx queue) and peek/release ops (for Rx > queue), the third patch addressed this. > > v4 changes: > > - remove unnecessary mtu valid check in eth_dev_mtu_set > - add Reported-by and Reviewed-by tags of David > > v3 changes: > > - address David's review comments > - add one patch to specify the mtu range > - add one fix patch for typo > > v2 changes: > > - adopt David's suggestion to refactor the code > > Xiaolong Ye (4): > net/af_xdp: enqueue buf ring when allocate Tx queue fails > net/af_xdp: specify minimal and maximal MTU > net/af_xdp: make reserve/submit peek/release consistent > net/af_xdp: fix typos in Rx function > > drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- > 1 file changed, 46 insertions(+), 41 deletions(-) > > -- > 2.17.1 > > > LGTM. > Thanks Xiaolong. Series applied to dpdk-next-net/master, thanks.