| Message ID | 1545200580-15467-1-git-send-email-arybchenko@solarflare.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59BC21BBFB; Wed, 19 Dec 2018 07:23:29 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 4288C1B698 for <dev@dpdk.org>; Wed, 19 Dec 2018 07:23:23 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 21FB48005E; Wed, 19 Dec 2018 06:23:22 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 18 Dec 2018 22:23:18 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 18 Dec 2018 22:23:18 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id wBJ6NGoP003346; Wed, 19 Dec 2018 06:23:16 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id DD9321616EF; Wed, 19 Dec 2018 06:23:16 +0000 (GMT) From: Andrew Rybchenko <arybchenko@solarflare.com> To: Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com> CC: <dev@dpdk.org> Date: Wed, 19 Dec 2018 06:22:57 +0000 Message-ID: <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24296.005 X-TM-AS-Result: No-0.519200-4.000000-10 X-TMASE-MatchedRID: GJKkRx1/YvBDeuA2fujoFTnI52876vPfuftX4oH7dy5XOVLYPzCF8KPF jJEFr+olAmPpbGBYlhvkwjHXXC/4I66NVEWSRWybq74K/kDrhcqsm8AN34nPfevq87i5j5PxhQR 2awDMmivyNTNRaWBEdJN1JFeUKeMEiOOUXfTkScBZSbxIRLLN37zfneGoTKOTWoC08z/YUWKUTG VAhB5EbQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.519200-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24296.005 X-MDID: 1545200602-Hqi4M9gr3lrh Subject: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
ethdev: document more retained across restart
|
|
Message
Andrew Rybchenko
Dec. 19, 2018, 6:22 a.m. UTC
The patch series tries to improve documentation of what is retained across default restart. Andrew Rybchenko (3): ethdev: advertise MTU as retained across device stop/start ethdev: advertise default MAC as retained on device restart ethdev: highlight that all-multicast is retained on restart lib/librte_ethdev/rte_ethdev.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Comments
On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > The patch series tries to improve documentation of what is retained > across default restart. Overall makes sense to add below items into retained list, only concern if is there any PMD conflicts with these information, they should either updated with this patch or at least notified about expectation change. > > Andrew Rybchenko (3): > ethdev: advertise MTU as retained across device stop/start > ethdev: advertise default MAC as retained on device restart > ethdev: highlight that all-multicast is retained on restart > > lib/librte_ethdev/rte_ethdev.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >
On 1/8/19 5:52 PM, Ferruh Yigit wrote: > On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: >> The patch series tries to improve documentation of what is retained >> across default restart. > Overall makes sense to add below items into retained list, only concern if is > there any PMD conflicts with these information, they should either updated with > this patch or at least notified about expectation change. From my point of view it is just clarification of the required behaviour. MTU is required because of flag which may be used to advertise that it is impossible to change in started state (otherwise the behaviour for different PMDs will be absolutely different). Default MAC is just cosmetics because of MAC address list is already mentioned and the only goal is to highlight since these are different features from the feature list point of view. All-multicast is a part of Rx mode. In fact I recall that net/bonding does not preserve all-multicast (CC maintainers). If there is an agreement to fix it, I can take a look - it should not be hard to fix. In general I think that notification is sufficient in this case. >> Andrew Rybchenko (3): >> ethdev: advertise MTU as retained across device stop/start >> ethdev: advertise default MAC as retained on device restart >> ethdev: highlight that all-multicast is retained on restart >> >> lib/librte_ethdev/rte_ethdev.h | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >>
On 1/9/19 2:15 AM, Andrew Rybchenko wrote: On 1/8/19 5:52 PM, Ferruh Yigit wrote: On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: The patch series tries to improve documentation of what is retained across default restart. Overall makes sense to add below items into retained list, only concern if is there any PMD conflicts with these information, they should either updated with this patch or at least notified about expectation change. From my point of view it is just clarification of the required behaviour. MTU is required because of flag which may be used to advertise that it is impossible to change in started state (otherwise the behaviour for different PMDs will be absolutely different). Default MAC is just cosmetics because of MAC address list is already mentioned and the only goal is to highlight since these are different features from the feature list point of view. All-multicast is a part of Rx mode. In fact I recall that net/bonding does not preserve all-multicast (CC maintainers). If there is an agreement to fix it, I can take a look - it should not be hard to fix. I don't think bonding does anything particular because the all_multicast state of the bonding PMD isn't related to the slaves. Currently, it's up to the applications to correctly configure multicast on the slaves. On a side note, I don't think the registered multicast addresses are preserved across PMD stop/start (unless this has been fixed recently). In general I think that notification is sufficient in this case. Andrew Rybchenko (3): ethdev: advertise MTU as retained across device stop/start ethdev: advertise default MAC as retained on device restart ethdev: highlight that all-multicast is retained on restart lib/librte_ethdev/rte_ethdev.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
On 1/10/19 5:03 AM, WILLIAMS, CHARLES J wrote: > > > On 1/9/19 2:15 AM, Andrew Rybchenko wrote: >> On 1/8/19 5:52 PM, Ferruh Yigit wrote: >>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: >>>> The patch series tries to improve documentation of what is retained >>>> across default restart. >>> Overall makes sense to add below items into retained list, only concern if is >>> there any PMD conflicts with these information, they should either updated with >>> this patch or at least notified about expectation change. >> >> From my point of view it is just clarification of the required behaviour. >> MTU is required because of flag which may be used to advertise that >> it is impossible to change in started state (otherwise the behaviour for >> different PMDs will be absolutely different). >> Default MAC is just cosmetics because of MAC address list is already >> mentioned and the only goal is to highlight since these are different >> features from the feature list point of view. >> All-multicast is a part of Rx mode. >> >> In fact I recall that net/bonding does not preserve all-multicast >> (CC maintainers). If there is an agreement to fix it, I can take >> a look - it should not be hard to fix. > > I don't think bonding does anything particular because the > all_multicast state of the bonding PMD isn't related to the slaves. > Currently, it's up to the applications to correctly configure > multicast on the slaves. > May be I'm wrong but I think all-multicast handling should be similar to promiscuous mode handling in bonding: for all slaves in the case of round-robin, balance and broadcast, primary only in the case of active backup, TLB and ALB and when slave is added/removed in 802.3ad case. > On a side note, I don't think the registered multicast addresses are > preserved across PMD stop/start (unless this has been fixed recently). > Yes, that's true, but I think it is separate story. >> >> In general I think that notification is sufficient in this case. >> >>>> Andrew Rybchenko (3): >>>> ethdev: advertise MTU as retained across device stop/start >>>> ethdev: advertise default MAC as retained on device restart >>>> ethdev: highlight that all-multicast is retained on restart >>>> >>>> lib/librte_ethdev/rte_ethdev.h | 6 ++++-- >>>> 1 file changed, 4 insertions(+), 2 deletions(-) >>>> >>
On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > The patch series tries to improve documentation of what is retained > across default restart. > > Andrew Rybchenko (3): > ethdev: advertise MTU as retained across device stop/start > ethdev: advertise default MAC as retained on device restart > ethdev: highlight that all-multicast is retained on restart > Hi Thomas, Is there any objection on this patchset? If not I am planning to merge it. Thanks, ferruh
19/03/2019 14:21, Yigit, Ferruh: > On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > > The patch series tries to improve documentation of what is retained > > across default restart. > > > > Andrew Rybchenko (3): > > ethdev: advertise MTU as retained across device stop/start > > ethdev: advertise default MAC as retained on device restart > > ethdev: highlight that all-multicast is retained on restart > > > > Hi Thomas, > > Is there any objection on this patchset? If not I am planning to merge it. No objection, more clarification in doxygen is always good.
On 3/20/2019 2:26 PM, Thomas Monjalon wrote: > 19/03/2019 14:21, Yigit, Ferruh: >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: >>> The patch series tries to improve documentation of what is retained >>> across default restart. >>> >>> Andrew Rybchenko (3): >>> ethdev: advertise MTU as retained across device stop/start >>> ethdev: advertise default MAC as retained on device restart >>> ethdev: highlight that all-multicast is retained on restart >>> >> >> Hi Thomas, >> >> Is there any objection on this patchset? If not I am planning to merge it. > > No objection, more clarification in doxygen is always good. > This may be defining the behavior more than clarification. Can I add your explicit ACK?
20/03/2019 16:25, Ferruh Yigit: > On 3/20/2019 2:26 PM, Thomas Monjalon wrote: > > 19/03/2019 14:21, Yigit, Ferruh: > >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > >>> The patch series tries to improve documentation of what is retained > >>> across default restart. > >>> > >>> Andrew Rybchenko (3): > >>> ethdev: advertise MTU as retained across device stop/start > >>> ethdev: advertise default MAC as retained on device restart > >>> ethdev: highlight that all-multicast is retained on restart > >>> > >> > >> Hi Thomas, > >> > >> Is there any objection on this patchset? If not I am planning to merge it. > > > > No objection, more clarification in doxygen is always good. > > > > This may be defining the behavior more than clarification. > > Can I add your explicit ACK? Acked-by: Thomas Monjalon <thomas@monjalon.net>
On 3/20/2019 3:32 PM, Thomas Monjalon wrote: > 20/03/2019 16:25, Ferruh Yigit: >> On 3/20/2019 2:26 PM, Thomas Monjalon wrote: >>> 19/03/2019 14:21, Yigit, Ferruh: >>>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: >>>>> The patch series tries to improve documentation of what is retained >>>>> across default restart. >>>>> >>>>> Andrew Rybchenko (3): >>>>> ethdev: advertise MTU as retained across device stop/start >>>>> ethdev: advertise default MAC as retained on device restart >>>>> ethdev: highlight that all-multicast is retained on restart >>>>> >>>> >>>> Hi Thomas, >>>> >>>> Is there any objection on this patchset? If not I am planning to merge it. >>> >>> No objection, more clarification in doxygen is always good. >>> >> >> This may be defining the behavior more than clarification. >> >> Can I add your explicit ACK? > > Acked-by: Thomas Monjalon <thomas@monjalon.net> > Series applied to dpdk-next-net/master, thanks.