[v1,08/11] app/test-pmd: add IPN3KE support for testpmd
Checks
Commit Message
Add IPN3KE support for testpmd
Signed-off-by: Rosen Xu <rosen.xu@intel.com>
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
app/test-pmd/Makefile | 4 ++++
1 file changed, 4 insertions(+)
Comments
On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu <rosen.xu@intel.com> wrote:
> Add IPN3KE support for testpmd
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> app/test-pmd/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> index d5258ea..a6b6f6f 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
> LDLIBS += -lrte_pmd_i40e
> endif
>
> +ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
> +LDLIBS += -lrte_pmd_ipn3ke
> +endif
> +
> ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
> LDLIBS += -lrte_pmd_bnxt
> endif
>
I am a bit lost.
Why is it needed ?
Hi,
From: David Marchand [mailto:david.marchand@redhat.com]
Sent: Thursday, February 28, 2019 16:37
To: Xu, Rosen <rosen.xu@intel.com>
Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei, Andy <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>; Zhang, Zhang <zhang.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd
On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu <rosen.xu@intel.com<mailto:rosen.xu@intel.com>> wrote:
Add IPN3KE support for testpmd
Signed-off-by: Rosen Xu <rosen.xu@intel.com<mailto:rosen.xu@intel.com>>
Signed-off-by: Andy Pei <andy.pei@intel.com<mailto:andy.pei@intel.com>>
---
app/test-pmd/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index d5258ea..a6b6f6f 100644
--- a/app/test-pmd/Makefile
+++ b/app/test-pmd/Makefile
@@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
LDLIBS += -lrte_pmd_i40e
endif
+ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
+LDLIBS += -lrte_pmd_ipn3ke
+endif
+
ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
LDLIBS += -lrte_pmd_bnxt
endif
I am a bit lost.
Why is it needed ?
Involve IPN3KE in testpmd, for testpmd is widely used in NIC.
--
David Marchand
On Thu, Feb 28, 2019 at 9:45 AM Xu, Rosen <rosen.xu@intel.com> wrote:
> Hi,
>
>
>
> *From:* David Marchand [mailto:david.marchand@redhat.com]
> *Sent:* Thursday, February 28, 2019 16:37
> *To:* Xu, Rosen <rosen.xu@intel.com>
> *Cc:* dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang,
> Tianfei <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei,
> Andy <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>;
> Zhang, Zhang <zhang.zhang@intel.com>
> *Subject:* Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE
> support for testpmd
>
>
>
>
>
> On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu <rosen.xu@intel.com> wrote:
>
> Add IPN3KE support for testpmd
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> app/test-pmd/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> index d5258ea..a6b6f6f 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
> LDLIBS += -lrte_pmd_i40e
> endif
>
> +ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
> +LDLIBS += -lrte_pmd_ipn3ke
> +endif
> +
> ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
> LDLIBS += -lrte_pmd_bnxt
> endif
>
>
>
> I am a bit lost.
>
> Why is it needed ?
>
> Involve IPN3KE in testpmd, for testpmd is widely used in NIC.
>
The drivers declared in this makefile are there because testpmd directly
calls private apis of those drivers.
Bis repetita, why is linking to ipn3ke needed here ?
Hi,
From: David Marchand [mailto:david.marchand@redhat.com]
Sent: Thursday, February 28, 2019 16:48
To: Xu, Rosen <rosen.xu@intel.com>
Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei, Andy <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>; Zhang, Zhang <zhang.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd
On Thu, Feb 28, 2019 at 9:45 AM Xu, Rosen <rosen.xu@intel.com<mailto:rosen.xu@intel.com>> wrote:
Hi,
From: David Marchand [mailto:david.marchand@redhat.com<mailto:david.marchand@redhat.com>]
Sent: Thursday, February 28, 2019 16:37
To: Xu, Rosen <rosen.xu@intel.com<mailto:rosen.xu@intel.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>; Yigit, Ferruh <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>>; Zhang, Tianfei <tianfei.zhang@intel.com<mailto:tianfei.zhang@intel.com>>; Wei, Dan <dan.wei@intel.com<mailto:dan.wei@intel.com>>; Pei, Andy <andy.pei@intel.com<mailto:andy.pei@intel.com>>; Yang, Qiming <qiming.yang@intel.com<mailto:qiming.yang@intel.com>>; Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>>; Chen, Santos <santos.chen@intel.com<mailto:santos.chen@intel.com>>; Zhang, Zhang <zhang.zhang@intel.com<mailto:zhang.zhang@intel.com>>
Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd
On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu <rosen.xu@intel.com<mailto:rosen.xu@intel.com>> wrote:
Add IPN3KE support for testpmd
Signed-off-by: Rosen Xu <rosen.xu@intel.com<mailto:rosen.xu@intel.com>>
Signed-off-by: Andy Pei <andy.pei@intel.com<mailto:andy.pei@intel.com>>
---
app/test-pmd/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index d5258ea..a6b6f6f 100644
--- a/app/test-pmd/Makefile
+++ b/app/test-pmd/Makefile
@@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
LDLIBS += -lrte_pmd_i40e
endif
+ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
+LDLIBS += -lrte_pmd_ipn3ke
+endif
+
ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
LDLIBS += -lrte_pmd_bnxt
endif
I am a bit lost.
Why is it needed ?
Involve IPN3KE in testpmd, for testpmd is widely used in NIC.
The drivers declared in this makefile are there because testpmd directly calls private apis of those drivers.
Bis repetita, why is linking to ipn3ke needed here ?
It will be fixed in v2 patch. Thanks.
--
David Marchand
On 2/28/2019 7:13 AM, Rosen Xu wrote:
> Add IPN3KE support for testpmd
I think it is already decided to remove this patch, +1.
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> app/test-pmd/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> index d5258ea..a6b6f6f 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
> LDLIBS += -lrte_pmd_i40e
> endif
>
> +ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
> +LDLIBS += -lrte_pmd_ipn3ke
> +endif
> +
> ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
> LDLIBS += -lrte_pmd_bnxt
> endif
>
> -----Original Message-----
> From: Yigit, Ferruh [mailto:ferruh.yigit@linux.intel.com]
> Sent: Wednesday, March 06, 2019 20:46
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei, Andy
> <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>;
> Zhang, Zhang <zhang.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support
> for testpmd
>
> On 2/28/2019 7:13 AM, Rosen Xu wrote:
> > Add IPN3KE support for testpmd
>
> I think it is already decided to remove this patch, +1.
Okay
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > ---
> > app/test-pmd/Makefile | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index
> > d5258ea..a6b6f6f 100644
> > --- a/app/test-pmd/Makefile
> > +++ b/app/test-pmd/Makefile
> > @@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y) LDLIBS
> +=
> > -lrte_pmd_i40e endif
> >
> > +ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
> > +LDLIBS += -lrte_pmd_ipn3ke
> > +endif
> > +
> > ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y) LDLIBS += -lrte_pmd_bnxt
> > endif
> >
@@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
LDLIBS += -lrte_pmd_i40e
endif
+ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
+LDLIBS += -lrte_pmd_ipn3ke
+endif
+
ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
LDLIBS += -lrte_pmd_bnxt
endif