app/testpmd: fix Tx metadata show command
Checks
Commit Message
Function cmd_config_tx_metadata_specific_parsed() takes input value,
applies rte_cpu_to_be_32() on it, and stores it for Tx use.
Function cmd_show_tx_metadata_parsed() displays the stored value as is.
This patch modifies function cmd_show_tx_metadata_parsed(), to apply
rte_be_to_cpu_32() on the stored value before displaying it.
Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item")
Cc: dekelp@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 1/22/2019 3:16 PM, Dekel Peled wrote:
> Function cmd_config_tx_metadata_specific_parsed() takes input value,
> applies rte_cpu_to_be_32() on it, and stores it for Tx use.
> Function cmd_show_tx_metadata_parsed() displays the stored value as is.
>
> This patch modifies function cmd_show_tx_metadata_parsed(), to apply
> rte_be_to_cpu_32() on the stored value before displaying it.
>
> Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item")
> Cc: dekelp@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -18455,7 +18455,7 @@ struct cmd_show_tx_metadata_result {
}
if (!strcmp(res->cmd_keyword, "tx_metadata")) {
printf("Port %u tx_metadata: %u\n", res->cmd_pid,
- ports[res->cmd_pid].tx_metadata);
+ rte_be_to_cpu_32(ports[res->cmd_pid].tx_metadata));
}
}