Message ID | 20190109145015.3010-1-i.maximets@samsung.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8974F1B484; Wed, 9 Jan 2019 15:50:24 +0100 (CET) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 054371B483 for <dev@dpdk.org>; Wed, 9 Jan 2019 15:50:24 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190109145023euoutp018228480fd51767c32810e91d0bc15a66~4NZ2p8CKB2918329183euoutp01S for <dev@dpdk.org>; Wed, 9 Jan 2019 14:50:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190109145023euoutp018228480fd51767c32810e91d0bc15a66~4NZ2p8CKB2918329183euoutp01S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1547045423; bh=7croShQgZfJYychEDOn9k1s8/X6Aadh85WNi7R3Qb/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qLv1z3Aj6oTRjcXAkPqFQR668m/VxL+iTpW/Z7Auq/GRN0D+iCXAstcRP2smZ3MYU LfnF/Sjc8A9zL/v+rUZ8Ximp69rsO7UcL88Hsw0PXKEQYGm7oyBr+ZD3pKN7Bv2gfK b1OAz4Es71rtHarZW3TnAyGZRSYB5UsZPi+Rjvxk= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190109145022eucas1p1b85a882b97bfff8eeaeb948ce511d3a9~4NZ2O8EoI2685626856eucas1p1W; Wed, 9 Jan 2019 14:50:22 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 4B.D4.04441.E2A063C5; Wed, 9 Jan 2019 14:50:22 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190109145021eucas1p1bfe194ffafaaaa5df62243c92b2ed6cd~4NZ1TPDBq2861828618eucas1p17; Wed, 9 Jan 2019 14:50:21 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190109145021eusmtrp15183820ec0e8853675a132a97d163c17~4NZ1ETh3I0337303373eusmtrp1W; Wed, 9 Jan 2019 14:50:21 +0000 (GMT) X-AuditID: cbfec7f2-5c9ff70000001159-49-5c360a2e8b1f Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 6D.70.04284.D2A063C5; Wed, 9 Jan 2019 14:50:21 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190109145020eusmtip2b8767977ef64fe49a28d5eb926be71f0~4NZ0MIm3H2099420994eusmtip2S; Wed, 9 Jan 2019 14:50:20 +0000 (GMT) From: Ilya Maximets <i.maximets@samsung.com> To: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, Xiao Wang <xiao.w.wang@intel.com> Cc: Tiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>, jfreimann@redhat.com, Jason Wang <jasowang@redhat.com>, xiaolong.ye@intel.com, alejandro.lucero@netronome.com, Ilya Maximets <i.maximets@samsung.com> Date: Wed, 9 Jan 2019 17:50:12 +0300 Message-Id: <20190109145015.3010-1-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181226163712.31596-1-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsWy7djPc7p6XGYxBr1T5C3OfVrGZPHu03Ym iyvtP9ktll36zGRxbs1SFotjnXtYLP7/esVqsbXhP5PF/ueH2S3+vDG12HxxEpMDt8evBUtZ PRbvecnkMb37IbPH+31X2Tz6tqxiDGCN4rJJSc3JLEst0rdL4MrY+Gg9U8Ehjoplt4+yNTB+ ZOti5OSQEDCRmH99EZDNxSEksIJRYt+zLawQzhdGiVUTTrBAOJ8ZJY6c+AnXcvzLIaiq5YwS m7ZuZIJwfjBKHH92ghmkik1AR+LU6iOMIAkRgW5GiVdPP4NtYRZ4zijx4ss9dpAqYQFXiX+v 97CA2CwCqhIf5/WAxXkFrCSaXu5ih9gnL7F6wwGwqZwCNhLH++ezgwySEOhml/j55SATRJGL xMq3J1ggbGGJV8e3QDXLSJye3AMVr5e43/KSEaK5g1Fi+qF/UM32EltenwNq4AA6T1Ni/S59 EFNCwFHi4SQbCJNP4sZbQZBiZiBz0rbpzBBhXomONiGIGSoSvw8uZ4awpSRuvvsMdYCHxKTf 7xghAdTPKNHz+CrbBEb5WQi7FjAyrmIUTy0tzk1PLTbMSy3XK07MLS7NS9dLzs/dxAhMKKf/ Hf+0g/HrpaRDjAIcjEo8vAn/TGOEWBPLiitzDzFKcDArifCq3zGJEeJNSaysSi3Kjy8qzUkt PsQozcGiJM5bzfAgWkggPbEkNTs1tSC1CCbLxMEp1cA4KT1rcvq6I907IzQ95kbO3ndy2sWt XWbVH8NVrWSWlc3h3sBjUOox8+RWlZWFisfn/X1XqSlsrCRxxOGGpczUE3K8h38eFv0n8DtB 94DORv5JtZdebM59X/RIUfcek3vwbJZ1JUfO6IoufVKuXryW4cKDx736ggxsrY/+qT6e7aR0 5HxIaNlyJZbijERDLeai4kQA4P/triQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xe7q6XGYxBq/Py1ic+7SMyeLdp+1M Flfaf7JbLLv0mcni3JqlLBbHOvewWPz/9YrVYmvDfyaL/c8Ps1v8eWNqsfniJCYHbo9fC5ay eize85LJY3r3Q2aP9/uusnn0bVnFGMAapWdTlF9akqqQkV9cYqsUbWhhpGdoaaFnZGKpZ2hs HmtlZKqkb2eTkpqTWZZapG+XoJex8dF6poJDHBXLbh9la2D8yNbFyMkhIWAicfzLIVYQW0hg KaPEmu5AiLiUxI9fF1ghbGGJP9e6gOq5gGq+MUo0PWxkAUmwCehInFp9hBEkISLQzyix+/pN ZhCHWeAto0TfpBvsIFXCAq4S/17vAetgEVCV+DivByzOK2Al0fRyFzvECnmJ1RsOMIPYnAI2 Esf757NDnGQt8X/xJ6YJjHwLGBlWMYqklhbnpucWG+oVJ+YWl+al6yXn525iBIb3tmM/N+9g vLQx+BCjAAejEg9vwj/TGCHWxLLiytxDjBIczEoivOp3TGKEeFMSK6tSi/Lji0pzUosPMZoC HTWRWUo0OR8Ye3kl8YamhuYWlobmxubGZhZK4rznDSqjhATSE0tSs1NTC1KLYPqYODilGhhD Xbenlehz9svwZM6/uihaOX77+2kxBso7nf4nhK2SfNArHujSaXbMyM1lg6KJfB+TwPZ5u2ZX d/PvaKw/1WqoKXNii37Ec4as7xLsz4xmJoiECFYrvTByeCS+vCOIX+nqj8OzN2WG/s7du9zp HXcg57NM6yNOWu4qDNNXWYn+6cqxcVnkosRSnJFoqMVcVJwIAB9RgRGFAgAA X-CMS-MailID: 20190109145021eucas1p1bfe194ffafaaaa5df62243c92b2ed6cd X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190109145021eucas1p1bfe194ffafaaaa5df62243c92b2ed6cd X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190109145021eucas1p1bfe194ffafaaaa5df62243c92b2ed6cd References: <20181226163712.31596-1-i.maximets@samsung.com> <CGME20190109145021eucas1p1bfe194ffafaaaa5df62243c92b2ed6cd@eucas1p1.samsung.com> Subject: [dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Missing barriers and VIRTIO_F_ORDER_PLATFORM.
|
|
Message
Ilya Maximets
Jan. 9, 2019, 2:50 p.m. UTC
Version 3: * Added 2 patches with fixes for current virtio driver. Not directly connected with the new feature. Version 2: * rebased on current master (packed rings). RFC --> Version 1: * Dropped vendor-specific hack to determine if we need real barriers. * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER to VIRTIO_F_ORDER_PLATFORM is not merged yet: https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html Ilya Maximets (3): net/virtio: add missing barrier before reading the flags net/virtio: update memory ordering comment for vq notify net/virtio: add platform memory ordering feature support drivers/net/virtio/virtio_ethdev.c | 2 ++ drivers/net/virtio/virtio_ethdev.h | 3 +- drivers/net/virtio/virtio_pci.h | 7 ++++ drivers/net/virtio/virtio_rxtx.c | 16 ++++----- drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- 5 files changed, 63 insertions(+), 21 deletions(-)
Comments
On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: > Version 3: > * Added 2 patches with fixes for current virtio driver. > Not directly connected with the new feature. New version shouldn't be reply-to old one really :). But the patches are good I think. Acked-by: Michael S. Tsirkin <mst@redhat.com> > Version 2: > * rebased on current master (packed rings). > > RFC --> Version 1: > * Dropped vendor-specific hack to determine if we need real barriers. > * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. > > Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER > to VIRTIO_F_ORDER_PLATFORM is not merged yet: > https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html > > Ilya Maximets (3): > net/virtio: add missing barrier before reading the flags > net/virtio: update memory ordering comment for vq notify > net/virtio: add platform memory ordering feature support > > drivers/net/virtio/virtio_ethdev.c | 2 ++ > drivers/net/virtio/virtio_ethdev.h | 3 +- > drivers/net/virtio/virtio_pci.h | 7 ++++ > drivers/net/virtio/virtio_rxtx.c | 16 ++++----- > drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- > 5 files changed, 63 insertions(+), 21 deletions(-) > > -- > 2.17.1
On 09.01.2019 17:55, Michael S. Tsirkin wrote: > On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >> Version 3: >> * Added 2 patches with fixes for current virtio driver. >> Not directly connected with the new feature. > > New version shouldn't be reply-to old one really :). It's kind of a common practice and a recommended thing for the dpdk mail-list. At least it was. I'm not doing that on other lists. =) > But the patches are good I think. > > Acked-by: Michael S. Tsirkin <mst@redhat.com> Thanks. > > > >> Version 2: >> * rebased on current master (packed rings). >> >> RFC --> Version 1: >> * Dropped vendor-specific hack to determine if we need real barriers. >> * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. >> >> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER >> to VIRTIO_F_ORDER_PLATFORM is not merged yet: >> https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html >> >> Ilya Maximets (3): >> net/virtio: add missing barrier before reading the flags >> net/virtio: update memory ordering comment for vq notify >> net/virtio: add platform memory ordering feature support >> >> drivers/net/virtio/virtio_ethdev.c | 2 ++ >> drivers/net/virtio/virtio_ethdev.h | 3 +- >> drivers/net/virtio/virtio_pci.h | 7 ++++ >> drivers/net/virtio/virtio_rxtx.c | 16 ++++----- >> drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- >> 5 files changed, 63 insertions(+), 21 deletions(-) >> >> -- >> 2.17.1 > >
On 1/9/2019 3:24 PM, Ilya Maximets wrote: > On 09.01.2019 17:55, Michael S. Tsirkin wrote: >> On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >>> Version 3: >>> * Added 2 patches with fixes for current virtio driver. >>> Not directly connected with the new feature. >> >> New version shouldn't be reply-to old one really :). > > It's kind of a common practice and a recommended thing for the > dpdk mail-list. At least it was. > I'm not doing that on other lists. =) Yes this is something recommended to do. It helps a lot to be able to see all versions and comments in same email thread. > >> But the patches are good I think. >> >> Acked-by: Michael S. Tsirkin <mst@redhat.com> > > Thanks. > >> >> >> >>> Version 2: >>> * rebased on current master (packed rings). >>> >>> RFC --> Version 1: >>> * Dropped vendor-specific hack to determine if we need real barriers. >>> * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. >>> >>> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER >>> to VIRTIO_F_ORDER_PLATFORM is not merged yet: >>> https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html >>> >>> Ilya Maximets (3): >>> net/virtio: add missing barrier before reading the flags >>> net/virtio: update memory ordering comment for vq notify >>> net/virtio: add platform memory ordering feature support >>> >>> drivers/net/virtio/virtio_ethdev.c | 2 ++ >>> drivers/net/virtio/virtio_ethdev.h | 3 +- >>> drivers/net/virtio/virtio_pci.h | 7 ++++ >>> drivers/net/virtio/virtio_rxtx.c | 16 ++++----- >>> drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- >>> 5 files changed, 63 insertions(+), 21 deletions(-) >>> >>> -- >>> 2.17.1 >> >>
On 1/9/19 3:55 PM, Michael S. Tsirkin wrote: > On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >> Version 3: >> * Added 2 patches with fixes for current virtio driver. >> Not directly connected with the new feature. > > New version shouldn't be reply-to old one really :). > But the patches are good I think. > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > > >> Version 2: >> * rebased on current master (packed rings). >> >> RFC --> Version 1: >> * Dropped vendor-specific hack to determine if we need real barriers. >> * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. >> >> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER >> to VIRTIO_F_ORDER_PLATFORM is not merged yet: >> https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html >> >> Ilya Maximets (3): >> net/virtio: add missing barrier before reading the flags >> net/virtio: update memory ordering comment for vq notify >> net/virtio: add platform memory ordering feature support >> >> drivers/net/virtio/virtio_ethdev.c | 2 ++ >> drivers/net/virtio/virtio_ethdev.h | 3 +- >> drivers/net/virtio/virtio_pci.h | 7 ++++ >> drivers/net/virtio/virtio_rxtx.c | 16 ++++----- >> drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- >> 5 files changed, 63 insertions(+), 21 deletions(-) >> >> -- >> 2.17.1 Applied to dpdk-next-virtio/master. Thanks, Maxime