bbdev: add missing APIs to map file

Message ID 1544804523-66689-1-git-send-email-amr.mokhtar@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series bbdev: add missing APIs to map file |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Mokhtar, Amr Dec. 14, 2018, 4:22 p.m. UTC
  some application facing functions are missing from
the map file. these are added by this patch.

Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
---
 lib/librte_bbdev/rte_bbdev_version.map | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Akhil Goyal Dec. 17, 2018, 9:55 a.m. UTC | #1
Hi,

On 12/14/2018 9:52 PM, Amr Mokhtar wrote:
> some application facing functions are missing from
> the map file. these are added by this patch.
>
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
> ---
>   lib/librte_bbdev/rte_bbdev_version.map | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_bbdev/rte_bbdev_version.map b/lib/librte_bbdev/rte_bbdev_version.map
> index d3b81ea..c392f41 100644
> --- a/lib/librte_bbdev/rte_bbdev_version.map
> +++ b/lib/librte_bbdev/rte_bbdev_version.map
> @@ -6,9 +6,13 @@ EXPERIMENTAL {
>   	rte_bbdev_callback_unregister;
>   	rte_bbdev_close;
>   	rte_bbdev_count;
> +	rte_bbdev_dec_op_alloc_bulk;
> +	rte_bbdev_dec_op_free_bulk;
>   	rte_bbdev_dequeue_dec_ops;
>   	rte_bbdev_dequeue_enc_ops;
>   	rte_bbdev_devices;
> +	rte_bbdev_enc_op_alloc_bulk;
> +	rte_bbdev_enc_op_free_bulk
>   	rte_bbdev_enqueue_dec_ops;
>   	rte_bbdev_enqueue_enc_ops;
>   	rte_bbdev_find_next;
I think rte_experimental tag should also be added in the API definition.

I believe this patch should be updated 
(http://patches.dpdk.org/patch/48524/)

-Akhil
  
Akhil Goyal Dec. 18, 2018, 6:46 a.m. UTC | #2
On 12/14/2018 9:52 PM, Amr Mokhtar wrote:
> some application facing functions are missing from
> the map file. these are added by this patch.
>
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
> ---
>   lib/librte_bbdev/rte_bbdev_version.map | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_bbdev/rte_bbdev_version.map b/lib/librte_bbdev/rte_bbdev_version.map
> index d3b81ea..c392f41 100644
> --- a/lib/librte_bbdev/rte_bbdev_version.map
> +++ b/lib/librte_bbdev/rte_bbdev_version.map
> @@ -6,9 +6,13 @@ EXPERIMENTAL {
>   	rte_bbdev_callback_unregister;
>   	rte_bbdev_close;
>   	rte_bbdev_count;
> +	rte_bbdev_dec_op_alloc_bulk;
> +	rte_bbdev_dec_op_free_bulk;
>   	rte_bbdev_dequeue_dec_ops;
>   	rte_bbdev_dequeue_enc_ops;
>   	rte_bbdev_devices;
> +	rte_bbdev_enc_op_alloc_bulk;
> +	rte_bbdev_enc_op_free_bulk
semicolon is also missing.
>   	rte_bbdev_enqueue_dec_ops;
>   	rte_bbdev_enqueue_enc_ops;
>   	rte_bbdev_find_next;
  

Patch

diff --git a/lib/librte_bbdev/rte_bbdev_version.map b/lib/librte_bbdev/rte_bbdev_version.map
index d3b81ea..c392f41 100644
--- a/lib/librte_bbdev/rte_bbdev_version.map
+++ b/lib/librte_bbdev/rte_bbdev_version.map
@@ -6,9 +6,13 @@  EXPERIMENTAL {
 	rte_bbdev_callback_unregister;
 	rte_bbdev_close;
 	rte_bbdev_count;
+	rte_bbdev_dec_op_alloc_bulk;
+	rte_bbdev_dec_op_free_bulk;
 	rte_bbdev_dequeue_dec_ops;
 	rte_bbdev_dequeue_enc_ops;
 	rte_bbdev_devices;
+	rte_bbdev_enc_op_alloc_bulk;
+	rte_bbdev_enc_op_free_bulk
 	rte_bbdev_enqueue_dec_ops;
 	rte_bbdev_enqueue_enc_ops;
 	rte_bbdev_find_next;