[v1] net/tap: invoke probe finish for multiq failure
Checks
Commit Message
In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
has to be invoked for successful device registration.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
---
drivers/net/tap/rte_eth_tap.c | 1 +
1 file changed, 1 insertion(+)
Comments
> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
>
> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
> has to be invoked for successful device registration.
>
Acked-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> ---
> drivers/net/tap/rte_eth_tap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index e7817e896..40911923d 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1848,6 +1848,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
> TAP_LOG(ERR, "Remote feature requires flow support.");
> goto error_exit;
> }
> + rte_eth_dev_probing_finish(dev);
> return 0;
>
> error_remote:
> --
> 2.17.1
>
Regards,
Keith
On 11/7/2018 3:11 PM, Wiles, Keith wrote:
>
>
>> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
>>
>> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
>> has to be invoked for successful device registration.
>>
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
>
> Acked-by: Keith Wiles <keith.wiles@intel.com>
Fixes: fbe90cdd776c ("ethdev: add probing finish function")
Cc: stable@dpdk.org
Applied to dpdk-next-net/master, thanks.
@@ -1848,6 +1848,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
TAP_LOG(ERR, "Remote feature requires flow support.");
goto error_exit;
}
+ rte_eth_dev_probing_finish(dev);
return 0;
error_remote: