Message ID | 1537544182-17823-1-git-send-email-arybchenko@solarflare.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12EF137B0; Fri, 21 Sep 2018 17:36:36 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6E12A2BA3 for <dev@dpdk.org>; Fri, 21 Sep 2018 17:36:35 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 2BD27B80074; Fri, 21 Sep 2018 15:36:34 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 21 Sep 2018 08:36:32 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 21 Sep 2018 08:36:31 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w8LFaTvF025629; Fri, 21 Sep 2018 16:36:29 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 99EBB1626D1; Fri, 21 Sep 2018 16:36:29 +0100 (BST) From: Andrew Rybchenko <arybchenko@solarflare.com> To: Gaetan Rivet <gaetan.rivet@6wind.com> CC: <dev@dpdk.org> Date: Fri, 21 Sep 2018 16:36:19 +0100 Message-ID: <1537544182-17823-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1535730814-24624-1-git-send-email-arybchenko@solarflare.com> References: <1535730814-24624-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24108.005 X-TM-AS-Result: No-5.205400-4.000000-10 X-TMASE-MatchedRID: wlMk1aZ495U/mJEvNFL+dbMjW/sniEQKuftX4oH7dy5UjspoiX02F80x L7KNFoATqDnwcWxGyWYOiVgo5BJRrbFRE99Bhzw4yeVujmXuYYVflOpBqBHTt52iHEDAUb20o8W MkQWv6iUoTQl7wNH8Pg1fA1QHegDv3QfwsVk0UbtuRXh7bFKB7o4aKeWrQ6SRhGlJSHg6BXt89U cNRCySI1hUqbGtp6grPpCuffGH9zI= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.205400-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24108.005 X-MDID: 1537544194-CO8wE45nTvwG Subject: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/failsafe: support multicast MAC address set
|
|
Message
Andrew Rybchenko
Sept. 21, 2018, 3:36 p.m. UTC
v3: - move apply on sync to fs_eth_dev_conf_apply() to apply to a new subdevice only - use ethdev API to apply to sub-device on sync - remove unnecessary check the same pointer from the method implementation in failsafe v2: - fix setting of zero addresses since rte_realloc() returns NULL Evgeny Im (2): net/failsafe: remove not supported multicast MAC filter net/failsafe: support multicast address list set doc/guides/rel_notes/release_18_11.rst | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ drivers/net/failsafe/failsafe_private.h | 2 + 5 files changed, 71 insertions(+)
Comments
v3: - move apply on sync to fs_eth_dev_conf_apply() to apply to a new subdevice only - use ethdev API to apply to sub-device on sync - remove unnecessary check the same pointer from the method implementation in failsafe v2: - fix setting of zero addresses since rte_realloc() returns NULL Evgeny Im (2): net/failsafe: remove not supported multicast MAC filter net/failsafe: support multicast address list set doc/guides/rel_notes/release_18_11.rst | 7 ++++ drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ drivers/net/failsafe/failsafe_private.h | 2 + 5 files changed, 77 insertions(+)
Hi, Seems good, thanks. Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com> On Fri, Sep 21, 2018 at 04:36:20PM +0100, Andrew Rybchenko wrote: > v3: > - move apply on sync to fs_eth_dev_conf_apply() to apply to > a new subdevice only > - use ethdev API to apply to sub-device on sync > - remove unnecessary check the same pointer from the method > implementation in failsafe > > v2: > - fix setting of zero addresses since rte_realloc() returns NULL > > Evgeny Im (2): > net/failsafe: remove not supported multicast MAC filter > net/failsafe: support multicast address list set > > doc/guides/rel_notes/release_18_11.rst | 7 ++++ > drivers/net/failsafe/failsafe.c | 1 + > drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ > drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ > drivers/net/failsafe/failsafe_private.h | 2 + > 5 files changed, 77 insertions(+) > > -- > 2.17.1 >
On Fri, 21 Sep 2018 16:36:19 +0100 Andrew Rybchenko <arybchenko@solarflare.com> wrote: > v3: > - move apply on sync to fs_eth_dev_conf_apply() to apply to > a new subdevice only > - use ethdev API to apply to sub-device on sync > - remove unnecessary check the same pointer from the method > implementation in failsafe > > v2: > - fix setting of zero addresses since rte_realloc() returns NULL > > Evgeny Im (2): > net/failsafe: remove not supported multicast MAC filter > net/failsafe: support multicast address list set > > doc/guides/rel_notes/release_18_11.rst | 1 + > drivers/net/failsafe/failsafe.c | 1 + > drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ > drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ > drivers/net/failsafe/failsafe_private.h | 2 + > 5 files changed, 71 insertions(+) > Since TAP has no filtering this doesn't really do much for the slowpath.
On 9/21/18 7:21 PM, Stephen Hemminger wrote: > On Fri, 21 Sep 2018 16:36:19 +0100 > Andrew Rybchenko <arybchenko@solarflare.com> wrote: > >> v3: >> - move apply on sync to fs_eth_dev_conf_apply() to apply to >> a new subdevice only >> - use ethdev API to apply to sub-device on sync >> - remove unnecessary check the same pointer from the method >> implementation in failsafe >> >> v2: >> - fix setting of zero addresses since rte_realloc() returns NULL >> >> Evgeny Im (2): >> net/failsafe: remove not supported multicast MAC filter >> net/failsafe: support multicast address list set >> >> doc/guides/rel_notes/release_18_11.rst | 1 + >> drivers/net/failsafe/failsafe.c | 1 + >> drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ >> drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ >> drivers/net/failsafe/failsafe_private.h | 2 + >> 5 files changed, 71 insertions(+) >> > Since TAP has no filtering this doesn't really do much for the slowpath. Yes, I know that TAP does not support it. Is failsafe so tighly bound to TAP to block it?
On 9/21/18 7:33 PM, Andrew Rybchenko wrote: > On 9/21/18 7:21 PM, Stephen Hemminger wrote: >> On Fri, 21 Sep 2018 16:36:19 +0100 >> Andrew Rybchenko <arybchenko@solarflare.com> wrote: >> >>> v3: >>> - move apply on sync to fs_eth_dev_conf_apply() to apply to >>> a new subdevice only >>> - use ethdev API to apply to sub-device on sync >>> - remove unnecessary check the same pointer from the method >>> implementation in failsafe >>> >>> v2: >>> - fix setting of zero addresses since rte_realloc() returns NULL >>> >>> Evgeny Im (2): >>> net/failsafe: remove not supported multicast MAC filter >>> net/failsafe: support multicast address list set >>> >>> doc/guides/rel_notes/release_18_11.rst | 1 + >>> drivers/net/failsafe/failsafe.c | 1 + >>> drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ >>> drivers/net/failsafe/failsafe_ops.c | 50 >>> +++++++++++++++++++++++++ >>> drivers/net/failsafe/failsafe_private.h | 2 + >>> 5 files changed, 71 insertions(+) >>> >> Since TAP has no filtering this doesn't really do much for the slowpath. > > Yes, I know that TAP does not support it. Is failsafe so tighly bound > to TAP to block it? In fact I've put it incorrectly. TAP supports multicast address set, but simply ignores it since "every packet is received". But it is still makes sense for other failsafe sub-devices which really support it.
On Fri, 21 Sep 2018 19:33:16 +0300 Andrew Rybchenko <arybchenko@solarflare.com> wrote: > On 9/21/18 7:21 PM, Stephen Hemminger wrote: > > On Fri, 21 Sep 2018 16:36:19 +0100 > > Andrew Rybchenko <arybchenko@solarflare.com> wrote: > > > >> v3: > >> - move apply on sync to fs_eth_dev_conf_apply() to apply to > >> a new subdevice only > >> - use ethdev API to apply to sub-device on sync > >> - remove unnecessary check the same pointer from the method > >> implementation in failsafe > >> > >> v2: > >> - fix setting of zero addresses since rte_realloc() returns NULL > >> > >> Evgeny Im (2): > >> net/failsafe: remove not supported multicast MAC filter > >> net/failsafe: support multicast address list set > >> > >> doc/guides/rel_notes/release_18_11.rst | 1 + > >> drivers/net/failsafe/failsafe.c | 1 + > >> drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ > >> drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ > >> drivers/net/failsafe/failsafe_private.h | 2 + > >> 5 files changed, 71 insertions(+) > >> > > Since TAP has no filtering this doesn't really do much for the slowpath. > > Yes, I know that TAP does not support it. Is failsafe so tighly bound to > TAP to block it? > failsafe was built to be used with tap and mlx on Azure. It could be used with virtio and other NIC on KVM, but this is mostly theoretical.
On 9/21/2018 5:09 PM, Gaëtan Rivet wrote: > Hi, > > Seems good, thanks. > > Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com> Series applied to dpdk-next-net/master, thanks. > > On Fri, Sep 21, 2018 at 04:36:20PM +0100, Andrew Rybchenko wrote: >> v3: >> - move apply on sync to fs_eth_dev_conf_apply() to apply to >> a new subdevice only >> - use ethdev API to apply to sub-device on sync >> - remove unnecessary check the same pointer from the method >> implementation in failsafe >> >> v2: >> - fix setting of zero addresses since rte_realloc() returns NULL >> >> Evgeny Im (2): >> net/failsafe: remove not supported multicast MAC filter >> net/failsafe: support multicast address list set >> >> doc/guides/rel_notes/release_18_11.rst | 7 ++++ >> drivers/net/failsafe/failsafe.c | 1 + >> drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ >> drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ >> drivers/net/failsafe/failsafe_private.h | 2 + >> 5 files changed, 77 insertions(+) >> >> -- >> 2.17.1 >> >